## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
76 lines
2.3 KiB
TypeScript
76 lines
2.3 KiB
TypeScript
import unescapeJS from "unescape-js";
|
|
import type { PropertyNode } from "../index";
|
|
import { isLiteralNode } from "../index";
|
|
|
|
const beginsWithLineBreakRegex = /^\s+|\s+$/;
|
|
|
|
export function sanitizeScript(js: string, evaluationVersion: number) {
|
|
// We remove any line breaks from the beginning of the script because that
|
|
// makes the final function invalid. We also unescape any escaped characters
|
|
// so that eval can happen
|
|
//default value of evalutaion version is 2
|
|
evaluationVersion = evaluationVersion ? evaluationVersion : 2;
|
|
const trimmedJS = js.replace(beginsWithLineBreakRegex, "");
|
|
|
|
return evaluationVersion > 1 ? trimmedJS : unescapeJS(trimmedJS);
|
|
}
|
|
|
|
// For the times when you need to know if something truly an object like { a: 1, b: 2}
|
|
// typeof, lodash.isObject and others will return false positives for things like array, null, etc
|
|
export const isTrueObject = (
|
|
item: unknown,
|
|
): item is Record<string, unknown> => {
|
|
return Object.prototype.toString.call(item) === "[object Object]";
|
|
};
|
|
|
|
export const getNameFromPropertyNode = (node: PropertyNode): string =>
|
|
isLiteralNode(node.key) ? String(node.key.value) : node.key.name;
|
|
|
|
interface Position {
|
|
line: number;
|
|
ch: number;
|
|
}
|
|
|
|
export const extractContentByPosition = (
|
|
content: string,
|
|
position: { from: Position; to: Position },
|
|
) => {
|
|
const eachLine = content.split("\n");
|
|
|
|
let returnedString = "";
|
|
|
|
for (let i = position.from.line; i <= position.to.line; i++) {
|
|
if (i === position.from.line) {
|
|
returnedString =
|
|
position.from.line !== position.to.line
|
|
? eachLine[position.from.line].slice(position.from.ch)
|
|
: eachLine[position.from.line].slice(
|
|
position.from.ch,
|
|
position.to.ch + 1,
|
|
);
|
|
} else if (i === position.to.line) {
|
|
returnedString += eachLine[position.to.line].slice(0, position.to.ch + 1);
|
|
} else {
|
|
returnedString += eachLine[i];
|
|
}
|
|
|
|
if (i !== position.to.line) {
|
|
returnedString += "\n";
|
|
}
|
|
}
|
|
|
|
return returnedString;
|
|
};
|
|
|
|
export const getStringValue = (
|
|
inputValue: string | number | boolean | RegExp,
|
|
) => {
|
|
if (typeof inputValue === "object" || typeof inputValue === "boolean") {
|
|
inputValue = JSON.stringify(inputValue);
|
|
} else if (typeof inputValue === "number" || typeof inputValue === "string") {
|
|
inputValue += "";
|
|
}
|
|
|
|
return inputValue;
|
|
};
|