PromucFlow_constructor/app/client/src/ce/sagas
Ankita Kinger 85492d8cd6
fix: Adding pageId check to fix private JS object deletion flow on package editor (#30687)
## Description

Adding pageId check to fix private JS object deletion flow on package
editor

#### PR fixes following issue(s)
Fixes # (issue number)

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the logic for deleting JavaScript collections to
conditionally update and save layout, enhancing user experience by
ensuring relevant updates are made only when necessary.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-29 13:48:58 +05:30
..
ActionExecution fix: Preserve query execution data on name refactor (#28973) 2023-11-22 14:04:48 +05:30
analyticsSaga.ts chore: update eslint and dependencies then fix revealed errors (#27908) 2023-10-11 10:14:38 +03:00
ApiCallerSagas.ts chore: module editor api refactor (#28261) 2023-10-20 17:06:39 +05:30
ApplicationSagas.tsx feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
EnvironmentSagas.ts chore: code split for EE PR 2169 (#26669) 2023-09-11 14:09:41 +07:00
GitExtendedSagas.ts feat: branch protection (#28526) 2023-11-03 22:43:36 +05:30
helpers.ts chore: entity name generation refactor to include other entity types (#30316) 2024-01-17 15:34:50 +05:30
index.tsx chore: Remove unused services (#30292) 2024-01-23 05:43:16 +05:30
JSActionSagas.ts fix: Adding pageId check to fix private JS object deletion flow on package editor (#30687) 2024-01-29 13:48:58 +05:30
JSFunctionExecutionSaga.ts chore: Updating instance admin emails input field to tag input field for better UX (#27410) 2023-09-19 11:54:43 +05:30
NavigationSagas.ts chore: Show Tabs on recent access order (#30450) 2024-01-23 10:22:50 +05:30
PageSagas.tsx feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
SuperUserSagas.tsx feat: remove cloudHosting conditional check, change version name (#28086) 2023-10-15 02:11:29 +05:30
tenantSagas.tsx feat: Frontend changes for consolidated-api with EE test case support (#30506) 2024-01-24 12:14:16 +05:30
userSagas.tsx feat: Frontend changes for consolidated-api with EE test case support (#30506) 2024-01-24 12:14:16 +05:30
WorkspaceSagas.ts feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30