## Description > Remove Toast messages on the following scenarios >1. Upon execution of an API/Query/JSFunction. >2. User is in action page and onpageload actions are executed. > ex: User is in API page and the API is set to execute on page load. Now if users refresh application then the API is executed. Now we won't show any toasts but open response tab. > But if user refresh page from canvas or any other page then it's own page , the toasts w.r.t the API execution will be shown. > TL;DR - Toast messages upon action execution is removed and we are serving this by opening the response tab automatically for the users. Fixes #21490 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test
201 lines
6.0 KiB
TypeScript
201 lines
6.0 KiB
TypeScript
import type { EventType } from "constants/AppsmithActionConstants/ActionConstants";
|
|
import type { TriggerMeta } from "@appsmith/sagas/ActionExecution/ActionExecutionSagas";
|
|
import { call, put, spawn, take } from "redux-saga/effects";
|
|
import { logActionExecutionError } from "sagas/ActionExecution/errorUtils";
|
|
import { setUserCurrentGeoLocation } from "actions/browserRequestActions";
|
|
import type { Channel } from "redux-saga";
|
|
import { channel } from "redux-saga";
|
|
import { evalWorker } from "sagas/EvaluationsSaga";
|
|
import type {
|
|
TGetGeoLocationDescription,
|
|
TWatchGeoLocationDescription,
|
|
} from "workers/Evaluation/fns/geolocationFns";
|
|
|
|
class GeoLocationError extends Error {
|
|
constructor(message: string, private responseData?: any) {
|
|
super(message);
|
|
}
|
|
}
|
|
|
|
let successChannel: Channel<GeolocationPosition> | null = null;
|
|
let errorChannel: Channel<GeolocationPositionError> | null = null;
|
|
|
|
// Making the getCurrentPosition call in a promise fashion
|
|
export const getUserLocation = (options?: PositionOptions) =>
|
|
new Promise((resolve, reject) => {
|
|
navigator.geolocation.getCurrentPosition(
|
|
(location) => resolve(location),
|
|
(error) => reject(error),
|
|
options,
|
|
);
|
|
});
|
|
|
|
/**
|
|
* We need to extract and set certain properties only because the
|
|
* return value is a "class" with functions as well and
|
|
* that cant be stored in the data tree
|
|
**/
|
|
export const extractGeoLocation = (
|
|
location: GeolocationPosition,
|
|
): GeolocationPosition => {
|
|
const {
|
|
coords: {
|
|
accuracy,
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
speed,
|
|
},
|
|
} = location;
|
|
const coords: GeolocationCoordinates = {
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
accuracy,
|
|
speed,
|
|
};
|
|
return {
|
|
coords,
|
|
timestamp: location.timestamp,
|
|
};
|
|
};
|
|
|
|
/**
|
|
* When location access is turned off in the browser, the error is a GeolocationPositionError instance
|
|
* We can't pass this instance to the worker thread as it uses structured cloning for copying the objects
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
|
|
* It doesn't support some entities like DOM Nodes, functions etc. for copying
|
|
* And will throw an error if we try to pass it
|
|
* GeolocationPositionError instance doesn't exist in worker thread hence not supported by structured cloning
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/GeolocationPositionError
|
|
* Hence we're creating a new object with same structure which can be passed to the worker thread
|
|
*/
|
|
function sanitizeGeolocationError(error: GeolocationPositionError) {
|
|
const { code, message } = error;
|
|
return {
|
|
code,
|
|
message,
|
|
};
|
|
}
|
|
|
|
function* successCallbackHandler(listenerId?: string) {
|
|
let payload: GeolocationPosition;
|
|
if (!successChannel) return;
|
|
while ((payload = yield take(successChannel))) {
|
|
const currentLocation = extractGeoLocation(payload);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
if (listenerId)
|
|
yield call(evalWorker.ping, { data: currentLocation }, listenerId);
|
|
}
|
|
}
|
|
|
|
function* errorCallbackHandler(triggerMeta: TriggerMeta, listenerId?: string) {
|
|
if (!errorChannel) return;
|
|
let error: GeolocationPositionError;
|
|
while ((error = yield take(errorChannel))) {
|
|
if (listenerId)
|
|
yield call(
|
|
evalWorker.ping,
|
|
{ error: sanitizeGeolocationError(error) },
|
|
listenerId,
|
|
);
|
|
logActionExecutionError(
|
|
error.message,
|
|
true,
|
|
triggerMeta.source,
|
|
triggerMeta.triggerPropertyName,
|
|
);
|
|
}
|
|
}
|
|
|
|
export function* getCurrentLocationSaga(
|
|
action: TGetGeoLocationDescription,
|
|
_: EventType,
|
|
triggerMeta: TriggerMeta,
|
|
) {
|
|
const { payload: actionPayload } = action;
|
|
try {
|
|
const location: GeolocationPosition = yield call(
|
|
getUserLocation,
|
|
actionPayload.options,
|
|
);
|
|
const currentLocation = extractGeoLocation(location);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
return currentLocation;
|
|
} catch (error) {
|
|
logActionExecutionError(
|
|
(error as Error).message,
|
|
true,
|
|
triggerMeta.source,
|
|
triggerMeta.triggerPropertyName,
|
|
);
|
|
if (error instanceof GeolocationPositionError) {
|
|
const sanitizedError = sanitizeGeolocationError(error);
|
|
throw new GeoLocationError(sanitizedError.message, [sanitizedError]);
|
|
}
|
|
}
|
|
}
|
|
|
|
let watchId: number | undefined;
|
|
export function* watchCurrentLocation(
|
|
action: TWatchGeoLocationDescription,
|
|
_: EventType,
|
|
triggerMeta: TriggerMeta,
|
|
) {
|
|
const { payload: actionPayload } = action;
|
|
if (watchId) {
|
|
// When a watch is already active, we will not start a new watch.
|
|
// at a given point in time, only one watch is active
|
|
logActionExecutionError(
|
|
"A watchLocation is already active. Clear it before before starting a new one",
|
|
true,
|
|
triggerMeta.source,
|
|
triggerMeta.triggerPropertyName,
|
|
);
|
|
|
|
return;
|
|
}
|
|
successChannel = channel<GeolocationPosition>();
|
|
errorChannel = channel<GeolocationPositionError>();
|
|
yield spawn(successCallbackHandler, actionPayload.listenerId);
|
|
yield spawn(errorCallbackHandler, triggerMeta, actionPayload.listenerId);
|
|
watchId = navigator.geolocation.watchPosition(
|
|
(location) => {
|
|
successChannel?.put(location);
|
|
},
|
|
(error) => {
|
|
// When location is turned off, the watch fails but watchId is generated
|
|
// Resetting the watchId to undefined so that a new watch can be started
|
|
if (watchId) {
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
}
|
|
errorChannel?.put(error);
|
|
},
|
|
actionPayload.options,
|
|
);
|
|
}
|
|
|
|
export function* stopWatchCurrentLocation(
|
|
eventType: EventType,
|
|
triggerMeta: TriggerMeta,
|
|
) {
|
|
if (watchId === undefined) {
|
|
logActionExecutionError(
|
|
"No location watch active",
|
|
true,
|
|
triggerMeta.source,
|
|
triggerMeta.triggerPropertyName,
|
|
);
|
|
return;
|
|
}
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
successChannel?.close();
|
|
errorChannel?.close();
|
|
}
|