cf880ff045
## Description When we create snowflake datasource with wrong credentials -> test configuration/query execution takes about 25 seconds to complete and then throws generic error message of `Unable to create connection to snowflake URL`. This error message does not provide any action items for user. The reason this generic error message gets thrown is because we had set `initializationFailTimeout` hikari config property to -1, which means it will create a datasource object but will not create connection to it. Only when we do testDatasource, we fetch the hikari datasource object using `getConnection` method. This method tries to establish connection to database and keeps trying until it is successful or timeout of 25 seconds is reached, that's why in our case hikari would throw interrupted during connection acquisition exception after 25 seconds and on our plugin code, we would wrap this up in a generic error message mentioned above. The fix is to remove the code where we are setting this initializationFailTimeout, the default value for this property is 1ms and what this is does is, it tries to establish connection with snowflake db within that 1ms and if it can't it throws PoolInitializationException along with error message sent by snowflake jdbc driver itself, thus we can use this message to show it in the UI. This initialization was set to -1 in [PR](https://github.com/appsmithorg/appsmith/pull/23270) which we had fixed for handling wrong credentials. ### Steps to test: 1. Create snowflake datasource with wrong credentials (In both basic and key pair auth) 2. Test the configuration 3. Save the datasources and execute a query on it (check the error message) 4. Test #16140 5. Test #22035 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9934985863> > Commit: 8e21675e47f31ebf846c04dbab40193b571f5273 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9934985863&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource, @tag.Sanity` > Spec: > <hr>Mon, 15 Jul 2024 07:27:31 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved connection initialization behavior in the Snowflake plugin, enhancing startup validations and reliability. - **Tests** - Updated and refined test cases for datasource, key pair authentication, and basic authentication in the Snowflake plugin to ensure robustness and accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|---|---|---|
| .. | ||
| .run | ||
| appsmith-git | ||
| appsmith-interfaces | ||
| appsmith-plugins | ||
| appsmith-server | ||
| envs | ||
| mongo-seed | ||
| reactive-caching | ||
| scripts | ||
| .gitignore | ||
| build.sh | ||
| buildpack-run.sh | ||
| pom.xml | ||
| Procfile | ||
| README.md | ||
| system.properties | ||
Appsmith Server
This is the server-side repository for the Appsmith framework.
For details on setting up your development machine, please refer to this Setup Guide.