## Description Currently, we check to see if the URL that is passed to the `navigateTo` method starts with http(s), mailTo or tel. This limits the capability to load/navigate to other URLs that do not conform to these protocols. This PR remove this crude protocol check and only checks to see if the navigateTo argument is a valid URL. > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes #4878 > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? - [x] Manual > > #### Test Plan 1. Verify NavigateTo() for https:// mailTo ftp urls 2. Verify NavigateTo for above protocol from jsobject and from Action selector 3. Verify NavigateTo for same and NewWindow with above URLs #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
42 lines
1.2 KiB
TypeScript
42 lines
1.2 KiB
TypeScript
import _ from "lodash";
|
|
|
|
export function getQueryParams() {
|
|
const urlParams = new URLSearchParams(window.location.search);
|
|
const keys = urlParams.keys();
|
|
let key = keys.next().value;
|
|
const queryParams: Record<string, string> = {};
|
|
while (key) {
|
|
queryParams[key] = urlParams.get(key) as string;
|
|
key = keys.next().value;
|
|
}
|
|
return queryParams;
|
|
}
|
|
|
|
export function convertObjectToQueryParams(object: any): string {
|
|
if (!_.isNil(object)) {
|
|
const paramArray: string[] = _.map(_.keys(object), (key) => {
|
|
return encodeURIComponent(key) + "=" + encodeURIComponent(object[key]);
|
|
});
|
|
return "?" + _.join(paramArray, "&");
|
|
} else {
|
|
return "";
|
|
}
|
|
}
|
|
|
|
export function isValidURL(url: string): boolean {
|
|
try {
|
|
new URL(url);
|
|
return true;
|
|
} catch (e) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
export function matchesURLPattern(url: string) {
|
|
return (
|
|
url.match(
|
|
/\(?(?:(http|https|ftp|mailto|tel):\/\/)?(?:((?:[^\W\s]|\.|-|[:]{1})+)@{1})?((?:www.)?(?:[^\W\s]|\.|-)+[\.][^\W\s]{2,4}|localhost(?=\/)|\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})(?::(\d*))?([\/]?[^\s\?]*[\/]{1})*(?:\/?([^\s\n\?\[\]\{\}\#]*(?:(?=\.)){1}|[^\s\n\?\[\]\{\}\.\#]*)?([\.]{1}[^\s\?\#]*)?)?(?:\?{1}([^\s\n\#\[\]]*))?([\#][^\s\n]*)?\)?/g,
|
|
) !== null
|
|
);
|
|
}
|