## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
96 lines
2.9 KiB
TypeScript
96 lines
2.9 KiB
TypeScript
import React from "react";
|
|
import PropertyControlFactory from "./PropertyControlFactory";
|
|
import type { PropertyControlPropsType } from "components/propertyControls";
|
|
import { PropertyControls } from "components/propertyControls";
|
|
import type { ControlProps } from "components/propertyControls/BaseControl";
|
|
import type BaseControl from "components/propertyControls/BaseControl";
|
|
import type { InteractionAnalyticsEventDetail } from "./AppsmithUtils";
|
|
import {
|
|
interactionAnalyticsEvent,
|
|
INTERACTION_ANALYTICS_EVENT,
|
|
} from "./AppsmithUtils";
|
|
|
|
function withAnalytics(WrappedControl: typeof BaseControl) {
|
|
return class AnalyticsHOC extends React.PureComponent<ControlProps> {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
containerRef = React.createRef<any>();
|
|
|
|
constructor(props: ControlProps) {
|
|
super(props);
|
|
}
|
|
|
|
componentDidMount() {
|
|
this.containerRef.current?.addEventListener(
|
|
INTERACTION_ANALYTICS_EVENT,
|
|
this.handleKbdEvent,
|
|
);
|
|
}
|
|
|
|
componentWillUnmount() {
|
|
this.containerRef.current?.removeEventListener(
|
|
INTERACTION_ANALYTICS_EVENT,
|
|
this.handleKbdEvent,
|
|
);
|
|
}
|
|
|
|
handleKbdEvent = (e: Event) => {
|
|
const event = e as CustomEvent<InteractionAnalyticsEventDetail>;
|
|
|
|
if (!event.detail?.propertyName) {
|
|
e.stopPropagation();
|
|
this.containerRef.current?.dispatchEvent(
|
|
interactionAnalyticsEvent({
|
|
key: event.detail.key,
|
|
propertyType: AnalyticsHOC.getControlType(),
|
|
propertyName: this.props.propertyName,
|
|
widgetType: this.props.widgetProperties.type,
|
|
}),
|
|
);
|
|
}
|
|
};
|
|
|
|
static getControlType() {
|
|
return WrappedControl.getControlType();
|
|
}
|
|
|
|
render() {
|
|
return (
|
|
<div ref={this.containerRef}>
|
|
<WrappedControl {...this.props} />
|
|
</div>
|
|
);
|
|
}
|
|
};
|
|
}
|
|
|
|
class PropertyControlRegistry {
|
|
static registerPropertyControlBuilders() {
|
|
Object.values(PropertyControls).forEach(
|
|
(Control: typeof BaseControl & { getControlType: () => string }) => {
|
|
const ControlWithAnalytics = withAnalytics(Control);
|
|
const controlType = ControlWithAnalytics.getControlType();
|
|
|
|
PropertyControlFactory.registerControlBuilder(
|
|
controlType,
|
|
{
|
|
buildPropertyControl(
|
|
controlProps: PropertyControlPropsType,
|
|
): JSX.Element {
|
|
return <ControlWithAnalytics {...controlProps} />;
|
|
},
|
|
},
|
|
{
|
|
canDisplayValueInUI: Control.canDisplayValueInUI,
|
|
shouldValidateValueOnDynamicPropertyOff:
|
|
Control.shouldValidateValueOnDynamicPropertyOff,
|
|
},
|
|
Control.getInputComputedValue,
|
|
);
|
|
},
|
|
);
|
|
}
|
|
}
|
|
|
|
export default PropertyControlRegistry;
|