## Description - Removes overflow property from Text widgets within List - Fix issue where the image widget disappears from List widget when resizing - Fix issue where last widget crops when scrolling enabled in List widget container #### PR fixes following issue(s) Fixes #23181 Fixes #22833 Fixes #23178 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com> Co-authored-by: rahulramesha <rahul@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
51 lines
1.4 KiB
TypeScript
51 lines
1.4 KiB
TypeScript
import WidgetFactory from "utils/WidgetFactory";
|
|
import { BlueprintOperationTypes } from "widgets/constants";
|
|
|
|
import type { BlueprintOperation } from "./WidgetBlueprintSagas";
|
|
import { executeWidgetBlueprintChildOperations } from "./WidgetBlueprintSagas";
|
|
|
|
describe("WidgetBlueprintSagas", () => {
|
|
it("should returns widgets after executing the child operation", async () => {
|
|
const mockBlueprintChildOperation: BlueprintOperation = {
|
|
type: BlueprintOperationTypes.CHILD_OPERATIONS,
|
|
fn: () => {
|
|
return { widgets: {} };
|
|
},
|
|
};
|
|
|
|
jest
|
|
.spyOn(WidgetFactory, "getWidgetDefaultPropertiesMap")
|
|
.mockReturnValue({});
|
|
|
|
const generator = executeWidgetBlueprintChildOperations(
|
|
mockBlueprintChildOperation,
|
|
{
|
|
widgetId: {
|
|
image: "",
|
|
defaultImage: "",
|
|
widgetId: "Widget1",
|
|
type: "LIST_WIDGET",
|
|
widgetName: "List1",
|
|
parentId: "parentId",
|
|
renderMode: "CANVAS",
|
|
parentColumnSpace: 2,
|
|
parentRowSpace: 3,
|
|
leftColumn: 2,
|
|
rightColumn: 3,
|
|
topRow: 1,
|
|
bottomRow: 3,
|
|
isLoading: false,
|
|
items: [],
|
|
version: 16,
|
|
disablePropertyPane: false,
|
|
},
|
|
},
|
|
["widgetId"],
|
|
"parentId",
|
|
);
|
|
|
|
generator.next();
|
|
expect(generator.next().value).toStrictEqual({});
|
|
});
|
|
});
|