25e83f6603
## Description - This PR fixes the MySql plugin server unit tests which started to fail after increasing the max connection pool size from 5 to [20](https://github.com/appsmithorg/appsmith/pull/36631/files). The failures were due to the `Too Many Connections` error because of the connections not getting closed. - In this PR, I have added the code to close connections after each test is executed. Fixes #36656 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11147034776> > Commit: 3b9f5791cbd8d95f74f4a89ad204d1d4152445e0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11147034776&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 02 Oct 2024 16:20:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Updated the expected default value for the maximum connection pool size in tests to ensure accuracy. - **Chores** - Improved management of MySQL connection context to prevent resource leaks in tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Manish Kumar <107841575+sondermanish@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| pom.xml | ||