PromucFlow_constructor

Go to file

sneha122 756dc5421e fix: skipped unnecessary code for js object updates (#37125 ) ## Description This PR is in continuation to [PR](https://github.com/appsmithorg/appsmith/pull/37062) which we had merged earlier, In previous, we skipped the redundant calls to update page layout when updating each js object action, as we already have a call for [updating the page layout for actionCollection](`27bdeb92b6/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/LayoutCollectionServiceCEImpl.java (L411)`) Since we have skipped the update page layout for each js action, we no longer need the code part after this, which basically fetches page data from DB and updates the `errorReports` in actionDTO based on layout `layoutOnLoadActionErrors`. This PR skips this unnecessary part too for each js action as we do [set the errorReport for actionCollection in the end](`27bdeb92b6/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/LayoutCollectionServiceCEImpl.java (L430)`) ### Will this have any impact on error messages shown to user? In order to understand this, checked out the frontend code to see if errorReports from individual js action is getting consumed on updating js object, looks like [it is not](`e7e3d5e002/app/client/src/sagas/JSPaneSagas.ts (L316)`), so we can safely remove this piece of code. However this points to existing bug in the code (as errorReports is not even getting consumed from actionCollection), which is, when there is cyclic dependency created for js object with a widget, we don't get any toast message. Since this is existing issue which is not caused by any of the above PR implementations, creating separate issue for it and tracking it [here](https://github.com/appsmithorg/appsmith/issues/37129) Fixes #37114 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.JS, @tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11698258739> > Commit: 9fbde996545451c1a12736e0b8a9252ad4ab69bd > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11698258739&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.JS, @tag.JS` > Spec: > <hr>Wed, 06 Nov 2024 06:50:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Streamlined layout update process for actions, enhancing performance and clarity. - Bug Fixes - Improved test reliability by monitoring interactions with the layout service and handling cyclic dependencies. - Documentation - Updated comments to clarify the logic behind layout updates for JS actions. - Tests - Enhanced test descriptions and assertions for better clarity and validation of method interactions, including cyclic dependency scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>		2024-11-06 12:55:11 +05:30
.github	chore: New schema change for vulnerabilities test (#37204 )	2024-11-05 12:11:51 +05:30
app	fix: skipped unnecessary code for js object updates (#37125 )	2024-11-06 12:55:11 +05:30
contributions	chore: Added details for running local setup (#35968 )	2024-09-09 11:01:38 +05:30
deploy	chore: Add mongo data migration check before initializing the postgres dump (#37059 )	2024-11-05 08:26:02 +05:30
scripts	chore: New schema change for vulnerabilities test (#37204 )	2024-11-05 12:11:51 +05:30
static	Add files via upload	2023-08-11 19:09:51 +05:30
utils/observability	chore: Adding Redis metrics and dashboard to observability stack (#24755 )	2023-06-27 11:19:09 +05:30
.coderabbit.yaml	chore: Updated the coderabbit tone of voice (#36946 )	2024-10-17 17:46:52 +05:30
.deepsource.toml	Create .deepsource.toml (#3593 )	2021-03-19 11:40:59 +05:30
.editorconfig	feat: Make images adaptable to support both Postgres and MongoDB uris (#36424 )	2024-09-19 21:45:46 +05:30
.env.example	chore: Remove unused services (#30292 )	2024-01-23 05:43:16 +05:30
.gitignore	feat: Make images adaptable to support both Postgres and MongoDB uris (#36424 )	2024-09-19 21:45:46 +05:30
.imgbotconfig	Added imgbot config file (#1655 )	2020-11-09 17:52:53 +05:30
.nojekyll	Add a nojekyll file for helm charts to work	2021-11-26 14:04:22 +05:30
app.json	test: Enable server tests for the PRs with base PG branch (#33429 )	2024-05-22 15:55:20 +05:30
appsmith_events.md	docs: Updated appsmith_events.md and SECURITY.md (#8921 )	2021-11-12 13:42:41 +05:30
appsmith_templates.md	feat: migrate from org to workspace under phase 3 (#14158 )	2022-07-20 17:24:16 +05:30
ci-debug.sh	ci: CI optimisation to reduce ci-test run time and modularise docker image building (#21219 )	2023-03-10 12:51:32 +05:30
CODE_OF_CONDUCT.md
CODEOWNERS	chore: update code owner for migrations (#36769 )	2024-10-09 12:24:24 +05:30
CONTRIBUTING.md	docs: Updating contribution guidelines (#18190 )	2022-11-23 11:41:40 +05:30
depot.json	ci: Fixing the RTS build workflow (#16748 )	2022-09-14 14:24:20 +05:30
Dockerfile	feat: Make images adaptable to support both Postgres and MongoDB uris (#36424 )	2024-09-19 21:45:46 +05:30
heroku.yml	Heroku Button implementation (#1721 )	2020-11-18 18:53:59 +05:30
IssuesReport.md	Feature/hacktoberfest (#841 )	2020-09-30 23:23:10 +05:30
LICENSE	Update LICENSE	2021-05-27 12:53:55 +05:30
README.md	Update top contributors	2023-11-17 06:55:30 +05:30
SECURITY.md	docs: Updated appsmith_events.md and SECURITY.md (#8921 )	2021-11-12 13:42:41 +05:30

README.md

Organizations build internal applications such as dashboards, database GUIs, admin panels, approval apps, customer support dashboards, and more to help their teams perform day-to-day operations. Appsmith is an open-source tool that enables the rapid development of these internal apps. Read more on our website.

Installation

There are two ways to start using Appsmith:

Signup on Appsmith Cloud.
Install Appsmith on your machine. See the installation guides below.

Installation Methods	Documentation
	Docker (Recommended)
	Kubernetes
	AWS AMI

For other deployment options, see the Installation Guides documentation.

Development

To build and run Appsmith in your local dev environment, see Setup for local development.

Learning Resources

Need Help?

Contributing

We ❤️ our contributors. We're committed to fostering an open, welcoming, and safe environment in the community.

📕 We expect everyone participating in the community to abide by our Code of Conduct. Please read and follow it.
🤝 If you'd like to contribute, start by reading our Contribution Guide.
👾 Explore some good first issues.

Let's build great software together.

Top Contributors

License

Appsmith is licensed under the terms of Apache License 2.0.