116235977f
## Description > Refactor the User creation workflow. > Changes: > - Changed the access of `addUserPolicies` to protected so that it can be overridden in `UserServiceImpl.java`. > - Added `addUserPoliciesAndSaveToRepo` which wraps around `addUserPolicies` and then saves the updated user object to Database. > - Removed a few debug logs, which were added earlier. > - Updated the test case assertions in `createNewUser_WhenEmailHasUpperCase_SavedInLowerCase` and `createNewUserValid` #### PR fixes following issue(s) Fixes # (issue number) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > No testing required as we are widening the scope of a method. ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| auth-notes | ||
| pom.xml | ||