We were using the AppState incorrectly in our selectors. We should use `DefaultRootState` from react-redux. /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated state parameter types in numerous selectors and hooks across the application from a custom application state type to a standard Redux root state type, enhancing type consistency and maintainability without impacting functionality or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14771101257> > Commit: 48aef24d9a54ee63d06943128f7545ba0d461172 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14771101257&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 01 May 2025 07:16:33 UTC <!-- end of auto-generated comment: Cypress test results -->
111 lines
3.0 KiB
TypeScript
111 lines
3.0 KiB
TypeScript
import store from "store";
|
|
import { EditorViewMode } from "IDE/Interfaces/EditorTypes";
|
|
import type { DefaultRootState } from "react-redux";
|
|
import MockPluginsState from "test/factories/MockPluginsState";
|
|
import type { Action } from "entities/Action";
|
|
import type {
|
|
IDETabs,
|
|
ParentEntityIDETabs,
|
|
} from "reducers/uiReducers/ideReducer";
|
|
import { IDETabsDefaultValue } from "reducers/uiReducers/ideReducer";
|
|
import type { JSCollection } from "entities/JSCollection";
|
|
import type { FocusHistory } from "reducers/uiReducers/focusHistoryReducer";
|
|
import type { Datasource } from "entities/Datasource";
|
|
import type { FeatureFlags } from "ee/entities/FeatureFlag";
|
|
import type { Page } from "entities/Page";
|
|
|
|
interface IDEStateArgs {
|
|
ideView?: EditorViewMode;
|
|
pages?: Page[];
|
|
actions?: Action[];
|
|
js?: JSCollection[];
|
|
tabs?: IDETabs;
|
|
branch?: string;
|
|
focusHistory?: FocusHistory;
|
|
datasources?: Datasource[];
|
|
featureFlags?: Partial<FeatureFlags>;
|
|
}
|
|
|
|
export const getIDETestState = ({
|
|
actions = [],
|
|
branch,
|
|
datasources = [],
|
|
featureFlags,
|
|
focusHistory = {},
|
|
ideView = EditorViewMode.FullScreen,
|
|
js = [],
|
|
pages = [],
|
|
tabs = IDETabsDefaultValue,
|
|
}: IDEStateArgs): DefaultRootState => {
|
|
const initialState = store.getState();
|
|
|
|
const pageList = {
|
|
pages,
|
|
isGeneratingTemplatePage: false,
|
|
applicationId: "655716e035e2c9432e4bd94b",
|
|
baseApplicationId: "655716e035e2c9432e4bd94b",
|
|
currentPageId: pages[0]?.pageId,
|
|
currentBasePageId: pages[0]?.basePageId,
|
|
defaultPageId: pages[0]?.pageId,
|
|
defaultBasePageId: pages[0]?.basePageId,
|
|
loading: {},
|
|
};
|
|
|
|
let ideTabs: ParentEntityIDETabs = {};
|
|
|
|
if (pageList.currentBasePageId) {
|
|
ideTabs = { [pageList.currentBasePageId]: tabs };
|
|
}
|
|
|
|
const actionData = actions.map((a) => ({ isLoading: false, config: a }));
|
|
const jsData = js.map((a) => ({ isLoading: false, config: a }));
|
|
const featureFlag = featureFlags ? { data: featureFlags } : {};
|
|
|
|
return {
|
|
...initialState,
|
|
entities: {
|
|
...initialState.entities,
|
|
datasources: {
|
|
...initialState.entities.datasources,
|
|
list: datasources,
|
|
},
|
|
plugins: MockPluginsState,
|
|
pageList: pageList,
|
|
actions: actionData,
|
|
jsActions: jsData,
|
|
},
|
|
ui: {
|
|
...initialState.ui,
|
|
users: {
|
|
...initialState.ui.users,
|
|
featureFlag,
|
|
},
|
|
ide: {
|
|
...initialState.ui.ide,
|
|
view: ideView,
|
|
tabs: ideTabs,
|
|
},
|
|
focusHistory: {
|
|
history: {
|
|
...focusHistory,
|
|
},
|
|
},
|
|
editor: {
|
|
...initialState.ui.editor,
|
|
initialized: true,
|
|
},
|
|
applications: {
|
|
...initialState.ui.applications,
|
|
currentApplication: branch
|
|
? {
|
|
...initialState.ui.applications.currentApplication,
|
|
gitApplicationMetadata: {
|
|
branchName: branch || "",
|
|
},
|
|
}
|
|
: { ...initialState.ui.applications.currentApplication },
|
|
},
|
|
},
|
|
};
|
|
};
|