We were using the AppState incorrectly in our selectors. We should use `DefaultRootState` from react-redux. /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated state parameter types in numerous selectors and hooks across the application from a custom application state type to a standard Redux root state type, enhancing type consistency and maintainability without impacting functionality or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14771101257> > Commit: 48aef24d9a54ee63d06943128f7545ba0d461172 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14771101257&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 01 May 2025 07:16:33 UTC <!-- end of auto-generated comment: Cypress test results -->
41 lines
1.1 KiB
TypeScript
41 lines
1.1 KiB
TypeScript
import type { DefaultRootState } from "react-redux";
|
|
import type { widgetReflow } from "reducers/uiReducers/reflowReducer";
|
|
import { createSelector } from "reselect";
|
|
import { getIsResizing } from "./widgetSelectors";
|
|
|
|
export const getReflow = (state: DefaultRootState): widgetReflow =>
|
|
state.ui.widgetReflow;
|
|
|
|
export const getIsReflowing = (state: DefaultRootState): boolean =>
|
|
state.ui.widgetReflow.isReflowing;
|
|
|
|
export const getReflowSelector = (widgetId: string) => {
|
|
return createSelector(getReflow, (reflowState: widgetReflow) => {
|
|
if (reflowState?.reflowingWidgets) {
|
|
return reflowState?.reflowingWidgets[widgetId];
|
|
}
|
|
|
|
return undefined;
|
|
});
|
|
};
|
|
|
|
export const getIsReflowEffectedSelector = (
|
|
widgetId: string | undefined,
|
|
reflowed: boolean,
|
|
) => {
|
|
return createSelector(
|
|
(state: DefaultRootState) => state.ui.widgetDragResize.dragDetails,
|
|
getIsResizing,
|
|
(dragDetails, isResizing) => {
|
|
return (
|
|
((widgetId &&
|
|
dragDetails &&
|
|
!!dragDetails.draggedOn &&
|
|
dragDetails.draggedOn === widgetId) ||
|
|
isResizing) &&
|
|
reflowed
|
|
);
|
|
},
|
|
);
|
|
};
|