We were using the AppState incorrectly in our selectors. We should use `DefaultRootState` from react-redux. /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated state parameter types in numerous selectors and hooks across the application from a custom application state type to a standard Redux root state type, enhancing type consistency and maintainability without impacting functionality or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14771101257> > Commit: 48aef24d9a54ee63d06943128f7545ba0d461172 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14771101257&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 01 May 2025 07:16:33 UTC <!-- end of auto-generated comment: Cypress test results -->
40 lines
1.1 KiB
TypeScript
40 lines
1.1 KiB
TypeScript
import { createSelector } from "reselect";
|
|
import type { DefaultRootState } from "react-redux";
|
|
import type { AppViewReduxState } from "reducers/uiReducers/appViewReducer";
|
|
import type { PageListReduxState } from "reducers/entityReducers/pageListReducer";
|
|
|
|
const getAppViewState = (state: DefaultRootState) => state.ui.appView;
|
|
const getPageListState = (state: DefaultRootState): PageListReduxState =>
|
|
state.entities.pageList;
|
|
|
|
export const getPageList = createSelector(
|
|
getPageListState,
|
|
(pageList: PageListReduxState) =>
|
|
pageList.pages.length > 0 ? pageList.pages : undefined,
|
|
);
|
|
|
|
export const getIsFetchingPage = createSelector(
|
|
getAppViewState,
|
|
(view: AppViewReduxState) => view.isFetchingPage,
|
|
);
|
|
|
|
export const getIsInitialized = createSelector(
|
|
getAppViewState,
|
|
(view: AppViewReduxState) => view.initialized,
|
|
);
|
|
|
|
export const getCurrentDSLPageId = createSelector(
|
|
getPageListState,
|
|
(pageList: PageListReduxState) => pageList.currentPageId,
|
|
);
|
|
|
|
/**
|
|
* returns the height of header in app view mode
|
|
*
|
|
* @param state
|
|
* @returns
|
|
*/
|
|
export const getAppViewHeaderHeight = (state: DefaultRootState) => {
|
|
return state.ui.appView.headerHeight;
|
|
};
|