8b912bff5d
## Description * Currently we do not reset the template filters when we close template modal and open it again in `add page from template flow` This becomes confusing for some users. * Also increases test coverage of templates filtering #### PR fixes following issue(s) Fixes #17276 #### Media https://github.com/appsmithorg/appsmith/assets/6761673/3c94e21b-e8a9-4c6b-bc81-e677269bb5ea #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [x] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
78 lines
2.4 KiB
TypeScript
78 lines
2.4 KiB
TypeScript
import { ObjectsRegistry } from "../Objects/Registry";
|
|
|
|
// Edit mode modal
|
|
export class Templates {
|
|
private agHelper = ObjectsRegistry.AggregateHelper;
|
|
private homePage = ObjectsRegistry.HomePage;
|
|
public locators = {
|
|
_templatesTab: ".t--templates-tab",
|
|
_forkApp: ".t--fork-template",
|
|
_templateCard: "[data-testid='template-card']",
|
|
_templatesSearchInput: "[data-testid='t--application-search-input']",
|
|
_resultsHeader: "[data-testid='t--application-templates-results-header']",
|
|
_templateViewGoBack: "[data-testid='t--template-view-goback']",
|
|
templateDialogBox: "[data-testid=t--templates-dialog-component]",
|
|
_closeTemplateDialogBoxBtn: ".ads-v2-modal__content-header-close-button",
|
|
_requestForTemplateBtn: "span:contains('Request for a template')",
|
|
};
|
|
|
|
FilterTemplatesByName(query: string) {
|
|
return ObjectsRegistry.AggregateHelper.TypeText(
|
|
this.locators._templatesSearchInput,
|
|
query,
|
|
);
|
|
}
|
|
|
|
AssertResultsHeaderText(
|
|
text: string,
|
|
textPresence: "have.text" | "contain.text" | "not.have.text" = "have.text",
|
|
) {
|
|
ObjectsRegistry.AggregateHelper.GetNAssertElementText(
|
|
this.locators._resultsHeader,
|
|
text,
|
|
textPresence,
|
|
);
|
|
}
|
|
|
|
GetTemplatesCardsList() {
|
|
return cy.get(this.locators._templateCard);
|
|
}
|
|
|
|
public SwitchToTemplatesTab() {
|
|
cy.url().then((url) => {
|
|
if (!url.endsWith("applications")) {
|
|
this.homePage.NavigateToHome();
|
|
}
|
|
this.agHelper.GetNClick(this.locators._templatesTab);
|
|
this.agHelper.AssertElementVisible(
|
|
this.locators._requestForTemplateBtn,
|
|
0,
|
|
30000,
|
|
); //giving more time here for templates page to fully load, since there is no intercept validation for same
|
|
});
|
|
}
|
|
|
|
RefreshTemplatesPage(
|
|
withDummyData: boolean,
|
|
templateFixture = "Templates/AllowPageImportTemplates.json",
|
|
) {
|
|
if (withDummyData) {
|
|
cy.fixture(templateFixture).then((templatesData) => {
|
|
cy.intercept(
|
|
{
|
|
method: "GET",
|
|
url: "/api/v1/app-templates",
|
|
},
|
|
{
|
|
statusCode: 200,
|
|
body: templatesData,
|
|
},
|
|
);
|
|
});
|
|
}
|
|
cy.intercept("GET", "/api/v1/app-templates/filters").as("fetchFilters");
|
|
this.agHelper.RefreshPage(false, "fetchFilters");
|
|
this.agHelper.AssertElementVisible(this.locators._templateCard);
|
|
}
|
|
}
|