## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
85 lines
2.4 KiB
TypeScript
85 lines
2.4 KiB
TypeScript
import type { DataTree } from "entities/DataTree/dataTreeTypes";
|
|
import { createSelector } from "reselect";
|
|
import WidgetFactory from "WidgetProvider/factory";
|
|
import type { FlattenedWidgetProps } from "WidgetProvider/constants";
|
|
import type { JSLibrary } from "workers/common/JSLibrary";
|
|
import { getDataTree } from "./dataTreeSelectors";
|
|
import {
|
|
getExistingPageNames,
|
|
selectInstalledLibraries,
|
|
} from "ee/selectors/entitiesSelector";
|
|
import {
|
|
getErrorForApiName,
|
|
getErrorForJSObjectName,
|
|
getIsSavingForApiName,
|
|
getIsSavingForJSObjectName,
|
|
} from "./ui";
|
|
import { getParentWidget } from "./widgetSelectors";
|
|
|
|
/**
|
|
* Selector to return names that are already taken by other api, js objects, pagenames etc.
|
|
*/
|
|
export const getUsedActionNames = createSelector(
|
|
getExistingPageNames,
|
|
getDataTree,
|
|
getParentWidget,
|
|
selectInstalledLibraries,
|
|
(
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
pageNames: Record<string, any>,
|
|
dataTree: DataTree,
|
|
parentWidget: FlattenedWidgetProps | undefined,
|
|
installedLibraries: JSLibrary[],
|
|
) => {
|
|
const map: Record<string, boolean> = {};
|
|
|
|
// The logic has been copied from Explorer/Entity/Name.tsx Component.
|
|
// Todo(abhinav): abstraction leak
|
|
if (
|
|
parentWidget &&
|
|
parentWidget.type === WidgetFactory.widgetTypes.TABS_WIDGET
|
|
) {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
Object.values(parentWidget.tabsObj).forEach((tab: any) => {
|
|
map[tab.label] = true;
|
|
});
|
|
} else {
|
|
pageNames.forEach((pageName: string) => {
|
|
map[pageName] = true;
|
|
});
|
|
Object.keys(dataTree).forEach((treeItem: string) => {
|
|
map[treeItem] = true;
|
|
});
|
|
const libAccessors = ([] as string[]).concat(
|
|
...installedLibraries.map((lib) => lib.accessor),
|
|
);
|
|
|
|
for (const accessor of libAccessors) {
|
|
map[accessor] = true;
|
|
}
|
|
}
|
|
|
|
return map;
|
|
},
|
|
);
|
|
|
|
export const getSavingStatusForActionName = createSelector(
|
|
getIsSavingForApiName,
|
|
getErrorForApiName,
|
|
(isSaving: boolean, error: boolean) => ({
|
|
isSaving,
|
|
error,
|
|
}),
|
|
);
|
|
|
|
export const getSavingStatusForJSObjectName = createSelector(
|
|
getIsSavingForJSObjectName,
|
|
getErrorForJSObjectName,
|
|
(isSaving: boolean, error: boolean) => ({
|
|
isSaving,
|
|
error,
|
|
}),
|
|
);
|