PromucFlow_constructor/app/client/src/components/propertyControls/IconSelectControl.test.tsx
Aswath K 3824435f7d
chore: Adds analytics for Property Pane keyboard navigation (#13703)
* Adds analytics for DropdownControl

* Add isUpdatedViaKeyboard to WIDGET_PROPERTY_UPDATE

* fix: jest test for iconselectorcontrol

* refactor: Interaction analytics event dispatching moved to a hook

* refactor: event collection logic to HOC

* Analytics for SwitchControl

* Analytics for CodeEditor

* Analytics for InputTextControl

* Analytics for ColorPicker

* fix issue with ColorPicker

* refactor to re-use ref

* rename the hook to ts

* Analytics for StepControl

* Analytics for ButtonTabComponent

* Analytics for NumericInputControl

* Analytics for IconSelector

* fix: failed test

* Analytics for ActionSelector

* fix: failed jest test

* fix: jest test for StepControl

* Analytics for Option Control

* Analytics for LocationSearchControl

* Adds Analytics for Tab key

* analytics for Property pane connections

* Add analytics for widget name

* Adds analytics for copy & delete button

* fix issue with widget name analytics

* add useCallback for tab keydown handler for button

* Create separate Event handling for design system

* removes unused imports

* changes ADS_EVENT to DS_EVENT

* Changes AdsEventTypes to DSEventTypes

* Changes AdsEventDetail to DSEventDetail

* changes occurences of Ads to DS

* avoids creation of intermediate function

* removes trace of 'analytics' from DS components

* rename dispatchDSEvent to emitDSEvent

* fix: Cypress selector
2022-07-14 10:30:30 +05:30

268 lines
8.4 KiB
TypeScript

import React from "react";
import "@testing-library/jest-dom";
import {
render,
screen,
waitFor,
waitForElementToBeRemoved,
} from "@testing-library/react";
import IconSelectControl from "./IconSelectControl";
import userEvent from "@testing-library/user-event";
import { noop } from "lodash";
import { EditorTheme } from "components/editorComponents/CodeEditor/EditorConfig";
const requiredParams = {
evaluatedValue: undefined,
deleteProperties: noop,
widgetProperties: undefined,
parentPropertyName: "",
parentPropertyValue: undefined,
additionalDynamicData: {},
label: "",
openNextPanel: noop,
onPropertyChange: noop,
theme: EditorTheme.LIGHT,
propertyName: "iconName",
controlType: "",
isBindProperty: false,
isTriggerProperty: false,
};
describe("<IconSelectControl /> - Keyboard navigation", () => {
const getTestComponent = (
onPropertyChange: (
propertyName: string,
propertyValue: string,
isUpdatedViaKeyboard?: boolean,
) => void = noop,
) => (
<IconSelectControl
{...requiredParams}
onPropertyChange={onPropertyChange}
/>
);
it("Pressing tab should focus the component", () => {
render(getTestComponent());
userEvent.tab();
expect(screen.getByRole("button")).toHaveFocus();
});
it.each(["{Enter}", " ", "{ArrowDown}", "{ArrowUp}"])(
"Pressing '%s' should open the icon selector",
async (key) => {
render(getTestComponent());
userEvent.tab();
expect(screen.queryByRole("list")).toBeNull();
userEvent.keyboard(key);
expect(screen.queryByRole("list")).toBeInTheDocument();
// Makes sure search bar is having focus
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
},
);
it("Pressing '{Escape}' should close the icon selector", async () => {
render(getTestComponent());
userEvent.tab();
expect(screen.queryByRole("list")).toBeNull();
userEvent.keyboard("{Enter}");
expect(screen.queryByRole("list")).toBeInTheDocument();
userEvent.keyboard("{Escape}");
await waitForElementToBeRemoved(screen.getAllByRole("list"));
});
it("Pressing '{ArrowDown}' while search is in focus should remove the focus", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
expect(screen.queryByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
userEvent.keyboard("{ArrowDown}");
expect(screen.queryByRole("textbox")).not.toHaveFocus();
});
it("Pressing '{Shift} + {ArrowUp}' while search is not in focus should focus search box", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
expect(screen.queryByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
userEvent.keyboard("{ArrowDown}");
expect(screen.queryByRole("textbox")).not.toHaveFocus();
userEvent.keyboard("{Shift}{ArrowUp}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
});
/*
Icon Arrangement
(none) add add-column-left add-column-right
add-row-bottom add-row-top add-to-artifact add-to-folder
airplane align-center align-justify align-left
*/
it("Pressing '{ArrowDown}' should navigate the icon selection downwards", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-(none)",
);
// used to shift the focus from search
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowDown}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add-row-bottom",
);
});
it("Pressing '{ArrowUp}' should navigate the icon selection upwards", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-(none)",
);
// used to shift the focus from search
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowDown}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-align-right",
);
userEvent.keyboard("{ArrowUp}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-airplane",
);
});
it("Pressing '{ArrowRight}' should navigate the icon selection towards right", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-(none)",
);
// used to shift the focus from search
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowRight}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add",
);
});
it("Pressing '{ArrowLeft}' should navigate the icon selection towards left", async () => {
render(getTestComponent());
userEvent.tab();
userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-(none)",
);
// used to shift the focus from search
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowRight}");
userEvent.keyboard("{ArrowRight}");
userEvent.keyboard("{ArrowRight}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add-column-right",
);
userEvent.keyboard("{ArrowLeft}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add-column-left",
);
});
it("Pressing '{Enter}' or ' ' should select the icon", async () => {
const handleOnSelect = jest.fn();
render(getTestComponent(handleOnSelect));
userEvent.tab();
expect(screen.queryByRole("button")?.textContent).toEqual(
"(none)caret-down",
);
userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-(none)",
);
// used to shift the focus from search
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowRight}");
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add-row-top",
);
userEvent.keyboard(" ");
expect(handleOnSelect).toHaveBeenCalledTimes(1);
expect(handleOnSelect).toHaveBeenLastCalledWith(
"iconName",
"add-row-top",
true,
);
await waitForElementToBeRemoved(screen.getByRole("list"));
userEvent.keyboard("{Enter}");
expect(screen.queryByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.queryByRole("textbox")).toHaveFocus();
});
expect(document.querySelector("a.bp3-active")?.children[0]).toHaveClass(
"bp3-icon-add-row-top",
);
userEvent.keyboard("{ArrowDown}");
userEvent.keyboard("{ArrowRight}");
userEvent.keyboard(" ");
expect(handleOnSelect).toHaveBeenCalledTimes(2);
expect(handleOnSelect).toHaveBeenLastCalledWith(
"iconName",
"add-to-artifact",
true,
);
});
});
const config = { ...requiredParams };
describe("IconSelectControl.canDisplayValue", () => {
it("Should return true when a proper icon name is passed", () => {
expect(IconSelectControl.canDisplayValueInUI(config, "add")).toEqual(true);
expect(IconSelectControl.canDisplayValueInUI(config, "airplane")).toEqual(
true,
);
});
it("Should return false when a non-alowed icon value is passed", () => {
expect(IconSelectControl.canDisplayValueInUI(config, "macbook")).toEqual(
false,
);
});
});