## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
101 lines
2.8 KiB
TypeScript
101 lines
2.8 KiB
TypeScript
import type { OffsetType, PositionType } from "./walkthroughContext";
|
|
|
|
const DEFAULT_POSITION: PositionType = "top";
|
|
|
|
export const PADDING_HIGHLIGHT = 10;
|
|
|
|
interface PositionCalculator {
|
|
offset?: OffsetType;
|
|
targetId: string;
|
|
}
|
|
|
|
export function getPosition({ offset, targetId }: PositionCalculator) {
|
|
const target = document.querySelector(targetId);
|
|
const bodyCoordinates = document.body.getBoundingClientRect();
|
|
|
|
if (!target) return null;
|
|
|
|
let coordinates;
|
|
|
|
if (target) {
|
|
coordinates = target.getBoundingClientRect();
|
|
}
|
|
|
|
if (!coordinates) return null;
|
|
|
|
const offsetValues = { top: offset?.top || 0, left: offset?.left || 0 };
|
|
const extraStyles = offset?.style || {};
|
|
|
|
/**
|
|
* . - - - - - - - - - - - - - - - - - .
|
|
* | Body |
|
|
* | |
|
|
* | . - - - - - - - - - - . |
|
|
* | | Offset | |
|
|
* | | . - - - - - - - . | |
|
|
* | | | / / / / / / / | | |
|
|
* | | | / / /Target/ /| | |
|
|
* | | | / / / / / / / | | |
|
|
* | | . - - - - - - - . | |
|
|
* | | | |
|
|
* | . _ _ _ _ _ _ _ _ _ _ . |
|
|
* | |
|
|
* . - - - - - - - - - - - - - - - - - .
|
|
*/
|
|
|
|
switch (offset?.position || DEFAULT_POSITION) {
|
|
case "top":
|
|
return {
|
|
bottom:
|
|
bodyCoordinates.height -
|
|
coordinates.top -
|
|
offsetValues.top +
|
|
PADDING_HIGHLIGHT +
|
|
"px",
|
|
left: coordinates.left + offsetValues.left + PADDING_HIGHLIGHT + "px",
|
|
transform: "translateX(-50%)",
|
|
...extraStyles,
|
|
};
|
|
case "bottom":
|
|
return {
|
|
top:
|
|
coordinates.height +
|
|
coordinates.top +
|
|
offsetValues.top +
|
|
PADDING_HIGHLIGHT +
|
|
"px",
|
|
left: coordinates.left + offsetValues.left - PADDING_HIGHLIGHT + "px",
|
|
transform: "translateX(-50%)",
|
|
...extraStyles,
|
|
};
|
|
case "left":
|
|
return {
|
|
top: coordinates.top + offsetValues.top - PADDING_HIGHLIGHT + "px",
|
|
right:
|
|
bodyCoordinates.width -
|
|
coordinates.left -
|
|
offsetValues.left +
|
|
PADDING_HIGHLIGHT +
|
|
"px",
|
|
transform: "translateY(-50%)",
|
|
...extraStyles,
|
|
};
|
|
case "right":
|
|
return {
|
|
top: coordinates.top + offsetValues.top - PADDING_HIGHLIGHT + "px",
|
|
left:
|
|
coordinates.left +
|
|
coordinates.width +
|
|
offsetValues.left +
|
|
PADDING_HIGHLIGHT +
|
|
"px",
|
|
transform: "translateY(-50%)",
|
|
...extraStyles,
|
|
};
|
|
}
|
|
}
|
|
|
|
export function isElementVisible(el: HTMLElement) {
|
|
return !!(el?.offsetWidth || el?.offsetHeight || el.getClientRects().length);
|
|
}
|