## Description When the application is in published mode, this Pr offers the ability to disable the error toast. Only the toasts that the user initiated are displayed; all others are disabled and messages are logged in the console. When the view mode url has `debug=true` as one of the query params, then all the error toasts are visible. #### PR fixes following issue(s) Fixes #23605 Fixes #23603 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [x] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
177 lines
5.6 KiB
TypeScript
177 lines
5.6 KiB
TypeScript
import type { EventType } from "constants/AppsmithActionConstants/ActionConstants";
|
|
import type { TriggerMeta } from "@appsmith/sagas/ActionExecution/ActionExecutionSagas";
|
|
import { call, put, spawn, take } from "redux-saga/effects";
|
|
import { logActionExecutionError } from "sagas/ActionExecution/errorUtils";
|
|
import { setUserCurrentGeoLocation } from "actions/browserRequestActions";
|
|
import type { Channel } from "redux-saga";
|
|
import { channel } from "redux-saga";
|
|
import { evalWorker } from "sagas/EvaluationsSaga";
|
|
import type {
|
|
TGetGeoLocationDescription,
|
|
TWatchGeoLocationDescription,
|
|
} from "workers/Evaluation/fns/geolocationFns";
|
|
|
|
class GeoLocationError extends Error {
|
|
constructor(message: string, private responseData?: any) {
|
|
super(message);
|
|
}
|
|
}
|
|
|
|
let successChannel: Channel<GeolocationPosition> | null = null;
|
|
let errorChannel: Channel<GeolocationPositionError> | null = null;
|
|
|
|
// Making the getCurrentPosition call in a promise fashion
|
|
export const getUserLocation = (options?: PositionOptions) =>
|
|
new Promise((resolve, reject) => {
|
|
navigator.geolocation.getCurrentPosition(
|
|
(location) => resolve(location),
|
|
(error) => reject(error),
|
|
options,
|
|
);
|
|
});
|
|
|
|
/**
|
|
* We need to extract and set certain properties only because the
|
|
* return value is a "class" with functions as well and
|
|
* that cant be stored in the data tree
|
|
**/
|
|
export const extractGeoLocation = (
|
|
location: GeolocationPosition,
|
|
): GeolocationPosition => {
|
|
const {
|
|
coords: {
|
|
accuracy,
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
speed,
|
|
},
|
|
} = location;
|
|
const coords: GeolocationCoordinates = {
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
accuracy,
|
|
speed,
|
|
};
|
|
return {
|
|
coords,
|
|
timestamp: location.timestamp,
|
|
};
|
|
};
|
|
|
|
/**
|
|
* When location access is turned off in the browser, the error is a GeolocationPositionError instance
|
|
* We can't pass this instance to the worker thread as it uses structured cloning for copying the objects
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
|
|
* It doesn't support some entities like DOM Nodes, functions etc. for copying
|
|
* And will throw an error if we try to pass it
|
|
* GeolocationPositionError instance doesn't exist in worker thread hence not supported by structured cloning
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/GeolocationPositionError
|
|
* Hence we're creating a new object with same structure which can be passed to the worker thread
|
|
*/
|
|
function sanitizeGeolocationError(error: GeolocationPositionError) {
|
|
return {
|
|
code: error.code,
|
|
message: error.message,
|
|
};
|
|
}
|
|
|
|
function* successCallbackHandler(listenerId?: string) {
|
|
let payload: GeolocationPosition;
|
|
if (!successChannel) return;
|
|
while ((payload = yield take(successChannel))) {
|
|
const currentLocation = extractGeoLocation(payload);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
if (listenerId)
|
|
yield call(evalWorker.ping, { data: currentLocation }, listenerId);
|
|
}
|
|
}
|
|
|
|
function* errorCallbackHandler(triggerMeta: TriggerMeta, listenerId?: string) {
|
|
if (!errorChannel) return;
|
|
let error: GeolocationPositionError;
|
|
while ((error = yield take(errorChannel))) {
|
|
if (listenerId)
|
|
yield call(
|
|
evalWorker.ping,
|
|
{ error: sanitizeGeolocationError(error) },
|
|
listenerId,
|
|
);
|
|
yield call(logActionExecutionError, error.message, true);
|
|
}
|
|
}
|
|
|
|
export function* getCurrentLocationSaga(action: TGetGeoLocationDescription) {
|
|
const { payload: actionPayload } = action;
|
|
try {
|
|
const location: GeolocationPosition = yield call(
|
|
getUserLocation,
|
|
actionPayload.options,
|
|
);
|
|
const currentLocation = extractGeoLocation(location);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
return currentLocation;
|
|
} catch (error) {
|
|
yield call(logActionExecutionError, (error as Error).message, true);
|
|
if (error instanceof GeolocationPositionError) {
|
|
const sanitizedError = sanitizeGeolocationError(error);
|
|
throw new GeoLocationError(sanitizedError.message, [sanitizedError]);
|
|
}
|
|
}
|
|
}
|
|
|
|
let watchId: number | undefined;
|
|
export function* watchCurrentLocation(
|
|
action: TWatchGeoLocationDescription,
|
|
_: EventType,
|
|
triggerMeta: TriggerMeta,
|
|
) {
|
|
const { payload: actionPayload } = action;
|
|
if (watchId) {
|
|
// When a watch is already active, we will not start a new watch.
|
|
// at a given point in time, only one watch is active
|
|
yield call(
|
|
logActionExecutionError,
|
|
"A watchLocation is already active. Clear it before before starting a new one",
|
|
true,
|
|
);
|
|
|
|
return;
|
|
}
|
|
successChannel = channel<GeolocationPosition>();
|
|
errorChannel = channel<GeolocationPositionError>();
|
|
yield spawn(successCallbackHandler, actionPayload.listenerId);
|
|
yield spawn(errorCallbackHandler, triggerMeta, actionPayload.listenerId);
|
|
watchId = navigator.geolocation.watchPosition(
|
|
(location) => {
|
|
successChannel?.put(location);
|
|
},
|
|
(error) => {
|
|
// When location is turned off, the watch fails but watchId is generated
|
|
// Resetting the watchId to undefined so that a new watch can be started
|
|
if (watchId) {
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
}
|
|
errorChannel?.put(error);
|
|
},
|
|
actionPayload.options,
|
|
);
|
|
}
|
|
|
|
export function* stopWatchCurrentLocation() {
|
|
if (watchId === undefined) {
|
|
yield call(logActionExecutionError, "No location watch active", true);
|
|
return;
|
|
}
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
successChannel?.close();
|
|
errorChannel?.close();
|
|
}
|