PromucFlow_constructor/app/client/cypress/integration/Regression_TestSuite/ClientSideTests
sneha122 43e7a00db0
fix: filepicker not showing in firefox issue fixed (#21257)
## Description

This PR fixes issue of file picker not showing up in firefox, The issue
occurred because the function being triggered on script load
`gapiLoaded`, was defined in a script that would load after `gapi`. Even
though `gapi` is being loaded asynchronously, in case of firefox when
using with windows OS, it would load before the script which had onload
function defined. This PR fixes the issue by defining onload function in
a script that loads before `gapi`

> Add a TL;DR when description is extra long (helps content team)

Fixes #21033 
> if no issue exists, please create an issue and ask the maintainers
about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2023-03-15 16:33:14 +05:30
..
ActionExecution test: Flaky test fix (#21120) 2023-03-05 08:52:42 +05:30
AdminSettings test: Cypress tests - Grouping logical it blocks - Part 1 (#20305) 2023-02-25 00:35:19 +05:30
AuditLogs test: Cypress tests - Grouping logical it blocks - Part 1 (#20305) 2023-02-25 00:35:19 +05:30
Autocomplete test: Cypress - mock api url update + Flaky fixes (#20754) 2023-03-11 12:31:39 +05:30
Binding fix: filepicker not showing in firefox issue fixed (#21257) 2023-03-15 16:33:14 +05:30
Branding test: Cypress tests - Grouping logical it blocks - Part 1 (#20305) 2023-02-25 00:35:19 +05:30
BugTests fix: Add default value for hasChanges meta property in Form Widget (#21337) 2023-03-13 07:39:34 +01:00
CodeComment test: Cypress tests - Grouping logical it blocks - Part 1 (#20305) 2023-02-25 00:35:19 +05:30
DynamicHeight feat: Auto layout appsmith editor and mobile responsiveness (#21151) 2023-03-04 12:55:54 +05:30
EmbedSettings test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
ExplorerTests test: Flaky test fix (#21120) 2023-03-05 08:52:42 +05:30
FormLogin test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
FormNativeToRawTests test: Flaky test fix (#21120) 2023-03-05 08:52:42 +05:30
GenerateCRUD test: Cypress tests - Grouping logical it blocks - Part 1 (#20305) 2023-02-25 00:35:19 +05:30
Git fix: filepicker not showing in firefox issue fixed (#21257) 2023-03-15 16:33:14 +05:30
Github test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
Google test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
IDE feat: URL Navigation for Widgets (#20202) 2023-02-21 19:08:16 +05:30
JSLibrary fix: JSPDF output API crash (#20544) 2023-02-10 13:13:22 +05:30
Linting test: Fix flaky tests + Add clean up for git repos (#20319) 2023-02-06 13:07:01 +05:30
Onboarding chore: fix Onboarding/CreateNewApp flaky test (#21347) 2023-03-15 07:50:26 +05:30
OtherUIFeatures test: Cypress - mock api url update + Flaky fixes (#20754) 2023-03-11 12:31:39 +05:30
PeekOverlay test: Cypress - mock api url update + Flaky fixes (#20754) 2023-03-11 12:31:39 +05:30
PropertyPane test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
Refactoring test: Cypress - mock api url update + Flaky fixes (#20754) 2023-03-11 12:31:39 +05:30
SettingsPane test: Flaky test fix (#21120) 2023-03-05 08:52:42 +05:30
Templates test: Fix flaky git cypress tests (#21282) 2023-03-09 19:30:22 +05:30
ThemingTests feat: Auto layout appsmith editor and mobile responsiveness (#21151) 2023-03-04 12:55:54 +05:30
VisualTests feat: URL Navigation for Widgets (#20202) 2023-02-21 19:08:16 +05:30
Widgets fix: filepicker not showing in firefox issue fixed (#21257) 2023-03-15 16:33:14 +05:30
Workspace fix: filepicker not showing in firefox issue fixed (#21257) 2023-03-15 16:33:14 +05:30