Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
6a26602086
PromucFlow_constructor/app/client/cypress/e2e/Regression/ClientSide
History
Rishabh Rathod 6a26602086
fix: deprecate JS object confirm before calling (#32527) 
## Description

We deprecate confirm before calling for JSObjects
- For new JSObject, confirm before calling option won't be visible
- For already present JSObject, only for function where confirm before
calling was enabled will be visible and once turned off will not be
visible anymore.

Fixes https://github.com/appsmithorg/appsmith/issues/29248

## Test scenarios

- For an application where JSObject confirmed before calling was
enabled, it should work same.
- For new JSObject, confirm before calling option shouldn't be visible. 
- Once user disable confirm before calling it should not be visible
anymore.
- Deprecation warning on info.

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8654538946>
> Commit: 6ac458bdec864a2963fa5eb59b5912607ddfa3a7
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8654538946&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
2024-04-12 12:18:14 +05:30
..
ActionExecution fix: appsmith.URL.queryParams update on same page navigation (#32382) 2024-04-09 16:01:17 +05:30
AdminSettings chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Anvil chore: RMVF based changes for DnD, Modals, and Space distribution. (#31980) 2024-04-05 11:16:07 +05:30
AppNavigation test: Cypress | Flaky fixes + Replacing static waits (#30067) 2024-01-12 12:00:12 +05:30
AuditLogs chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Autocomplete fix: commands title changed to command for each datasource query editor forms (#32526) 2024-04-10 17:05:01 +05:30
Binding feat: New IDE Top Navbar (#31594) 2024-03-12 14:02:58 +05:30
Branding chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
BugTests fix: deprecate JS object confirm before calling (#32527) 2024-04-12 12:18:14 +05:30
CodeComment test: Cypress - added tag - @tag.AutoHeight, @tag.IDE (#29670) 2023-12-18 12:45:44 +05:30
CommunityTemplate test: Cypress - added @tag.excludeForAirgap, @tag.Templates tags (#29790) 2023-12-27 16:50:36 +05:30
Debugger chore: removed config logs from debugger (#32049) 2024-03-26 14:10:22 +05:30
DynamicHeight test: Cypress | Text_With_Different_Size_spec.ts re-write + Flaky fixes (#30445) 2024-02-08 16:55:58 +05:30
Editor test: Cypress - separated exclude airgap cases and tagged them (#30588) 2024-01-24 16:47:58 +05:30
EmbedSettings test: Cypress | Added Dynamic checks for Flaky fix + Cypress upgrade (#30840) 2024-02-02 16:01:59 +05:30
ExplorerTests chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Fork fix: commands title changed to command for each datasource query editor forms (#32526) 2024-04-10 17:05:01 +05:30
FormLogin chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
FormNativeToRawTests fix: commands title changed to command for each datasource query editor forms (#32526) 2024-04-10 17:05:01 +05:30
Git chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled (#31384) 2024-03-15 11:13:14 +05:30
Github test: Cypress - separated exclude airgap cases and tagged them (#30588) 2024-01-24 16:47:58 +05:30
Google chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
Homepage feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
IDE fix: On delete of last item, redirect user to blank screen (#32418) 2024-04-05 17:56:17 +05:30
JSLibrary feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
JSObject feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
Linting feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
MobileResponsiveTests feat: Move conversion flow under feature flag. (#32490) 2024-04-11 17:21:14 +05:30
Onboarding chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled (#31384) 2024-03-15 11:13:14 +05:30
OneClickBinding chore: create action source instrumentation added (#31585) 2024-03-11 10:22:24 +05:30
OtherUIFeatures chore: removed config logs from debugger (#32049) 2024-03-26 14:10:22 +05:30
PartialImportExport test: Cypress | Text_With_Different_Size_spec.ts re-write + Flaky fixes (#30445) 2024-02-08 16:55:58 +05:30
PeekOverlay feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
Performance feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
ProductRamps feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
PropertyPane test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 2023-12-18 17:18:23 +05:30
PublishedApps test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 2023-12-18 17:18:23 +05:30
Refactoring feat: enabled editor pane sidebar (#29882) 2024-01-12 20:13:58 +05:30
SetProperty fix: reverting back the context changes (#30899) 2024-02-05 22:03:53 +05:30
SettingsPane test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 2023-12-18 17:18:23 +05:30
Templates fix: widget card filter (#32420) 2024-04-09 10:38:01 +01:00
ThemingTests chore: Remove "Save theme" functionality (#31481) 2024-03-12 18:54:39 +05:30
UserProfile feat: Homepage experience v2 changes (#29282) 2024-01-25 19:11:48 +05:30
VisualTests fix: broken line in page settings (#30951) 2024-02-12 13:12:19 +05:30
Widgets chore: autoFocus widget search input on load (#32002) 2024-04-03 13:21:53 +05:30
Workspace chore: Removing partner program callout from invite modal (#31576) 2024-03-07 13:20:51 +05:30