## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
239 lines
7.3 KiB
TypeScript
239 lines
7.3 KiB
TypeScript
import type {
|
|
PropertyPaneConfig,
|
|
PropertyPaneControlConfig,
|
|
PropertyPaneSectionConfig,
|
|
ValidationConfig,
|
|
} from "constants/PropertyControlConstants";
|
|
import { ValidationTypes } from "constants/WidgetValidation";
|
|
import { isFunction } from "lodash";
|
|
import widgets from "widgets";
|
|
import WidgetFactory from "WidgetProvider/factory";
|
|
import { registerWidgets } from "WidgetProvider/factory/registrationHelper";
|
|
|
|
function validatePropertyPaneConfig(
|
|
config: PropertyPaneConfig[],
|
|
isWidgetHidden: boolean,
|
|
) {
|
|
for (const sectionOrControlConfig of config) {
|
|
const sectionConfig = sectionOrControlConfig as PropertyPaneSectionConfig;
|
|
|
|
if (sectionConfig.sectionName && isFunction(sectionConfig.sectionName)) {
|
|
return ` SectionName should be a string and not a function. Search won't work for functions at the moment`;
|
|
}
|
|
|
|
if (sectionOrControlConfig.children) {
|
|
for (const propertyControlConfig of sectionOrControlConfig.children) {
|
|
const propertyControlValidation = validatePropertyControl(
|
|
propertyControlConfig,
|
|
isWidgetHidden,
|
|
);
|
|
|
|
if (propertyControlValidation !== true)
|
|
return propertyControlValidation;
|
|
}
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
function validatePropertyControl(
|
|
config: PropertyPaneConfig,
|
|
isWidgetHidden: boolean,
|
|
): boolean | string {
|
|
const _config = config as PropertyPaneControlConfig;
|
|
const controls = ["INPUT_TEXT"];
|
|
|
|
if (_config.label && isFunction(_config.label)) {
|
|
return `${_config.propertyName}: Label should be a string and not a function. Search won't work for functions at the moment`;
|
|
}
|
|
|
|
if (
|
|
(_config.isJSConvertible || controls.includes(_config.controlType)) &&
|
|
!_config.isTriggerProperty
|
|
) {
|
|
if (!_config.isBindProperty)
|
|
return `${
|
|
_config.propertyName
|
|
}: isBindProperty should be true if isJSConvertible is true or when control type is [${controls.join(
|
|
" | ",
|
|
)}]`;
|
|
|
|
if (!_config.validation)
|
|
return `${
|
|
_config.propertyName
|
|
}: validation should be defined if isJSConvertible is true or when control type is [${controls.join(
|
|
" | ",
|
|
)}]`;
|
|
}
|
|
|
|
if (controls.includes(_config.controlType) && _config.isJSConvertible) {
|
|
return `${
|
|
_config.propertyName
|
|
}: No need of setting isJSConvertible since users can write JS inside [${controls.join(
|
|
" | ",
|
|
)}]`;
|
|
}
|
|
|
|
if (_config.validation !== undefined) {
|
|
const res = validateValidationStructure(_config.validation);
|
|
|
|
if (res !== true) return `${_config.propertyName}: ${res}`;
|
|
}
|
|
|
|
if (_config.children) {
|
|
for (const child of _config.children) {
|
|
const res = validatePropertyControl(child, isWidgetHidden);
|
|
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
}
|
|
|
|
if (_config.panelConfig) {
|
|
if (_config.panelConfig.children) {
|
|
const res = validatePropertyPaneConfig(
|
|
_config.panelConfig.children,
|
|
isWidgetHidden,
|
|
);
|
|
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
|
|
if (_config.panelConfig.contentChildren) {
|
|
const res = validatePropertyPaneConfig(
|
|
_config.panelConfig.contentChildren,
|
|
isWidgetHidden,
|
|
);
|
|
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
|
|
if (_config.panelConfig.styleChildren) {
|
|
const res = validatePropertyPaneConfig(
|
|
_config.panelConfig.styleChildren,
|
|
isWidgetHidden,
|
|
);
|
|
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
function validateValidationStructure(
|
|
config: ValidationConfig,
|
|
): boolean | string {
|
|
if (
|
|
config.type === ValidationTypes.FUNCTION &&
|
|
config.params &&
|
|
config.params.fn
|
|
) {
|
|
if (!config.params.expected)
|
|
return `For a ${ValidationTypes.FUNCTION} type validation, expected type and example are mandatory`;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const isNotFloat = (n: any) => {
|
|
return Number(n) === n && n % 1 === 0;
|
|
};
|
|
|
|
describe("Tests all widget's propertyPane config", () => {
|
|
beforeAll(() => {
|
|
registerWidgets(widgets);
|
|
});
|
|
|
|
widgets
|
|
// Exclude WDS widgets from the tests, since they work differently
|
|
.filter((widget) => !widget.type.includes("WDS"))
|
|
.forEach((widget) => {
|
|
const config = widget.getConfig();
|
|
|
|
it(`Checks ${widget.type}'s propertyPaneConfig`, () => {
|
|
const propertyPaneConfig = widget.getPropertyPaneConfig();
|
|
|
|
expect(
|
|
validatePropertyPaneConfig(propertyPaneConfig, !!config.hideCard),
|
|
).toStrictEqual(true);
|
|
const propertyPaneContentConfig = widget.getPropertyPaneContentConfig();
|
|
|
|
expect(
|
|
validatePropertyPaneConfig(
|
|
propertyPaneContentConfig,
|
|
!!config.isDeprecated,
|
|
),
|
|
).toStrictEqual(true);
|
|
const propertyPaneStyleConfig = widget.getPropertyPaneStyleConfig();
|
|
|
|
expect(
|
|
validatePropertyPaneConfig(
|
|
propertyPaneStyleConfig,
|
|
!!config.isDeprecated,
|
|
),
|
|
).toStrictEqual(true);
|
|
});
|
|
it(`Check if ${widget.type}'s dimensions are always integers`, () => {
|
|
const defaults = widget.getDefaults();
|
|
|
|
expect(isNotFloat(defaults.rows)).toBe(true);
|
|
expect(isNotFloat(defaults.columns)).toBe(true);
|
|
});
|
|
|
|
if (config.isDeprecated) {
|
|
it(`Check if ${widget.type}'s deprecation config has a proper replacement Widget`, () => {
|
|
const widgetType = widget.type;
|
|
|
|
if (config.replacement === undefined) {
|
|
fail(`${widgetType}'s replacement widget is not defined`);
|
|
}
|
|
|
|
const replacementWidgetType = config.replacement;
|
|
const replacementWidget = WidgetFactory.get(replacementWidgetType);
|
|
const replacementWidgetConfig = replacementWidget?.getConfig();
|
|
|
|
if (replacementWidgetConfig === undefined) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} does not resolve to an actual widget Config`,
|
|
);
|
|
}
|
|
|
|
if (replacementWidgetConfig?.isDeprecated) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} itself is deprecated. Cannot have a deprecated widget as a replacement for another deprecated widget`,
|
|
);
|
|
}
|
|
|
|
if (replacementWidgetConfig?.hideCard) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} should be available in the entity Explorer`,
|
|
);
|
|
}
|
|
});
|
|
}
|
|
|
|
it(`Check if ${widget.type}'s setter method are configured correctly`, () => {
|
|
const setterConfig = widget.getSetterConfig();
|
|
|
|
if (setterConfig) {
|
|
expect(setterConfig).toHaveProperty("__setters");
|
|
const setters = setterConfig.__setters;
|
|
|
|
for (const [setterName, config] of Object.entries(setters)) {
|
|
expect(config).toHaveProperty("type");
|
|
expect(config).toHaveProperty("path");
|
|
expect(setterName).toContain("set");
|
|
const type = config.type;
|
|
const path = config.path;
|
|
|
|
expect(typeof type).toBe("string");
|
|
expect(typeof path).toBe("string");
|
|
}
|
|
}
|
|
});
|
|
});
|
|
});
|