PromucFlow_constructor/app/client
Ayush Pahwa 62d05cdba1
chore: remove feature flag for ramps (#26448)
## Description
PR to show ramps to everyone on CE, removing feature flag.

#### PR fixes following issue(s)
Fixes #26443

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
1. Give a non appsmith user Administrator rights -
[adminuser1@app.in](mailto:adminuser1@app.in) - administrator - able to
login with this user and see ramps for canvas/preview/deploy modes, on
Edit DS page and on Queries page
2. [devuser1@app.in](mailto:devuser1@app.in) - developer - able to login
with this user and see ramps for canvas/preview/deploy modes, on Edit DS
page and on Queries page
3. [viewuser1@app.in](mailto:viewuser1@app.in) - appviewer - able to
login with this user - and only launch the app - where no ramps are
visible and no switch env dropdown
4. Make application public - no ramps should be visible - and no switch
dropdown should be present
5. Gave above permissions to appsmith user as well and tried if same
behavior. Works fine.
6. Detailed cases - https://github.com/appsmithorg/TestSmith/issues/2489
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-09-05 15:23:44 +07:00
..
.husky fix: pre-commit logic (#25324) 2023-07-12 12:37:05 +03:00
.yarn chore:update node version to v18 (#26358) 2023-08-15 18:56:04 +05:30
cypress chore: remove feature flag for ramps (#26448) 2023-09-05 15:23:44 +07:00
docker/templates chore: Remove unused NGINX templates (#26426) 2023-08-17 19:54:58 +05:30
generators
packages chore: unit test for bgAccentActive (#26916) 2023-09-04 17:58:25 +03:00
perf
public fix: googleapi script loading for import apps (#26708) 2023-08-29 20:27:23 +01:00
src chore: remove feature flag for ramps (#26448) 2023-09-05 15:23:44 +07:00
test chore: Add SAVE_ACTION analytics event (#25997) 2023-08-07 15:01:45 +05:30
typings
.babelrc
.dockerignore
.editorconfig
.eslintrc.base.json chore: improve eslint rules (#26056) 2023-08-07 15:38:48 +03:00
.eslintrc.js chore: improve eslint rules (#26056) 2023-08-07 15:38:48 +03:00
.gitignore test: Cypress | (DI) Arango added validations + CI Stabilize (#26243) 2023-08-18 10:48:35 +05:30
.lintstagedrc
.nvmrc chore:update node version to v18 (#26358) 2023-08-15 18:56:04 +05:30
.prettierignore
.prettierrc
.sentryclirc
.yarnrc.yml chore:update node version to v18 (#26358) 2023-08-15 18:56:04 +05:30
build.sh chore: disable cra eslint (#24953) 2023-06-30 12:45:07 +03:00
craco.build.config.js perf: prioritize the main bundle over preloads (v2) (#24374) 2023-06-22 10:58:10 +05:30
craco.common.config.js perf: merge all icons into three major chunks (#24382) 2023-06-16 11:38:08 +05:30
craco.dev.config.js
cypress_ci_custom.config.ts chore: airtable spec skip (#26895) 2023-09-04 10:57:15 +05:30
cypress_ci_hosted.config.ts test: Downgrade Cypress to v12.17.4 to capture the screenshot & video for reporting (#26802) 2023-08-30 19:25:50 +05:30
cypress_ci-toremove.json test: Cypress | CI Stabilize (Skipped tests fixes) + Cypress upgrade to v13.0.0 (#26583) 2023-08-30 16:24:37 +05:30
cypress_ci.config.ts test: Downgrade Cypress to v12.17.4 to capture the screenshot & video for reporting (#26802) 2023-08-30 19:25:50 +05:30
cypress.config.ts test: Downgrade Cypress to v12.17.4 to capture the screenshot & video for reporting (#26802) 2023-08-30 19:25:50 +05:30
download-assets.js
jest.config.js chore: Add button v2 under feature flag (#25106) 2023-07-26 18:10:44 +05:30
package.json test: Downgrade Cypress to v12.17.4 to capture the screenshot & video for reporting (#26802) 2023-08-30 19:25:50 +05:30
README.md
README.old.md
start-https.sh chore: Detect other NGINX and offer to kill (#25478) 2023-07-19 16:39:11 +05:30
tailwind.config.js feat: in-app ramps for private embed feature (#24507) 2023-06-21 13:39:14 +05:30
tsconfig.json fix: bump storybook version and move stories to storybook package (#25821) 2023-07-31 19:15:50 +03:00
tsconfig.path.json
vercel.json
yarn.lock chore: WDS color docs (#26754) 2023-09-01 11:31:17 +03:00

Appsmith Client

This project was bootstrapped with Create React App.

For details on setting up your development machine, please refer to the Setup Guide