## Description ### Fixes - [x] https://github.com/appsmithorg/appsmith/issues/19383 - [x] https://github.com/appsmithorg/appsmith/issues/19384 - [x] https://github.com/appsmithorg/appsmith/issues/19385 - [x] https://github.com/appsmithorg/appsmith/issues/19386 - [x] https://github.com/appsmithorg/appsmith/issues/19387 - [x] https://github.com/appsmithorg/appsmith/issues/19388 - [x] https://github.com/appsmithorg/appsmith/issues/19389 - [x] https://github.com/appsmithorg/appsmith/issues/19390 - [x] https://github.com/appsmithorg/appsmith/issues/19391 - [x] https://github.com/appsmithorg/appsmith/issues/19392 - [x] https://github.com/appsmithorg/appsmith/issues/19393 - [x] https://github.com/appsmithorg/appsmith/issues/19394 - [x] https://github.com/appsmithorg/appsmith/issues/19395 - [x] https://github.com/appsmithorg/appsmith/issues/19396 - [x] https://github.com/appsmithorg/appsmith/issues/19397 - [x] https://github.com/appsmithorg/appsmith/issues/19398 - [x] https://github.com/appsmithorg/appsmith/issues/19399 - [x] https://github.com/appsmithorg/appsmith/issues/19400 - [x] https://github.com/appsmithorg/appsmith/issues/19401 - [x] https://github.com/appsmithorg/appsmith/issues/19402 - [x] https://github.com/appsmithorg/appsmith/issues/19403 - [x] https://github.com/appsmithorg/appsmith/issues/19404 - [x] https://github.com/appsmithorg/appsmith/issues/19405 - [x] https://github.com/appsmithorg/appsmith/issues/19406 - [x] https://github.com/appsmithorg/appsmith/issues/19407 - [x] https://github.com/appsmithorg/appsmith/issues/19408 - [x] https://github.com/appsmithorg/appsmith/issues/19409 Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com> Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com> Co-authored-by: Aman Agarwal <aman@appsmith.com> Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in> Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com> Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local> Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com> Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com> Co-authored-by: Apple <nandan@thinkify.io> Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com> Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com> Co-authored-by: rahulramesha <rahul@appsmith.com> Co-authored-by: Aswath K <aswath.sana@gmail.com> Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com> Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
177 lines
5.5 KiB
TypeScript
177 lines
5.5 KiB
TypeScript
import type { EventType } from "constants/AppsmithActionConstants/ActionConstants";
|
|
import type { TriggerMeta } from "@appsmith/sagas/ActionExecution/ActionExecutionSagas";
|
|
import { call, put, spawn, take } from "redux-saga/effects";
|
|
import { logActionExecutionError } from "sagas/ActionExecution/errorUtils";
|
|
import { setUserCurrentGeoLocation } from "actions/browserRequestActions";
|
|
import type { Channel } from "redux-saga";
|
|
import { channel } from "redux-saga";
|
|
import { evalWorker } from "sagas/EvaluationsSaga";
|
|
import type {
|
|
TGetGeoLocationDescription,
|
|
TWatchGeoLocationDescription,
|
|
} from "workers/Evaluation/fns/geolocationFns";
|
|
|
|
class GeoLocationError extends Error {
|
|
constructor(message: string, private responseData?: any) {
|
|
super(message);
|
|
}
|
|
}
|
|
|
|
let successChannel: Channel<GeolocationPosition> | null = null;
|
|
let errorChannel: Channel<GeolocationPositionError> | null = null;
|
|
|
|
// Making the getCurrentPosition call in a promise fashion
|
|
export const getUserLocation = (options?: PositionOptions) =>
|
|
new Promise((resolve, reject) => {
|
|
navigator.geolocation.getCurrentPosition(
|
|
(location) => resolve(location),
|
|
(error) => reject(error),
|
|
options,
|
|
);
|
|
});
|
|
|
|
/**
|
|
* We need to extract and set certain properties only because the
|
|
* return value is a "class" with functions as well and
|
|
* that cant be stored in the data tree
|
|
**/
|
|
export const extractGeoLocation = (
|
|
location: GeolocationPosition,
|
|
): GeolocationPosition => {
|
|
const {
|
|
coords: {
|
|
accuracy,
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
speed,
|
|
},
|
|
} = location;
|
|
const coords: GeolocationCoordinates = {
|
|
altitude,
|
|
altitudeAccuracy,
|
|
heading,
|
|
latitude,
|
|
longitude,
|
|
accuracy,
|
|
speed,
|
|
};
|
|
return {
|
|
coords,
|
|
timestamp: location.timestamp,
|
|
};
|
|
};
|
|
|
|
/**
|
|
* When location access is turned off in the browser, the error is a GeolocationPositionError instance
|
|
* We can't pass this instance to the worker thread as it uses structured cloning for copying the objects
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
|
|
* It doesn't support some entities like DOM Nodes, functions etc. for copying
|
|
* And will throw an error if we try to pass it
|
|
* GeolocationPositionError instance doesn't exist in worker thread hence not supported by structured cloning
|
|
* https://developer.mozilla.org/en-US/docs/Web/API/GeolocationPositionError
|
|
* Hence we're creating a new object with same structure which can be passed to the worker thread
|
|
*/
|
|
function sanitizeGeolocationError(error: GeolocationPositionError) {
|
|
const { code, message } = error;
|
|
return {
|
|
code,
|
|
message,
|
|
};
|
|
}
|
|
|
|
function* successCallbackHandler(listenerId?: string) {
|
|
let payload: GeolocationPosition;
|
|
if (!successChannel) return;
|
|
while ((payload = yield take(successChannel))) {
|
|
const currentLocation = extractGeoLocation(payload);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
if (listenerId)
|
|
yield call(evalWorker.ping, { data: currentLocation }, listenerId);
|
|
}
|
|
}
|
|
|
|
function* errorCallbackHandler(triggerMeta: TriggerMeta, listenerId?: string) {
|
|
if (!errorChannel) return;
|
|
let error: GeolocationPositionError;
|
|
while ((error = yield take(errorChannel))) {
|
|
if (listenerId)
|
|
yield call(
|
|
evalWorker.ping,
|
|
{ error: sanitizeGeolocationError(error) },
|
|
listenerId,
|
|
);
|
|
logActionExecutionError(error.message, true);
|
|
}
|
|
}
|
|
|
|
export function* getCurrentLocationSaga(action: TGetGeoLocationDescription) {
|
|
const { payload: actionPayload } = action;
|
|
try {
|
|
const location: GeolocationPosition = yield call(
|
|
getUserLocation,
|
|
actionPayload.options,
|
|
);
|
|
const currentLocation = extractGeoLocation(location);
|
|
yield put(setUserCurrentGeoLocation(currentLocation));
|
|
return currentLocation;
|
|
} catch (error) {
|
|
logActionExecutionError((error as Error).message, true);
|
|
if (error instanceof GeolocationPositionError) {
|
|
const sanitizedError = sanitizeGeolocationError(error);
|
|
throw new GeoLocationError(sanitizedError.message, [sanitizedError]);
|
|
}
|
|
}
|
|
}
|
|
|
|
let watchId: number | undefined;
|
|
export function* watchCurrentLocation(
|
|
action: TWatchGeoLocationDescription,
|
|
_: EventType,
|
|
triggerMeta: TriggerMeta,
|
|
) {
|
|
const { payload: actionPayload } = action;
|
|
if (watchId) {
|
|
// When a watch is already active, we will not start a new watch.
|
|
// at a given point in time, only one watch is active
|
|
logActionExecutionError(
|
|
"A watchLocation is already active. Clear it before before starting a new one",
|
|
true,
|
|
);
|
|
|
|
return;
|
|
}
|
|
successChannel = channel<GeolocationPosition>();
|
|
errorChannel = channel<GeolocationPositionError>();
|
|
yield spawn(successCallbackHandler, actionPayload.listenerId);
|
|
yield spawn(errorCallbackHandler, triggerMeta, actionPayload.listenerId);
|
|
watchId = navigator.geolocation.watchPosition(
|
|
(location) => {
|
|
successChannel?.put(location);
|
|
},
|
|
(error) => {
|
|
// When location is turned off, the watch fails but watchId is generated
|
|
// Resetting the watchId to undefined so that a new watch can be started
|
|
if (watchId) {
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
}
|
|
errorChannel?.put(error);
|
|
},
|
|
actionPayload.options,
|
|
);
|
|
}
|
|
|
|
export function* stopWatchCurrentLocation() {
|
|
if (watchId === undefined) {
|
|
logActionExecutionError("No location watch active", true);
|
|
return;
|
|
}
|
|
navigator.geolocation.clearWatch(watchId);
|
|
watchId = undefined;
|
|
successChannel?.close();
|
|
errorChannel?.close();
|
|
}
|