## Description ### Fixes - [x] https://github.com/appsmithorg/appsmith/issues/19383 - [x] https://github.com/appsmithorg/appsmith/issues/19384 - [x] https://github.com/appsmithorg/appsmith/issues/19385 - [x] https://github.com/appsmithorg/appsmith/issues/19386 - [x] https://github.com/appsmithorg/appsmith/issues/19387 - [x] https://github.com/appsmithorg/appsmith/issues/19388 - [x] https://github.com/appsmithorg/appsmith/issues/19389 - [x] https://github.com/appsmithorg/appsmith/issues/19390 - [x] https://github.com/appsmithorg/appsmith/issues/19391 - [x] https://github.com/appsmithorg/appsmith/issues/19392 - [x] https://github.com/appsmithorg/appsmith/issues/19393 - [x] https://github.com/appsmithorg/appsmith/issues/19394 - [x] https://github.com/appsmithorg/appsmith/issues/19395 - [x] https://github.com/appsmithorg/appsmith/issues/19396 - [x] https://github.com/appsmithorg/appsmith/issues/19397 - [x] https://github.com/appsmithorg/appsmith/issues/19398 - [x] https://github.com/appsmithorg/appsmith/issues/19399 - [x] https://github.com/appsmithorg/appsmith/issues/19400 - [x] https://github.com/appsmithorg/appsmith/issues/19401 - [x] https://github.com/appsmithorg/appsmith/issues/19402 - [x] https://github.com/appsmithorg/appsmith/issues/19403 - [x] https://github.com/appsmithorg/appsmith/issues/19404 - [x] https://github.com/appsmithorg/appsmith/issues/19405 - [x] https://github.com/appsmithorg/appsmith/issues/19406 - [x] https://github.com/appsmithorg/appsmith/issues/19407 - [x] https://github.com/appsmithorg/appsmith/issues/19408 - [x] https://github.com/appsmithorg/appsmith/issues/19409 Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com> Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com> Co-authored-by: Aman Agarwal <aman@appsmith.com> Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in> Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com> Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local> Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com> Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com> Co-authored-by: Apple <nandan@thinkify.io> Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com> Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com> Co-authored-by: rahulramesha <rahul@appsmith.com> Co-authored-by: Aswath K <aswath.sana@gmail.com> Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com> Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
152 lines
4.3 KiB
TypeScript
152 lines
4.3 KiB
TypeScript
import {
|
|
createMessage,
|
|
TRIGGER_ACTION_VALIDATION_ERROR,
|
|
} from "@appsmith/constants/messages";
|
|
import type { ApiResponse } from "api/ApiResponses";
|
|
import { isString } from "lodash";
|
|
import type { Types } from "utils/TypeHelpers";
|
|
import type { ActionTriggerKeys } from "@appsmith/workers/Evaluation/fns/index";
|
|
import { getActionTriggerFunctionNames } from "@appsmith/workers/Evaluation/fns/index";
|
|
import { getAppsmithConfigs } from "@appsmith/configs";
|
|
import { toast } from "design-system";
|
|
import { getAppMode } from "@appsmith/selectors/applicationSelectors";
|
|
import AnalyticsUtil from "../../utils/AnalyticsUtil";
|
|
import {
|
|
setDebuggerSelectedTab,
|
|
showDebugger,
|
|
} from "../../actions/debuggerActions";
|
|
import { DEBUGGER_TAB_KEYS } from "../../components/editorComponents/Debugger/helpers";
|
|
import store from "store";
|
|
|
|
const APPSMITH_CONFIGS = getAppsmithConfigs();
|
|
|
|
/*
|
|
* The base trigger error that also logs the errors in the debugger.
|
|
* Extend this error to make custom handling of errors
|
|
*/
|
|
export class TriggerFailureError extends Error {
|
|
error?: Error;
|
|
|
|
constructor(reason: string, error?: Error) {
|
|
super(reason);
|
|
this.error = error;
|
|
}
|
|
}
|
|
|
|
export class PluginTriggerFailureError extends TriggerFailureError {
|
|
responseData: unknown[] = [];
|
|
|
|
constructor(reason: string, responseData: unknown[]) {
|
|
super(reason);
|
|
this.responseData = responseData;
|
|
}
|
|
}
|
|
|
|
export class ActionValidationError extends TriggerFailureError {
|
|
constructor(
|
|
functionName: ActionTriggerKeys,
|
|
argumentName: string,
|
|
expectedType: Types,
|
|
received: Types,
|
|
) {
|
|
const errorMessage = createMessage(
|
|
TRIGGER_ACTION_VALIDATION_ERROR,
|
|
getActionTriggerFunctionNames(!!APPSMITH_CONFIGS.cloudHosting)[
|
|
functionName
|
|
],
|
|
argumentName,
|
|
expectedType,
|
|
received,
|
|
);
|
|
super(errorMessage);
|
|
}
|
|
}
|
|
|
|
export const logActionExecutionError = (
|
|
errorMessage: string,
|
|
isExecuteJSFunc = true,
|
|
) => {
|
|
//Commenting as per decision taken for the error hanlding epic to not show the trigger errors in the debugger.
|
|
// if (triggerPropertyName) {
|
|
// AppsmithConsole.addErrors([
|
|
// {
|
|
// payload: {
|
|
// id: `${source?.id}-${triggerPropertyName}`,
|
|
// logType: LOG_TYPE.TRIGGER_EVAL_ERROR,
|
|
// text: createMessage(DEBUGGER_TRIGGER_ERROR, triggerPropertyName),
|
|
// source: {
|
|
// type: ENTITY_TYPE.WIDGET,
|
|
// id: source?.id ?? "",
|
|
// name: source?.name ?? "",
|
|
// propertyPath: triggerPropertyName,
|
|
// },
|
|
// messages: [
|
|
// {
|
|
// type: errorType,
|
|
// message: { name: "TriggerExecutionError", message: errorMessage },
|
|
// },
|
|
// ],
|
|
// },
|
|
// },
|
|
// ]);
|
|
// }
|
|
|
|
function onDebugClick() {
|
|
const appMode = getAppMode(store.getState());
|
|
if (appMode === "PUBLISHED") return null;
|
|
|
|
AnalyticsUtil.logEvent("OPEN_DEBUGGER", {
|
|
source: "TOAST",
|
|
});
|
|
store.dispatch(showDebugger(true));
|
|
store.dispatch(setDebuggerSelectedTab(DEBUGGER_TAB_KEYS.ERROR_TAB));
|
|
}
|
|
|
|
isExecuteJSFunc &&
|
|
toast.show(errorMessage, {
|
|
kind: "error",
|
|
action: {
|
|
text: "debug",
|
|
effect: () => onDebugClick(),
|
|
className: "t--toast-debug-button",
|
|
},
|
|
});
|
|
};
|
|
|
|
/*
|
|
* Thrown when action execution fails for some reason
|
|
* */
|
|
export class PluginActionExecutionError extends Error {
|
|
response?: ApiResponse;
|
|
userCancelled: boolean;
|
|
|
|
constructor(message: string, userCancelled: boolean, response?: ApiResponse) {
|
|
super(message);
|
|
this.name = "PluginActionExecutionError";
|
|
this.userCancelled = userCancelled;
|
|
this.response = response;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* The user cancelled the run of this action in a confirmation modal.
|
|
* This modal is shown if an action has a confirmation setting enabled.
|
|
* If they cancel, bail, dont show errors and dont run anything further
|
|
*/
|
|
export class UserCancelledActionExecutionError extends PluginActionExecutionError {
|
|
constructor() {
|
|
super("User cancelled action execution", true);
|
|
this.name = "UserCancelledActionExecutionError";
|
|
}
|
|
}
|
|
|
|
export class UncaughtPromiseError extends Error {
|
|
constructor(message: string) {
|
|
super(message);
|
|
}
|
|
}
|
|
|
|
export const getErrorAsString = (error: unknown): string => {
|
|
return isString(error) ? error : JSON.stringify(error);
|
|
};
|