## Description This PR updates the error logs - Establishing a consistent format for all error messages. - Revising error titles and details for improved understanding. - Compiling internal documentation of all error categories, subcategories, and error descriptions. Updated Error Interface: https://www.notion.so/appsmith/Error-Interface-for-Plugin-Execution-Error-7b3f5323ba4c40bfad281ae717ccf79b PRD: https://www.notion.so/appsmith/PRD-Error-Handling-Framework-4ac9747057fd4105a9d52cb8b42f4452?pvs=4#008e9c79ff3c484abf0250a5416cf052 >TL;DR Fixes # Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan ### Issues raised during DP testing ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: subrata <subrata@appsmith.com>
123 lines
2.7 KiB
TypeScript
123 lines
2.7 KiB
TypeScript
import {
|
|
addErrorLogInit,
|
|
debuggerLog,
|
|
debuggerLogInit,
|
|
deleteErrorLogsInit,
|
|
} from "actions/debuggerActions";
|
|
import { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import {
|
|
Severity,
|
|
LogActionPayload,
|
|
Log,
|
|
LOG_CATEGORY,
|
|
} from "entities/AppsmithConsole";
|
|
import moment from "moment";
|
|
import store from "store";
|
|
import AnalyticsUtil from "./AnalyticsUtil";
|
|
import { isEmpty } from "lodash";
|
|
|
|
// * @param payload - payload of the error
|
|
// * @param severity - severity of the error
|
|
// * @param category - category of the error
|
|
export interface ErrorObject {
|
|
payload: LogActionPayload;
|
|
severity?: Severity;
|
|
category?: LOG_CATEGORY;
|
|
}
|
|
|
|
function dispatchAction(action: ReduxAction<unknown>) {
|
|
store.dispatch(action);
|
|
}
|
|
|
|
function log(ev: Log) {
|
|
if (ev.category === LOG_CATEGORY.USER_GENERATED) {
|
|
AnalyticsUtil.logEvent("CONSOLE_LOG_CREATED", {
|
|
entityName: ev.source?.name,
|
|
entityType: ev.source?.type,
|
|
});
|
|
}
|
|
dispatchAction(debuggerLogInit([ev]));
|
|
}
|
|
|
|
function getTimeStamp() {
|
|
return moment().format("HH:mm:ss");
|
|
}
|
|
|
|
function addLogs(logs: Log[]) {
|
|
dispatchAction(debuggerLog(logs));
|
|
}
|
|
|
|
function info(
|
|
ev: LogActionPayload,
|
|
timestamp = getTimeStamp(),
|
|
category = LOG_CATEGORY.PLATFORM_GENERATED,
|
|
) {
|
|
log({
|
|
...ev,
|
|
severity: Severity.INFO,
|
|
timestamp,
|
|
category,
|
|
occurrenceCount: 1,
|
|
});
|
|
}
|
|
|
|
function warning(
|
|
ev: LogActionPayload,
|
|
timestamp = getTimeStamp(),
|
|
category = LOG_CATEGORY.PLATFORM_GENERATED,
|
|
) {
|
|
log({
|
|
...ev,
|
|
severity: Severity.WARNING,
|
|
timestamp,
|
|
category,
|
|
occurrenceCount: 1,
|
|
});
|
|
}
|
|
|
|
// This is used to show a log as an error
|
|
// NOTE: These logs won't appear in the errors tab
|
|
// To add errors to the errors tab use the addError method.
|
|
function error(
|
|
ev: LogActionPayload,
|
|
timestamp = getTimeStamp(),
|
|
category = LOG_CATEGORY.PLATFORM_GENERATED,
|
|
) {
|
|
log({
|
|
...ev,
|
|
severity: Severity.ERROR,
|
|
timestamp,
|
|
category,
|
|
occurrenceCount: 1,
|
|
});
|
|
}
|
|
|
|
// Function used to add errors to the error tab of the debugger
|
|
function addErrors(errors: ErrorObject[]) {
|
|
if (isEmpty(errors)) return;
|
|
const refinedErrors = errors.map((error) => ({
|
|
...error.payload,
|
|
severity: error.severity ?? Severity.ERROR,
|
|
timestamp: getTimeStamp(),
|
|
occurrenceCount: 1,
|
|
category: error.category ?? LOG_CATEGORY.PLATFORM_GENERATED,
|
|
}));
|
|
|
|
dispatchAction(addErrorLogInit(refinedErrors));
|
|
}
|
|
|
|
// This is used to remove errors from the error tab of the debugger
|
|
function deleteErrors(errors: { id: string; analytics?: Log["analytics"] }[]) {
|
|
if (isEmpty(errors)) return;
|
|
dispatchAction(deleteErrorLogsInit(errors));
|
|
}
|
|
|
|
export default {
|
|
addLogs,
|
|
info,
|
|
warning,
|
|
error,
|
|
addErrors,
|
|
deleteErrors,
|
|
};
|