PromucFlow_constructor/app/client/src
Keyur Paralkar 614b3fe736
fix: retain columns on query change in deployed app (#24245)
## Description
This PR fixes the behaviour mentioned in the issue. 

This issue was happening due to table widget's column order wasn't
updating. It wasn't updating because we maintained column orders in
widget's DSL as well as in the meta property. Whenever the table data
changes, the widget updates `columnOrder` property in the DSL but this
gets overridden if you have the same property in the widget's meta
property.

To solve this we update the table widget's sticky and column order
property via `super.updateWidgetProperty`. We have also refactor the
hydration logic for sticky columns such that table widget's DSL acts as
a source of truth all the time.

Fixes #23969
#23827

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- To test that the column freeze functionality works as expected in edit
as well as deployed mode
- To check column freeze functionality works as expected when table
query changes
- To check if the column reordering is working as expected in view mode
- [ ] Jest
- [x] Cypress
- should test that the number of columns needs to be same when table
data changes in deployed app
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-27 10:45:41 +05:30
..
actions feat: signposting update (#24389) 2023-06-22 18:35:01 +05:30
api fix: rebase error message during conflicts (#24414) 2023-06-17 14:25:16 +05:30
assets fix: all backlog fixes for ads v2 (#24012) 2023-06-12 12:40:54 +07:00
ce chore: Add analytics for JSObject variable (#24740) 2023-06-23 16:12:27 +05:30
components fix: Debugger shortcut is line deletion shortcut on the editor (#24725) 2023-06-26 15:11:40 +05:30
constants feat: signposting update (#24389) 2023-06-22 18:35:01 +05:30
ee chore: Optimizing the solution for supporting tenant config on admin settings (#24454) 2023-06-14 19:39:38 +05:30
enterprise chore: Format files to match prettier rules and exclude third-party files (#21586) 2023-03-20 19:04:31 +05:30
entities fix: puts navbar functionality behind feature flag (#24561) 2023-06-22 10:30:24 +05:30
globalStyles fix: Remove custom rendering of sql hints (#24080) 2023-06-08 15:15:16 +01:00
icons feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
mockComponentProps
mockResponses ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
mocks
navigation feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
pages fix: added business tag for private embed ramp (#24826) 2023-06-26 15:13:09 +05:30
polyfills chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
reducers feat: Shared Package for DSL based operations (#23894) 2023-06-26 12:25:55 +05:30
reflow fix: Add null check to fix sentry error in widget reflow (#24214) 2023-06-08 17:37:04 +05:30
resizable fix: casing changes (#23515) 2023-06-09 14:22:27 +05:30
sagas feat: Shared Package for DSL based operations (#23894) 2023-06-26 12:25:55 +05:30
selectors feat: Shared Package for DSL based operations (#23894) 2023-06-26 12:25:55 +05:30
templates
theme chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
transformers feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
usagePulse chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
utils feat: Shared Package for DSL based operations (#23894) 2023-06-26 12:25:55 +05:30
WidgetQueryGenerators chore: [one click binding] gsheets query adaptor (#23390) 2023-06-12 14:12:59 +05:30
widgets fix: retain columns on query change in deployed app (#24245) 2023-06-27 10:45:41 +05:30
workers chore: Add analytics for JSObject variable (#24740) 2023-06-23 16:12:27 +05:30
App.css
AppErrorBoundry.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
config.d.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Globals.d.ts feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
index.css fix: design-system-old fixes (#24421) 2023-06-20 14:34:13 +05:30
index.tsx perf: prioritize the main bundle over preloads (v2) (#24374) 2023-06-22 10:58:10 +05:30
LandingScreen.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
preload-route-chunks.ts perf: prioritize the main bundle over preloads (v2) (#24374) 2023-06-22 10:58:10 +05:30
react-app-env.d.ts
RouteBuilder.test.ts fix: Encode query params in URLs (#22594) 2023-05-03 09:00:27 +05:30
RouteBuilder.ts fix: Encode query params in URLs (#22594) 2023-05-03 09:00:27 +05:30
RouteChangeListener.tsx chore: Add new navigation scenarios for route change event (#21682) 2023-03-30 11:03:29 +05:30
RouteParamsMiddleware.ts feat: deprecate duplicate button (#23461) 2023-05-24 10:34:52 +05:30
serviceWorker.js fix: don’t cache icons by the service worker (#23558) 2023-05-24 12:50:26 +05:30
store.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
wdyr.ts