PromucFlow_constructor/app/client/cypress/e2e/Regression/ClientSide/Widgets
Keyur Paralkar 614b3fe736
fix: retain columns on query change in deployed app (#24245)
## Description
This PR fixes the behaviour mentioned in the issue. 

This issue was happening due to table widget's column order wasn't
updating. It wasn't updating because we maintained column orders in
widget's DSL as well as in the meta property. Whenever the table data
changes, the widget updates `columnOrder` property in the DSL but this
gets overridden if you have the same property in the widget's meta
property.

To solve this we update the table widget's sticky and column order
property via `super.updateWidgetProperty`. We have also refactor the
hydration logic for sticky columns such that table widget's DSL acts as
a source of truth all the time.

Fixes #23969
#23827

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- To test that the column freeze functionality works as expected in edit
as well as deployed mode
- To check column freeze functionality works as expected when table
query changes
- To check if the column reordering is working as expected in view mode
- [ ] Jest
- [x] Cypress
- should test that the number of columns needs to be same when table
data changes in deployed app
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-27 10:45:41 +05:30
..
Audio test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Button test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Chart test: Cypress | Moving Non-TED containers within Tests (#24709) 2023-06-21 23:07:21 +05:30
Checkbox test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
CodeScanner test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
CurrencyInput test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Datepicker test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
DocumentViewer test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Dropdown test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Filepicker chore: Use cypress interceptors instead of wait to fix file csv flaky test (#24364) 2023-06-20 20:07:30 +05:30
Form test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Iframe test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Image test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Input test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
JSONForm test: Cypress - Split Long Cypress Specs (#24682) 2023-06-21 12:50:11 +05:30
List test: Cypress - Split Long Cypress Specs (#24682) 2023-06-21 12:50:11 +05:30
ListV2 test: Cypress - Flaky Fix (#24738) 2023-06-22 20:30:46 +05:30
Modal test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Multiselect test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Others test: Cypress | Flaky fixes (#24508) 2023-06-17 00:10:10 +05:30
PhoneInput test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Radio test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
RTE test: Cypress - Split Long Cypress Specs (#24682) 2023-06-21 12:50:11 +05:30
Select test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Sliders test: Cypress - Flaky Fix (#24738) 2023-06-22 20:30:46 +05:30
Switch test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Tab test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
TableV1 test: Cypress - Flaky Fix (#24738) 2023-06-22 20:30:46 +05:30
TableV2 fix: retain columns on query change in deployed app (#24245) 2023-06-27 10:45:41 +05:30
Text test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Container_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
deprecatedWidgets_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Disabled_Widgets_drag_validation_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Migration_Spec.js test: Cypress | Flaky fixes (#24508) 2023-06-17 00:10:10 +05:30
Modal_background_spec.ts test: Cypress | Folder structure correction (#23568) 2023-05-21 02:01:50 +05:30
Modal_On_Table_Filter_Pane_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Tab_reset_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
WidgetCanvas_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
WidgetCopyPaste_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
WidgetGrouping_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
Widgets_Labels_spec.js test: Cypress | Folder structure correction (#23568) 2023-05-21 02:01:50 +05:30
WidgetSelection_spec.js test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30