## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
196 lines
6.4 KiB
TypeScript
196 lines
6.4 KiB
TypeScript
import type { ErrorActionPayload } from "sagas/ErrorSagas";
|
|
import type { ActionResponse } from "api/ActionAPI";
|
|
import { PluginType } from "entities/Action";
|
|
import queryActionSettingsConfig from "constants/AppsmithActionConstants/formConfig/QuerySettingsConfig";
|
|
import apiActionSettingsConfig from "constants/AppsmithActionConstants/formConfig/ApiSettingsConfig";
|
|
import apiActionEditorConfig from "constants/AppsmithActionConstants/formConfig/ApiEditorConfigs";
|
|
import saasActionSettingsConfig from "constants/AppsmithActionConstants/formConfig/GoogleSheetsSettingsConfig";
|
|
import apiActionDependencyConfig from "constants/AppsmithActionConstants/formConfig/ApiDependencyConfigs";
|
|
import apiActionDatasourceFormButtonConfig from "constants/AppsmithActionConstants/formConfig/ApiDatasourceFormsButtonConfig";
|
|
import type { ENTITY_TYPE } from "entities/DataTree/types";
|
|
|
|
export type ExecuteActionPayloadEvent = {
|
|
type: EventType;
|
|
callback?: (result: ExecutionResult) => void;
|
|
};
|
|
|
|
export type ExecutionResult = {
|
|
success: boolean;
|
|
};
|
|
|
|
export type TriggerSource = {
|
|
id: string;
|
|
name: string;
|
|
entityType?: ENTITY_TYPE;
|
|
collectionId?: string;
|
|
isJSAction?: boolean;
|
|
actionId?: string;
|
|
};
|
|
|
|
export type ExecuteTriggerPayload = {
|
|
dynamicString: string;
|
|
event: ExecuteActionPayloadEvent;
|
|
callbackData?: Array<any>;
|
|
triggerPropertyName?: string;
|
|
source?: TriggerSource;
|
|
widgetId?: string;
|
|
globalContext?: Record<string, unknown>;
|
|
};
|
|
|
|
export type ContentType =
|
|
| "application/json"
|
|
| "application/x-www-form-urlencoded";
|
|
|
|
export interface APIHeaders {
|
|
"Content-Type": ContentType;
|
|
Accept?: string;
|
|
}
|
|
|
|
export interface APIRequest {
|
|
requestId?: string;
|
|
}
|
|
|
|
export enum EventType {
|
|
ON_RESET = "ON_RESET",
|
|
ON_PAGE_LOAD = "ON_PAGE_LOAD",
|
|
ON_PREV_PAGE = "ON_PREV_PAGE",
|
|
ON_NEXT_PAGE = "ON_NEXT_PAGE",
|
|
ON_PAGE_SIZE_CHANGE = "ON_PAGE_SIZE_CHANGE",
|
|
ON_ERROR = "ON_ERROR",
|
|
ON_SUCCESS = "ON_SUCCESS",
|
|
ON_ROW_SELECTED = "ON_ROW_SELECTED",
|
|
ON_SEARCH = "ON_SEARCH",
|
|
ON_CLICK = "ON_CLICK",
|
|
ON_DATA_POINT_CLICK = "ON_DATA_POINT_CLICK",
|
|
ON_FILES_SELECTED = "ON_FILES_SELECTED",
|
|
ON_HOVER = "ON_HOVER",
|
|
ON_TOGGLE = "ON_TOGGLE",
|
|
ON_LOAD = "ON_LOAD",
|
|
ON_MODAL_CLOSE = "ON_MODAL_CLOSE",
|
|
ON_TEXT_CHANGE = "ON_TEXT_CHANGE",
|
|
ON_SUBMIT = "ON_SUBMIT",
|
|
ON_CHECK_CHANGE = "ON_CHECK_CHANGE",
|
|
ON_SWITCH_CHANGE = "ON_SWITCH_CHANGE",
|
|
ON_SELECT = "ON_SELECT",
|
|
ON_DATE_SELECTED = "ON_DATE_SELECTED",
|
|
ON_DATE_RANGE_SELECTED = "ON_DATE_RANGE_SELECTED",
|
|
ON_DROPDOWN_OPEN = "ON_DROPDOWN_OPEN",
|
|
ON_DROPDOWN_CLOSE = "ON_DROPDOWN_CLOSE",
|
|
ON_OPTION_CHANGE = "ON_OPTION_CHANGE",
|
|
ON_FILTER_CHANGE = "ON_FILTER_CHANGE",
|
|
ON_FILTER_UPDATE = "ON_FILTER_UPDATE",
|
|
ON_MARKER_CLICK = "ON_MARKER_CLICK",
|
|
ON_CREATE_MARKER = "ON_CREATE_MARKER",
|
|
ON_TAB_CHANGE = "ON_TAB_CHANGE",
|
|
ON_VIDEO_START = "ON_VIDEO_START",
|
|
ON_VIDEO_END = "ON_VIDEO_END",
|
|
ON_VIDEO_PLAY = "ON_VIDEO_PLAY",
|
|
ON_VIDEO_PAUSE = "ON_VIDEO_PAUSE",
|
|
ON_AUDIO_START = "ON_AUDIO_START",
|
|
ON_AUDIO_END = "ON_AUDIO_END",
|
|
ON_AUDIO_PLAY = "ON_AUDIO_PLAY",
|
|
ON_AUDIO_PAUSE = "ON_AUDIO_PAUSE",
|
|
ON_RATE_CHANGED = "ON_RATE_CHANGED",
|
|
ON_IFRAME_URL_CHANGED = "ON_IFRAME_URL_CHANGED",
|
|
ON_IFRAME_SRC_DOC_CHANGED = "ON_IFRAME_SRC_DOC_CHANGED",
|
|
ON_IFRAME_MESSAGE_RECEIVED = "ON_IFRAME_MESSAGE_RECEIVED",
|
|
ON_SNIPPET_EXECUTE = "ON_SNIPPET_EXECUTE",
|
|
ON_SORT = "ON_SORT",
|
|
ON_CHECKBOX_GROUP_SELECTION_CHANGE = "ON_CHECKBOX_GROUP_SELECTION_CHANGE",
|
|
ON_LIST_PAGE_CHANGE = "ON_LIST_PAGE_CHANGE",
|
|
ON_RECORDING_START = "ON_RECORDING_START",
|
|
ON_RECORDING_COMPLETE = "ON_RECORDING_COMPLETE",
|
|
ON_SWITCH_GROUP_SELECTION_CHANGE = "ON_SWITCH_GROUP_SELECTION_CHANGE",
|
|
ON_JS_FUNCTION_EXECUTE = "ON_JS_FUNCTION_EXECUTE",
|
|
ON_CAMERA_IMAGE_CAPTURE = "ON_CAMERA_IMAGE_CAPTURE",
|
|
ON_CAMERA_IMAGE_SAVE = "ON_CAMERA_IMAGE_SAVE",
|
|
ON_CAMERA_VIDEO_RECORDING_START = "ON_CAMERA_VIDEO_RECORDING_START",
|
|
ON_CAMERA_VIDEO_RECORDING_STOP = "ON_CAMERA_VIDEO_RECORDING_STOP",
|
|
ON_CAMERA_VIDEO_RECORDING_SAVE = "ON_CAMERA_VIDEO_RECORDING_SAVE",
|
|
ON_ENTER_KEY_PRESS = "ON_ENTER_KEY_PRESS",
|
|
ON_BLUR = "ON_BLUR",
|
|
ON_FOCUS = "ON_FOCUS",
|
|
ON_BULK_SAVE = "ON_BULK_SAVE",
|
|
ON_BULK_DISCARD = "ON_BULK_DISCARD",
|
|
ON_ROW_SAVE = "ON_ROW_SAVE",
|
|
ON_ROW_DISCARD = "ON_ROW_DISCARD",
|
|
ON_CODE_DETECTED = "ON_CODE_DETECTED",
|
|
ON_ADD_NEW_ROW_SAVE = "ON_ADD_NEW_ROW_SAVE",
|
|
ON_ADD_NEW_ROW_DISCARD = "ON_ADD_NEW_ROW_DISCARD",
|
|
}
|
|
|
|
export interface PageAction {
|
|
id: string;
|
|
pluginType: PluginType;
|
|
name: string;
|
|
jsonPathKeys: string[];
|
|
timeoutInMillisecond: number;
|
|
clientSideExecution?: boolean;
|
|
collectionId?: string;
|
|
}
|
|
|
|
export interface ExecuteErrorPayload extends ErrorActionPayload {
|
|
actionId: string;
|
|
isPageLoad?: boolean;
|
|
data: ActionResponse;
|
|
}
|
|
|
|
export interface LayoutOnLoadActionErrors {
|
|
errorType: string;
|
|
code: number;
|
|
message: string;
|
|
}
|
|
|
|
// Group 1 = datasource (https://www.domain.com)
|
|
// Group 2 = path (/nested/path)
|
|
// Group 3 = params (?param=123¶m2=12)
|
|
export const urlGroupsRegexExp =
|
|
/^(https?:\/{2}\S+?)(\/[\s\S]*?)?(\?(?![^{]*})[\s\S]*)?$/;
|
|
|
|
export const EXECUTION_PARAM_KEY = "executionParams";
|
|
export const EXECUTION_PARAM_REFERENCE_REGEX = /this.params|this\?.params/g;
|
|
export const THIS_DOT_PARAMS_KEY = "params";
|
|
|
|
export const RESP_HEADER_DATATYPE = "X-APPSMITH-DATATYPE";
|
|
export const API_REQUEST_HEADERS: APIHeaders = {
|
|
"Content-Type": "application/json",
|
|
};
|
|
export const POSTMAN = "POSTMAN";
|
|
export const CURL = "CURL";
|
|
export const Swagger = "Swagger";
|
|
|
|
export const defaultActionSettings: Record<PluginType, any> = {
|
|
[PluginType.API]: apiActionSettingsConfig,
|
|
[PluginType.DB]: queryActionSettingsConfig,
|
|
[PluginType.SAAS]: saasActionSettingsConfig,
|
|
[PluginType.REMOTE]: saasActionSettingsConfig,
|
|
[PluginType.JS]: [],
|
|
};
|
|
|
|
export const defaultActionEditorConfigs: Record<PluginType, any> = {
|
|
[PluginType.API]: apiActionEditorConfig,
|
|
[PluginType.DB]: [],
|
|
[PluginType.SAAS]: [],
|
|
[PluginType.REMOTE]: [],
|
|
[PluginType.JS]: [],
|
|
};
|
|
|
|
export const defaultActionDependenciesConfig: Record<
|
|
PluginType,
|
|
Record<string, string[]>
|
|
> = {
|
|
[PluginType.API]: apiActionDependencyConfig,
|
|
[PluginType.DB]: {},
|
|
[PluginType.SAAS]: {},
|
|
[PluginType.REMOTE]: {},
|
|
[PluginType.JS]: {},
|
|
};
|
|
|
|
export const defaultDatasourceFormButtonConfig: Record<PluginType, string[]> = {
|
|
[PluginType.API]: apiActionDatasourceFormButtonConfig.API,
|
|
[PluginType.DB]: apiActionDatasourceFormButtonConfig.DB,
|
|
[PluginType.SAAS]: apiActionDatasourceFormButtonConfig.SAAS,
|
|
[PluginType.REMOTE]: apiActionDatasourceFormButtonConfig.REMOTE,
|
|
[PluginType.JS]: [],
|
|
};
|