> Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this PR we are fixing the page flicker issue while switching between pages. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the editor canvas interface for enhanced performance. - Simplified rendering of components by removing unnecessary props and adjusting corresponding test cases. - Removed redundant attributes from the `<Canvas>` component for improved component usage without affecting logic or control flow. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
23 lines
804 B
TypeScript
23 lines
804 B
TypeScript
import { APP_MODE } from "entities/App";
|
|
import AppViewerPageContainer from "pages/AppViewer/AppViewerPageContainer";
|
|
import Canvas from "pages/Editor/Canvas";
|
|
import IDE from "pages/Editor/IDE";
|
|
import React from "react";
|
|
import { useSelector } from "react-redux";
|
|
import { getCanvasWidgetsStructure } from "@appsmith/selectors/entitiesSelector";
|
|
import { useMockDsl } from "./testCommon";
|
|
|
|
export function MockCanvas() {
|
|
const canvasWidgetsStructure = useSelector(getCanvasWidgetsStructure);
|
|
return <Canvas canvasWidth={0} widgetsStructure={canvasWidgetsStructure} />;
|
|
}
|
|
|
|
export function UpdateAppViewer({ dsl }: any) {
|
|
useMockDsl(dsl, APP_MODE.PUBLISHED);
|
|
return <AppViewerPageContainer />;
|
|
}
|
|
export function UpdatedEditor({ dsl }: any) {
|
|
useMockDsl(dsl, APP_MODE.EDIT);
|
|
return <IDE />;
|
|
}
|