Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
5d571b9185
PromucFlow_constructor/app/server
History
sneha122 b7b5770a08
fix: google sheets query getting executed even after changing sheet (#37006) 
## Description

This PR fixes the issue with google sheets -> selected sheets option.
Following are the steps to reproduce the issue on cloud/release
platform:

**Steps:**
1. Create a Google sheets datasource with selected sheets option
2. Select "spreadsheet1" from the file picker.
3. Create a query for this datasource and attach it to table widget
4. Now edit the datasource and change authorisation from "spreadsheet1"
to "spreadsheet2"
5. Refresh the page and check the table data

This issue has been fixed, where we check if the correct spreadsheetId
is present in authorisedSheetIds, if it's not throwing an exception so
we don't execute the query.


Fixes #36747   
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11473463879>
> Commit: e0f725a6246ff849c8666d5a34e6cf016111cf0f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11473463879&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 23 Oct 2024 05:43:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new error message for missing spreadsheet URLs to enhance
user guidance.
- Updated method for retrieving authorized sheet IDs to include
validation, improving error handling.

- **Bug Fixes**
- Enhanced error handling for cases where the spreadsheet URL is invalid
or missing.

- **Tests**
- Added new test cases to validate the updated functionality for
authorized sheet IDs, ensuring robust error handling and correct
returns.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-10-24 11:08:28 +05:30
..
.run
appsmith-git chore: Allow all file I/Os for git in parallel (#36872) 2024-10-21 17:45:12 +05:30
appsmith-interfaces chore: Add spans attributes for no of lines and action count (#37001) 2024-10-22 14:22:29 +05:30
appsmith-plugins fix: google sheets query getting executed even after changing sheet (#37006) 2024-10-24 11:08:28 +05:30
appsmith-server chore: Add spans attributes for no of lines and action count (#37001) 2024-10-22 14:22:29 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
scripts chore: Revert "chore: delete redundant files" (#35022) 2024-07-18 16:18:10 +05:30
.gitignore
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
Procfile
README.md
system.properties

README.md

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.