We were using the AppState incorrectly in our selectors. We should use `DefaultRootState` from react-redux. /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated state parameter types in numerous selectors and hooks across the application from a custom application state type to a standard Redux root state type, enhancing type consistency and maintainability without impacting functionality or user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14771101257> > Commit: 48aef24d9a54ee63d06943128f7545ba0d461172 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14771101257&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 01 May 2025 07:16:33 UTC <!-- end of auto-generated comment: Cypress test results -->
32 lines
1.1 KiB
TypeScript
32 lines
1.1 KiB
TypeScript
import type { DefaultRootState } from "react-redux";
|
|
import { getJSEntityItemUrl } from "ee/pages/AppIDE/layouts/routers/utils/getJSEntityItemUrl";
|
|
import type { FocusEntityInfo } from "navigation/FocusEntity";
|
|
import { identifyEntityFromPath } from "navigation/FocusEntity";
|
|
import { selectJSSegmentEditorTabs } from "ee/selectors/appIDESelectors";
|
|
import { getCurrentBasePageId } from "./editorSelectors";
|
|
|
|
export const getJSPaneConfigSelectedTab = (state: DefaultRootState) =>
|
|
state.ui.jsPane.selectedConfigTab;
|
|
|
|
export const getJsPaneDebuggerState = (state: DefaultRootState) =>
|
|
state.ui.jsPane.debugger;
|
|
|
|
export const getLastJSTab = (
|
|
state: DefaultRootState,
|
|
): FocusEntityInfo | undefined => {
|
|
const tabs = selectJSSegmentEditorTabs(state);
|
|
const basePageId = getCurrentBasePageId(state);
|
|
|
|
if (tabs.length) {
|
|
const url = getJSEntityItemUrl(tabs[tabs.length - 1], basePageId);
|
|
const urlWithoutQueryParams = url.split("?")[0];
|
|
|
|
return identifyEntityFromPath(urlWithoutQueryParams);
|
|
}
|
|
};
|
|
|
|
export const getIsJSCollectionSaving = (
|
|
state: DefaultRootState,
|
|
collectionId: string,
|
|
) => state.ui.jsPane.isSaving[collectionId];
|