PromucFlow_constructor/app/client/cypress
Shrikant Sharat Kandula 55b6e6d8d8
test: Extract pageId with regex to cover more cases (#34521)
There's a few places in Cypress tests that are trying to extract the
page ID using `.split`, especially with just the path information,
instead of the whole URL. So this PR changes the extraction
implementation to use a regex, to support all three cases we need:

1. Full absolute application+page URL.
2. Just the path of an application+page URL.
3. Just the path of an application with a custom slug.
4. Full absolute application with a custom slug. (Supported, but we
don't need this today).

We've also fixed the URL parsing for the (very) old application URLs
that didn't use slugs in the URL at all. This was making
`FocusEntity.test.ts` fail.

Fixed that test as well as improved it's error reporting.

Before this PR:

![shot-2024-06-27-05-02-16](https://github.com/appsmithorg/appsmith/assets/120119/f3363376-a74d-4f3e-8196-5e72a9e758de)


After this PR:

![shot-2024-06-27-05-03-15](https://github.com/appsmithorg/appsmith/assets/120119/8dc1be04-c60f-4251-acf0-e4fd962f4f00)

No conflicts to EE.

/test all

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9713573983>
> Commit: 49edbce5ae85ee7fe9f4d2df05e2933347ddb3f4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9713573983&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->












<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved URL handling by centralizing page ID extraction logic across
various tests and components.
- Updated deprecated path constants to include ID extraction patterns
for better consistency.
- Enhanced code readability and maintainability by moving page ID
extraction to a helper method.

- **Tests**
- Modified test cases to dynamically set `applicationId` and `pageId`
instead of hardcoding values, ensuring more flexible and maintainable
test scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-02 06:31:59 +05:30
..
e2e test: Extract pageId with regex to cover more cases (#34521) 2024-07-02 06:31:59 +05:30
fixtures test: Fix Anvil DSLs used for testing (#34569) 2024-06-28 11:14:51 +05:30
locators test: updated js methods to refer ts locators for Git Tests (#34577) 2024-06-28 16:34:07 +05:30
manual_TestSuite test: Cypress - added @tag.excludeForAirgap, @tag.Templates tags (#29790) 2023-12-27 16:50:36 +05:30
patches
plugins ci: Allow static split of cypress specs (#29653) 2023-12-18 17:10:11 +05:30
scripts chore: Update Postgres port for TED in CI (#34430) 2024-06-25 10:35:15 +05:30
snapshots chore: add snapshots for input type widgets (#34436) 2024-06-27 10:51:28 +05:30
support test: Extract pageId with regex to cover more cases (#34521) 2024-07-02 06:31:59 +05:30
.eslintrc.json
apply-patches.js
index.ts
init-mssql-dump-for-test.sql
init-mysql-dump-for-test.sql
init-pg-dump-for-test.sql
limited-tests.txt feat: constrained diff between states (#31847) 2024-03-27 14:37:46 +05:30
setup-test-ci.sh chore: Logs and potential fix for CI startup flakiness (#34461) 2024-06-25 14:03:56 +05:30
tags.js ci: To improve readability sorted tags in tags.js (#34452) 2024-06-25 05:47:34 +00:00
test.sh
tsconfig.json
xataadd.sh
xatadel.sh