65bded9fdb
## Description This PR adds JUnit test cases for snowflake Key auth pair feature added. Following cases have been added: - For basic authentication mechanism, when we do datasource create -> hikari config should have non empty username and password and datasource object inside hikari config should be null - For key pair authentication mechanism with valid private key -> hikari config should have datasource object which is of type SnowflakeBasicDatasource and username, password should be null. - For key pair authentication mechanism with invalid private key -> error should be thrown with appropriate error message - For key pair authentication mechanism with valid private key -> SnowflakeKeyUtils.readEncryptedPrivateKey should return valid instance of PrivateKey class. Note: Valid private key generated for above test cases is unencrypted private key (i.e. without passphrase). Adding test cases with private key having passphrase was a little complex than anticipated, hence will create a separate task and tackle it separately. Fixes #34692 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Perf" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9856542221> > Commit: 87074a7373ea5cb8a327baaf9c826fdca3c836d6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9856542221&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Perf` > Spec: > <hr>Tue, 09 Jul 2024 12:20:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Implemented new tests for key pair authentication with both valid and invalid private keys. - Added tests for basic authentication. - Introduced tests for reading an encrypted private key. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|---|---|---|
| .. | ||
| src | ||
| pom.xml | ||