5fd34dcca9
## Description Previously, page names were being hidden behind overflow, and additional "..." was appended if they were long. This made the truncation look unnatural at times. We now use the CSS' text-overflow ellipsis property to avoid this. <img width="683" alt="CleanShot 2023-05-16 at 16 09 41@2x" src="https://github.com/appsmithorg/appsmith/assets/22471214/464c1f1f-0f02-41fb-8823-445d0354cbe1"> #### PR fixes following issue(s) Fixes #19984 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [x] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [x] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|---|---|---|
| .. | ||
| Navigation | ||
| AppPage.styled.tsx | ||
| AppPage.tsx | ||
| AppViewerButton.tsx | ||
| AppViewerHtmlTitle.tsx | ||
| AppViewerPageContainer.tsx | ||
| AppViewerSideNavWrapper.tsx | ||
| BrandingBadge.tsx | ||
| BrandingBadgeMobile.tsx | ||
| index.tsx | ||
| loader.tsx | ||
| PageMenu.styled.tsx | ||
| PageMenu.tsx | ||
| PageTabs.tsx | ||
| PrimaryCTA.test.tsx | ||
| PrimaryCTA.tsx | ||
| SideNav.tsx | ||
| SideNavItem.tsx | ||
| utils.ts | ||