PromucFlow_constructor/app/client/src/pages/Editor
sneha122 54484c81a5
fix: gsheet file picker background issue fixed (#24049)
## Description
This PR fixes:
- When creating google sheets datasource with specific sheets modality,
the file picker is being shown on blank page, but before we see file
picker, we see appsmith page for a bit and then see the blank page, this
creates the illusion that file picker is being opened outside of
appsmith.



https://github.com/appsmithorg/appsmith/assets/30018882/616fd98f-7193-47ce-b09a-00cf4a690ae1

- Issue fixed looks like below:



https://github.com/appsmithorg/appsmith/assets/30018882/515f8ba3-997f-4f7c-9f3b-b3c16bbff086


#### PR fixes following issue(s)
Fixes #24046 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
1) Check on the scope of the permission
2) Check on the file picker is appearing 
3) Check if the header of app smith is visible when the file picker is
displayed to the user

#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2023-06-08 14:58:29 +05:30
..
__tests__ feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
APIEditor fix: Disable run button when there are empty fields (#24031) 2023-06-08 14:39:19 +05:30
AppSettingsPane fix: fixed validation error for logo upload (#24006) 2023-06-08 13:38:21 +05:30
CanvasLayoutConversion chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
CanvasPropertyPane feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
DataSourceEditor chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
EditorAppName feat: Adds option to fork an app within the app editor (#23158) 2023-05-30 14:54:38 +05:30
Explorer chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
FirstTimeUserOnboarding feat: onboarding flow revamp for first time admin users: ce (#23581) 2023-05-25 23:51:56 +05:30
GeneratePage fix: connect datasource size issue in the generate page form (#24073) 2023-06-07 10:20:50 +05:30
gitSync fix: git repo button is unresponsive (#24206) 2023-06-08 14:54:27 +05:30
GlobalHotKeys fix: Removed duplicate flaky test (#24189) 2023-06-08 10:02:23 +05:30
GuidedTour feat: Table one click binding for MongoDB and Postgres (#23629) 2023-06-01 22:56:05 +05:30
IntegrationEditor feat: Table one click binding for MongoDB and Postgres (#23629) 2023-06-01 22:56:05 +05:30
JSEditor chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
MultiSelectPropertyPane feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
PropertyPane feat: Table one click binding for MongoDB and Postgres (#23629) 2023-06-01 22:56:05 +05:30
QueryEditor fix: Disable run button when there are empty fields (#24031) 2023-06-08 14:39:19 +05:30
SaaSEditor fix: gsheet file picker background issue fixed (#24049) 2023-06-08 14:58:29 +05:30
ThemePropertyPane fix: updated Box shadow UI (#23795) 2023-06-08 06:53:28 +05:30
WidgetsEditor chore: Add analytics event to track telemetry is disabled & update properties for INVITE_USER event (#24042) 2023-06-06 02:57:40 +05:30
ActionSettings.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
Canvas.tsx feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
EditorHeader.tsx chore: Revert Multi pane scale (#23909) 2023-05-31 18:36:34 +05:30
EditorSaveIndicator.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
EntityNotFoundPane.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
FormConfig.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
FormControl.test.tsx feat: Maintain Focus and Context Phase 1 (#16317) 2022-10-17 20:46:38 +05:30
FormControl.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
HelpButton.tsx feat: intercom consent with ADS 2.0 changes and cypress test cases (#23906) 2023-06-01 19:36:57 +05:30
index.tsx chore: Revert Multi pane scale (#23909) 2023-05-31 18:36:34 +05:30
loader.tsx Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
MainContainer.test.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
MainContainer.tsx chore: Switch environment CE BE code split (#23755) 2023-05-26 21:50:59 +05:30
MainContainerLayoutControl.test.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
MainContainerLayoutControl.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
Popper.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
PropertyPaneHelpButton.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
RealtimeAppEditors.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
RequestConfirmationModal.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
routes.tsx chore: Revert Multi pane scale (#23909) 2023-05-31 18:36:34 +05:30
ShareApplicationForm.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ToggleModeButton.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
utils.ts feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
WidgetCard.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
WidgetCardsPane.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetSidebar.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
WidgetsMultiSelectBox.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30