## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
301 lines
10 KiB
TypeScript
301 lines
10 KiB
TypeScript
import type { AppState } from "@appsmith/reducers";
|
|
import { reflowMoveAction, stopReflowAction } from "actions/reflowActions";
|
|
import type {
|
|
OccupiedSpace,
|
|
WidgetSpace,
|
|
} from "constants/CanvasEditorConstants";
|
|
import { isEmpty, throttle } from "lodash";
|
|
import { useEffect, useRef } from "react";
|
|
import { useDispatch, useSelector } from "react-redux";
|
|
import { reflow } from "reflow";
|
|
import type {
|
|
BlockSpace,
|
|
CollidingSpace,
|
|
CollidingSpaceMap,
|
|
GridProps,
|
|
MovementLimitMap,
|
|
PrevReflowState,
|
|
ReflowDirection,
|
|
ReflowedSpaceMap,
|
|
SecondOrderCollisionMap,
|
|
SpaceMap,
|
|
} from "reflow/reflowTypes";
|
|
import {
|
|
getBottomMostRow,
|
|
getLimitedMovementMap,
|
|
getSpacesMapFromArray,
|
|
willItCauseUndroppableState,
|
|
} from "reflow/reflowUtils";
|
|
import { isCurrentCanvasDragging } from "sagas/selectors";
|
|
import { getContainerWidgetSpacesSelectorWhileMoving } from "selectors/editorSelectors";
|
|
import { getIsReflowing } from "selectors/widgetReflowSelectors";
|
|
import { getBottomRowAfterReflow } from "utils/reflowHookUtils";
|
|
|
|
type WidgetCollidingSpace = CollidingSpace & {
|
|
type: string;
|
|
isDropTarget: boolean;
|
|
};
|
|
|
|
type WidgetCollidingSpaceMap = {
|
|
horizontal: WidgetCollisionMap;
|
|
vertical: WidgetCollisionMap;
|
|
};
|
|
export type WidgetCollisionMap = {
|
|
[key: string]: WidgetCollidingSpace;
|
|
};
|
|
|
|
export interface ReflowInterface {
|
|
(
|
|
newPositions: BlockSpace[],
|
|
direction: ReflowDirection,
|
|
stopMoveAfterLimit?: boolean,
|
|
shouldSkipContainerReflow?: boolean,
|
|
forceDirection?: boolean,
|
|
immediateExitContainer?: string,
|
|
mousePosition?: OccupiedSpace,
|
|
reflowAfterTimeoutCallback?: (reflowParams: {
|
|
movementMap: ReflowedSpaceMap;
|
|
spacePositionMap: SpaceMap | undefined;
|
|
movementLimitMap: MovementLimitMap | undefined;
|
|
}) => void,
|
|
): {
|
|
movementLimitMap?: MovementLimitMap;
|
|
movementMap: ReflowedSpaceMap;
|
|
bottomMostRow: number;
|
|
spacePositionMap: SpaceMap | undefined;
|
|
};
|
|
}
|
|
|
|
export const useReflow = (
|
|
OGPositions: OccupiedSpace[],
|
|
parentId: string,
|
|
gridProps: GridProps,
|
|
shouldResize = true,
|
|
): { reflowSpaces: ReflowInterface; resetReflow: () => void } => {
|
|
const dispatch = useDispatch();
|
|
const isReflowingGlobal = useSelector(getIsReflowing);
|
|
|
|
const isDraggingCanvas = useSelector((state: AppState) =>
|
|
isCurrentCanvasDragging(state, parentId),
|
|
);
|
|
|
|
const throttledDispatch = throttle(dispatch, 50);
|
|
|
|
const isReflowing = useRef<boolean>(false);
|
|
|
|
const reflowSpacesSelector =
|
|
getContainerWidgetSpacesSelectorWhileMoving(parentId);
|
|
const widgetSpaces: WidgetSpace[] = useSelector(reflowSpacesSelector) || [];
|
|
|
|
// Store previous values of reflow results
|
|
const prevPositions = useRef<OccupiedSpace[] | undefined>(OGPositions);
|
|
const prevCollidingSpaces = useRef<WidgetCollidingSpaceMap>();
|
|
const prevMovementMap = useRef<ReflowedSpaceMap>({});
|
|
const prevSecondOrderCollisionMap = useRef<SecondOrderCollisionMap>({});
|
|
|
|
// Indicates if the Containers should be reflowed
|
|
const shouldReflowDropTargets = useRef<boolean>(false);
|
|
// ref of timeout method
|
|
const timeOutFunction = useRef<any>();
|
|
// store exit container and mouse position at exit, so that it can be used during timeout
|
|
const exitContainer = useRef<string | undefined>(undefined);
|
|
const mousePointerAtContainerExit = useRef<OccupiedSpace | undefined>(
|
|
undefined,
|
|
);
|
|
|
|
useEffect(() => {
|
|
//only have it run when the user has completely stopped dragging and stopped Reflowing
|
|
if (!isReflowingGlobal && !isDraggingCanvas) {
|
|
isReflowing.current = false;
|
|
prevPositions.current = [...OGPositions];
|
|
prevCollidingSpaces.current = { horizontal: {}, vertical: {} };
|
|
prevMovementMap.current = {};
|
|
prevSecondOrderCollisionMap.current = {};
|
|
shouldReflowDropTargets.current = false;
|
|
}
|
|
|
|
if (!isDraggingCanvas) {
|
|
clearTimeout(timeOutFunction.current);
|
|
exitContainer.current = undefined;
|
|
mousePointerAtContainerExit.current = undefined;
|
|
}
|
|
}, [isReflowingGlobal, isDraggingCanvas]);
|
|
|
|
// will become a state if we decide that resize should be a "toggle on-demand" feature
|
|
return {
|
|
reflowSpaces: (
|
|
newPositions: BlockSpace[],
|
|
direction: ReflowDirection,
|
|
stopMoveAfterLimit = false,
|
|
shouldSkipContainerReflow = false,
|
|
forceDirection = false,
|
|
immediateExitContainer?: string,
|
|
mousePosition?: OccupiedSpace,
|
|
reflowAfterTimeoutCallback?: (reflowParams: {
|
|
movementMap: ReflowedSpaceMap;
|
|
spacePositionMap: SpaceMap | undefined;
|
|
movementLimitMap: MovementLimitMap | undefined;
|
|
}) => void,
|
|
) => {
|
|
clearTimeout(timeOutFunction.current);
|
|
|
|
const prevReflowState: PrevReflowState = {
|
|
prevSpacesMap: getSpacesMapFromArray(prevPositions.current),
|
|
prevCollidingSpaceMap: prevCollidingSpaces.current as CollidingSpaceMap,
|
|
prevMovementMap: prevMovementMap.current,
|
|
prevSecondOrderCollisionMap: prevSecondOrderCollisionMap.current,
|
|
};
|
|
|
|
const {
|
|
collidingSpaceMap,
|
|
movementLimitMap,
|
|
movementMap,
|
|
secondOrderCollisionMap,
|
|
shouldRegisterContainerTimeout,
|
|
spacePositionMap,
|
|
} = reflow(
|
|
newPositions,
|
|
OGPositions,
|
|
widgetSpaces,
|
|
direction,
|
|
gridProps,
|
|
forceDirection,
|
|
shouldResize,
|
|
prevReflowState,
|
|
immediateExitContainer,
|
|
mousePosition,
|
|
!shouldSkipContainerReflow || shouldReflowDropTargets.current,
|
|
);
|
|
|
|
prevPositions.current = newPositions;
|
|
prevCollidingSpaces.current =
|
|
collidingSpaceMap as WidgetCollidingSpaceMap;
|
|
prevSecondOrderCollisionMap.current = secondOrderCollisionMap || {};
|
|
|
|
//store exit container and mouse pointer if we are not reflowing drop targets and it doesn't already have a value
|
|
if (!shouldReflowDropTargets.current && !exitContainer.current) {
|
|
exitContainer.current = immediateExitContainer;
|
|
mousePointerAtContainerExit.current = mousePosition;
|
|
}
|
|
|
|
let correctedMovementMap = movementMap || {};
|
|
|
|
if (stopMoveAfterLimit) {
|
|
correctedMovementMap = getLimitedMovementMap(
|
|
movementMap,
|
|
prevMovementMap.current,
|
|
{ canHorizontalMove: true, canVerticalMove: true },
|
|
);
|
|
}
|
|
|
|
prevMovementMap.current = correctedMovementMap;
|
|
const collidingSpaces = [
|
|
...Object.values(collidingSpaceMap?.horizontal || []),
|
|
...Object.values(collidingSpaceMap?.vertical || []),
|
|
] as WidgetCollidingSpace[];
|
|
|
|
// Logic for container jump
|
|
if (shouldSkipContainerReflow) {
|
|
if (shouldRegisterContainerTimeout) {
|
|
// register a timeout method to trigger reflow if widget is not moved and is colliding with Droptargets
|
|
timeOutFunction.current = setTimeout(() => {
|
|
//call reflow again
|
|
const {
|
|
collidingSpaceMap,
|
|
movementLimitMap,
|
|
movementMap,
|
|
secondOrderCollisionMap,
|
|
} = reflow(
|
|
newPositions,
|
|
OGPositions,
|
|
widgetSpaces,
|
|
direction,
|
|
gridProps,
|
|
forceDirection,
|
|
shouldResize,
|
|
prevReflowState,
|
|
exitContainer.current,
|
|
mousePointerAtContainerExit.current || mousePosition,
|
|
true,
|
|
true,
|
|
);
|
|
exitContainer.current = undefined;
|
|
mousePointerAtContainerExit.current = undefined;
|
|
|
|
//if the result causes an undroppable state return
|
|
if (willItCauseUndroppableState(movementLimitMap)) return;
|
|
|
|
// trigger reflow action with result of reflow algorithm
|
|
if (!isEmpty(movementMap)) {
|
|
shouldReflowDropTargets.current = true;
|
|
isReflowing.current = true;
|
|
dispatch(reflowMoveAction(movementMap || {}));
|
|
//trigger callback if reflow action is called
|
|
reflowAfterTimeoutCallback &&
|
|
reflowAfterTimeoutCallback({
|
|
movementMap: prevMovementMap.current,
|
|
spacePositionMap: undefined,
|
|
movementLimitMap,
|
|
});
|
|
|
|
prevCollidingSpaces.current =
|
|
collidingSpaceMap as WidgetCollidingSpaceMap;
|
|
prevSecondOrderCollisionMap.current =
|
|
secondOrderCollisionMap || {};
|
|
prevMovementMap.current = movementMap || {};
|
|
} else if (isReflowing.current) {
|
|
isReflowing.current = false;
|
|
throttledDispatch.cancel();
|
|
dispatch(stopReflowAction());
|
|
shouldReflowDropTargets.current = false;
|
|
}
|
|
}, 500);
|
|
} // This checks if colliding space does not contain any drop targets
|
|
else if (
|
|
!collidingSpaces.some(
|
|
(collidingSpaces) => collidingSpaces.isDropTarget,
|
|
)
|
|
) {
|
|
shouldReflowDropTargets.current = false;
|
|
mousePointerAtContainerExit.current = undefined;
|
|
exitContainer.current = undefined;
|
|
}
|
|
}
|
|
|
|
//Trigger reflow action
|
|
if (!isEmpty(correctedMovementMap)) {
|
|
isReflowing.current = true;
|
|
if (forceDirection) dispatch(reflowMoveAction(correctedMovementMap));
|
|
else throttledDispatch(reflowMoveAction(correctedMovementMap));
|
|
} else if (isReflowing.current) {
|
|
isReflowing.current = false;
|
|
throttledDispatch.cancel();
|
|
dispatch(stopReflowAction());
|
|
shouldReflowDropTargets.current = false;
|
|
}
|
|
|
|
//calculate bottom row
|
|
const bottomMostRow = getBottomRowAfterReflow(
|
|
movementMap,
|
|
getBottomMostRow(newPositions),
|
|
widgetSpaces,
|
|
gridProps,
|
|
);
|
|
|
|
return {
|
|
movementLimitMap,
|
|
movementMap: correctedMovementMap,
|
|
bottomMostRow,
|
|
spacePositionMap,
|
|
};
|
|
},
|
|
//reset Reflow parameters when this is called, usually while resetting canvas
|
|
resetReflow: () => {
|
|
clearTimeout(timeOutFunction.current);
|
|
shouldReflowDropTargets.current = false;
|
|
mousePointerAtContainerExit.current = undefined;
|
|
exitContainer.current = undefined;
|
|
},
|
|
};
|
|
};
|