92c72ee20e
## Description - update node version and appropriate git workflow - added the path to webpack cache folder, this should speed up bundle creation about a minute [Test, build and push Docker Image](https://github.com/appsmithorg/appsmith/actions/runs/8421752151) [Build Client, Server & Run only Cypress](https://github.com/appsmithorg/appsmith/actions/runs/8421752151) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated actions/cache and actions/setup-node to v4 across various workflows for improved caching and Node.js setup. - Modified the `yarn install` command to use `--immutable` flag, enhancing dependency management. - **Documentation** - Updated comments within workflows to include cautionary and important notes, ensuring better clarity. - **Refactor** - Adjusted caching paths and keys for more efficient caching behavior. - Changed Node.js installation to version 20.11.1 in Dockerfile, aligning with the latest version for better performance and security. - **Tests** - Modified assertion in `getCurrentLocationSaga` test to check for the presence of a property, improving test accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aman Agarwal <aman@appsmith.com>
99 lines
3.2 KiB
YAML
99 lines
3.2 KiB
YAML
name: Client Lint
|
||
|
||
on:
|
||
workflow_call:
|
||
inputs:
|
||
pr:
|
||
description: "This is the PR number in case the workflow is being called in a pull request"
|
||
required: false
|
||
type: number
|
||
skip-tests:
|
||
description: "This is a boolean value in case the workflow is being called in build deploy-preview"
|
||
required: false
|
||
type: string
|
||
default: "false"
|
||
|
||
# Change the working directory for all the jobs in this workflow
|
||
defaults:
|
||
run:
|
||
working-directory: app/client
|
||
|
||
jobs:
|
||
client-lint:
|
||
runs-on: ubuntu-latest-8-cores
|
||
defaults:
|
||
run:
|
||
working-directory: app/client
|
||
shell: bash
|
||
|
||
steps:
|
||
# The checkout steps MUST happen first because the default directory is set according to the code base.
|
||
# GitHub Action expects all future commands to be executed in the code directory. Hence, we need to check out
|
||
# the code before doing anything else.
|
||
|
||
# Check out merge commit with the base branch in case this workflow is invoked via pull request
|
||
- name: Checkout the merged commit from PR and base branch
|
||
uses: actions/checkout@v4
|
||
with:
|
||
ref: refs/pull/${{ inputs.pr }}/merge
|
||
|
||
# In case this is second attempt try restoring status of the prior attempt from cache
|
||
- name: Restore the previous run result
|
||
uses: actions/cache@v4
|
||
with:
|
||
path: |
|
||
~/run_result
|
||
key: ${{ github.run_id }}-${{ github.job }}-client
|
||
|
||
# Fetch prior run result
|
||
- name: Get the previous run result
|
||
id: run_result
|
||
run: cat ~/run_result 2>/dev/null || echo 'default'
|
||
|
||
# In case of prior failure run the job
|
||
- if: steps.run_result.outputs.run_result != 'success'
|
||
run: echo "I'm alive!" && exit 0
|
||
|
||
- name: Use Node.js
|
||
if: steps.run_result.outputs.run_result != 'success'
|
||
uses: actions/setup-node@v4
|
||
with:
|
||
node-version-file: app/client/package.json
|
||
|
||
# actions/setup-node@v4 doesn’t work properly with Yarn 3
|
||
# when the project lives in a subdirectory: https://github.com/actions/setup-node/issues/488
|
||
# Restoring the cache manually instead
|
||
- name: Restore Yarn cache
|
||
if: steps.run_result.outputs.run_result != 'success'
|
||
uses: actions/cache@v4
|
||
with:
|
||
path: app/client/.yarn/cache
|
||
key: v1-yarn3-${{ hashFiles('app/client/yarn.lock') }}
|
||
restore-keys: |
|
||
v1-yarn3-
|
||
|
||
# Install all the dependencies
|
||
- name: Install dependencies
|
||
if: steps.run_result.outputs.run_result != 'success'
|
||
run: |
|
||
corepack enable
|
||
yarn install --immutable
|
||
|
||
# Run the Lint for client and packages
|
||
- name: Run lint
|
||
if: steps.run_result.outputs.run_result != 'success'
|
||
run: yarn run lint:ci
|
||
|
||
# Saving the cache to use it in subsequent runs
|
||
- name: Save Yarn cache
|
||
uses: actions/cache/save@v4
|
||
with:
|
||
path: app/client/.yarn/cache
|
||
key: v1-yarn3-${{ hashFiles('app/client/yarn.lock') }}
|
||
restore-keys: |
|
||
v1-yarn3-
|
||
|
||
# Set status = success
|
||
- name: Save the status of the run
|
||
run: echo "run_result=success" >> $GITHUB_OUTPUT > ~/run_result
|