## Description - support for default mobile camera for code scanner widget #### PR fixes following issue(s) Fixes #25766 #### Media #### Type of change - New feature (non-breaking change which adds functionality) #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [x] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
74 lines
2.0 KiB
TypeScript
74 lines
2.0 KiB
TypeScript
import { getVideoConstraints } from "./utils";
|
|
|
|
describe("getVideoConstraints", () => {
|
|
test("returns default video constraints when no deviceId and not mobile", () => {
|
|
const prevConstraints = { width: { ideal: 1280 }, height: { ideal: 720 } };
|
|
const defaultCamera = "environment";
|
|
const isMobile = false;
|
|
|
|
const constraints = getVideoConstraints(
|
|
prevConstraints,
|
|
isMobile,
|
|
defaultCamera,
|
|
);
|
|
|
|
expect(constraints).toEqual(prevConstraints);
|
|
});
|
|
|
|
test("returns video constraints with deviceId when deviceId is provided", () => {
|
|
const prevConstraints = { width: { ideal: 1280 }, height: { ideal: 720 } };
|
|
const defaultCamera = "environment";
|
|
const isMobile = false;
|
|
const deviceId = "test-device-id";
|
|
|
|
const constraints = getVideoConstraints(
|
|
prevConstraints,
|
|
isMobile,
|
|
defaultCamera,
|
|
deviceId,
|
|
);
|
|
|
|
expect(constraints).toEqual({
|
|
...prevConstraints,
|
|
deviceId: "test-device-id",
|
|
});
|
|
});
|
|
|
|
test("returns video constraints with facingMode when isMobile is true", () => {
|
|
const prevConstraints = { width: { ideal: 1280 }, height: { ideal: 720 } };
|
|
const defaultCamera = "environment";
|
|
const isMobile = true;
|
|
|
|
const constraints = getVideoConstraints(
|
|
prevConstraints,
|
|
isMobile,
|
|
defaultCamera,
|
|
);
|
|
|
|
expect(constraints).toEqual({
|
|
...prevConstraints,
|
|
facingMode: { ideal: "environment" },
|
|
});
|
|
});
|
|
|
|
test("returns video constraints with both deviceId and facingMode when provided", () => {
|
|
const prevConstraints = { width: { ideal: 1280 }, height: { ideal: 720 } };
|
|
const defaultCamera = "environment";
|
|
const isMobile = true;
|
|
const deviceId = "test-device-id";
|
|
|
|
const constraints = getVideoConstraints(
|
|
prevConstraints,
|
|
isMobile,
|
|
defaultCamera,
|
|
deviceId,
|
|
);
|
|
|
|
expect(constraints).toEqual({
|
|
...prevConstraints,
|
|
deviceId: "test-device-id",
|
|
facingMode: { ideal: "environment" },
|
|
});
|
|
});
|
|
});
|