PromucFlow_constructor/app/server
Shrikant Sharat Kandula 4bc1785392
chore: Deprecate .findById signature with Optional parameter (#34281)
This is work on getting to remove the `.findById` signature with
`Optional<>` arguments. This signature doesn't add any value, encourages
confusing multi-signature service methods (check the diff here), and is
causing unnecessary problems in `pg` branch with generating `*Cake`
classes.

This PR doesn't get rid of this entirely, just one part. A follow-up PR
will be opened after this is merged.

Nothing new, nothing fixed. Only a refactor.

No conflicts to EE, but needs extra changes, in [this
PR](https://github.com/appsmithorg/appsmith-ee/pull/3714) to be merged
for the build to pass.

**/test sanity**

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9549476417>
> Commit: c1e45f2fe50530b7ec8436d9722310537d125166
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9549476417&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Simplified method signatures by removing the use of `Optional` for
permission parameters across various services. Permissions are now
passed directly.
- Deprecated `findById` method that uses `Optional<AclPermission>` to
improve code clarity and maintainability.

- **Chores**
- Updated test cases to remove the use of `Optional.empty()` and
replaced with `null` in method calls.
  - Removed unnecessary imports of `Optional` in multiple files.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-18 15:07:23 +05:30
..
.run feat: Databricks plugin (#29746) 2023-12-26 10:04:09 +05:30
appsmith-git chore: autocommit feature branch (#34062) 2024-06-10 12:35:23 +05:30
appsmith-interfaces chore: added new relic telemetry for spans (#34240) 2024-06-14 14:41:41 +05:30
appsmith-plugins chore: Add gpt-4o mode in vision command (#33637) 2024-06-17 14:07:03 +05:30
appsmith-server chore: Deprecate .findById signature with Optional parameter (#34281) 2024-06-18 15:07:23 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Introduce changes to minimize git footprint (#32595) 2024-04-16 21:34:24 +05:30
scripts chore: Splitting JS Object body dump vs parsed JS Object update to remove race condition originated bad state (#33124) 2024-05-13 09:38:30 +05:30
.gitignore chore: Removed failed tests file from git (#29602) 2023-12-14 13:02:36 +05:30
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: Introduce changes to minimize git footprint (#32595) 2024-04-16 21:34:24 +05:30
Procfile
README.md
system.properties

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.