This is work on getting to remove the `.findById` signature with `Optional<>` arguments. This signature doesn't add any value, encourages confusing multi-signature service methods (check the diff here), and is causing unnecessary problems in `pg` branch with generating `*Cake` classes. This PR doesn't get rid of this entirely, just one part. A follow-up PR will be opened after this is merged. Nothing new, nothing fixed. Only a refactor. No conflicts to EE, but needs extra changes, in [this PR](https://github.com/appsmithorg/appsmith-ee/pull/3714) to be merged for the build to pass. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9549476417> > Commit: c1e45f2fe50530b7ec8436d9722310537d125166 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9549476417&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified method signatures by removing the use of `Optional` for permission parameters across various services. Permissions are now passed directly. - Deprecated `findById` method that uses `Optional<AclPermission>` to improve code clarity and maintainability. - **Chores** - Updated test cases to remove the use of `Optional.empty()` and replaced with `null` in method calls. - Removed unnecessary imports of `Optional` in multiple files. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| .run | ||
| appsmith-git | ||
| appsmith-interfaces | ||
| appsmith-plugins | ||
| appsmith-server | ||
| envs | ||
| mongo-seed | ||
| reactive-caching | ||
| scripts | ||
| .gitignore | ||
| build.sh | ||
| buildpack-run.sh | ||
| pom.xml | ||
| Procfile | ||
| README.md | ||
| system.properties | ||
Appsmith Server
This is the server-side repository for the Appsmith framework.
For details on setting up your development machine, please refer to this Setup Guide.