PromucFlow_constructor/app/client/cypress
Jacques Ikot 4b66e0c8ee
feat: implement infinite scroll hook (#40050)
#  Optimized Infinite Scrolling for TableWidgetV2  

## 📌 Problem  
The **infinite scrolling** feature in **TableWidgetV2** did not load the
correct number of pages (2) on init, and the table rows length was more
than the data fetched
 
##  Solution  
This PR optimizes **infinite scrolling** by:    
- 📥 **Automatically loading the next page of data** when the initial
rows are **≤ 1 page**
- 📊 **Simplifying row count management** by using the actual **rows
length** instead of relying on `totalRecordsCount` which does not tell
actual rows loaded into the table

---  

### 🚀 How to Test  
1. Enable **Infinite Scroll** in **TableWidgetV2**.  
2. Ensure that additional pages (page 2) loads **automatically** when
the initial rows are ≤ 1 page.
3. Verify that **pagination behavior remains consistent** with expected
results.



Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14241762644>
> Commit: 8bf69c9dc7cddee2ef272750797ab2c6cd854028
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14241762644&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity`
> Spec:
> <hr>Thu, 03 Apr 2025 12:53:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a new `useInfiniteScroll` hook to enhance infinite
scrolling functionality in the table widget.
  
- **Refactor**
- Simplified pagination logic by directly utilizing the length of the
rows array, improving performance and clarity.
  
- **Bug Fixes**
- Adjusted test data and assertions in the Cypress test suite to better
reflect the expected behavior of the table widget under varying content
conditions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>
2025-04-03 06:58:56 -07:00
..
e2e feat: implement infinite scroll hook (#40050) 2025-04-03 06:58:56 -07:00
fixtures test: fix cypress tests for custom widgets (#39905) 2025-03-28 18:06:05 +05:30
locators chore: Move signup_disabled and form_login_enabled from envs to DB (#39882) 2025-03-26 11:26:00 +05:30
patches
plugins chore: change snapshot package (#35867) 2024-09-12 11:09:42 +03:00
scripts ci: CI update for commitMsg (#39254) 2025-02-13 19:59:11 +05:30
snapshots/Regression/ClientSide fix: fix for js visual spec snapshots (#39154) 2025-02-10 19:41:52 +05:30
support feat: added global logout feature (#39942) 2025-04-02 12:20:06 +05:30
.eslintrc.json chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
apply-patches.js
Dockerfile chore: change snapshot package (#35867) 2024-09-12 11:09:42 +03:00
index.ts
init-mssql-dump-for-test.sql
init-mysql-dump-for-test.sql
init-pg-dump-for-test.sql
limited-tests.txt test: updated boolean spec (#39789) 2025-03-19 10:35:12 +05:30
setup-test-ci.sh chore: Logs and potential fix for CI startup flakiness (#34461) 2024-06-25 14:03:56 +05:30
tags.js chore: AI Chat e2e tests (#39490) 2025-03-07 17:33:16 +05:30
test.sh
tsconfig.json chore: change snapshot package (#35867) 2024-09-12 11:09:42 +03:00
xataadd.sh
xatadel.sh