## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
129 lines
3.7 KiB
TypeScript
129 lines
3.7 KiB
TypeScript
import type { ReduxAction } from "ee/constants/ReduxActionConstants";
|
|
import { ReduxActionTypes } from "ee/constants/ReduxActionConstants";
|
|
import { intersection } from "lodash";
|
|
import type { DependencyMap } from "utils/DynamicBindingUtils";
|
|
import type { QueryActionConfig } from "entities/Action";
|
|
import type { DatasourceConfiguration } from "entities/Datasource";
|
|
import type { DiffWithNewTreeState } from "workers/Evaluation/helpers";
|
|
import {
|
|
EVALUATE_REDUX_ACTIONS,
|
|
EVAL_AND_LINT_REDUX_ACTIONS,
|
|
LINT_REDUX_ACTIONS,
|
|
LOG_REDUX_ACTIONS,
|
|
} from "ee/actions/evaluationActionsList";
|
|
|
|
export const shouldTriggerEvaluation = (action: ReduxAction<unknown>) => {
|
|
return (
|
|
shouldProcessAction(action) && EVALUATE_REDUX_ACTIONS.includes(action.type)
|
|
);
|
|
};
|
|
export const shouldTriggerLinting = (action: ReduxAction<unknown>) => {
|
|
return shouldProcessAction(action) && !!LINT_REDUX_ACTIONS[action.type];
|
|
};
|
|
|
|
export const getAllActionTypes = (action: ReduxAction<unknown>) => {
|
|
if (
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
Array.isArray(action.payload)
|
|
) {
|
|
const batchedActionTypes = action.payload.map(
|
|
(batchedAction) => batchedAction.type as string,
|
|
);
|
|
|
|
return batchedActionTypes;
|
|
}
|
|
|
|
return [action.type];
|
|
};
|
|
|
|
export const shouldProcessAction = (action: ReduxAction<unknown>) => {
|
|
const actionTypes = getAllActionTypes(action);
|
|
|
|
return intersection(EVAL_AND_LINT_REDUX_ACTIONS, actionTypes).length > 0;
|
|
};
|
|
|
|
export function shouldLog(action: ReduxAction<unknown>) {
|
|
if (
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
Array.isArray(action.payload)
|
|
) {
|
|
const batchedActionTypes = action.payload.map(
|
|
(batchedAction) => batchedAction.type,
|
|
);
|
|
|
|
return batchedActionTypes.some(
|
|
(actionType) => LOG_REDUX_ACTIONS[actionType],
|
|
);
|
|
}
|
|
|
|
return LOG_REDUX_ACTIONS[action.type];
|
|
}
|
|
|
|
export const setEvaluatedTree = (
|
|
updates: DiffWithNewTreeState[],
|
|
): ReduxAction<{ updates: DiffWithNewTreeState[] }> => {
|
|
return {
|
|
type: ReduxActionTypes.SET_EVALUATED_TREE,
|
|
payload: { updates },
|
|
};
|
|
};
|
|
|
|
export const setDependencyMap = (
|
|
inverseDependencyMap: DependencyMap,
|
|
): ReduxAction<{ inverseDependencyMap: DependencyMap }> => {
|
|
return {
|
|
type: ReduxActionTypes.SET_EVALUATION_INVERSE_DEPENDENCY_MAP,
|
|
payload: { inverseDependencyMap },
|
|
};
|
|
};
|
|
|
|
// Called when a form is being setup, for setting up the base condition evaluations for the form
|
|
export const initFormEvaluations = (
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
editorConfig: any,
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
settingConfig: any,
|
|
formId: string,
|
|
) => {
|
|
return {
|
|
type: ReduxActionTypes.INIT_FORM_EVALUATION,
|
|
payload: { editorConfig, settingConfig, formId },
|
|
};
|
|
};
|
|
|
|
// Called when there is change in the data of the form, re evaluates the whole form
|
|
export const startFormEvaluations = (
|
|
formId: string,
|
|
formData: QueryActionConfig,
|
|
datasourceId: string,
|
|
pluginId: string,
|
|
actionDiffPath?: string,
|
|
hasRouteChanged?: boolean,
|
|
datasourceConfiguration?: DatasourceConfiguration,
|
|
) => {
|
|
return {
|
|
type: ReduxActionTypes.RUN_FORM_EVALUATION,
|
|
payload: {
|
|
formId,
|
|
actionConfiguration: formData,
|
|
datasourceId,
|
|
pluginId,
|
|
actionDiffPath,
|
|
hasRouteChanged,
|
|
datasourceConfiguration,
|
|
},
|
|
};
|
|
};
|
|
|
|
// These actions require the entire tree to be re-evaluated
|
|
const FORCE_EVAL_ACTIONS = {
|
|
[ReduxActionTypes.INSTALL_LIBRARY_SUCCESS]: true,
|
|
[ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS]: true,
|
|
};
|
|
|
|
export const shouldForceEval = (action: ReduxAction<unknown>) => {
|
|
return !!FORCE_EVAL_ACTIONS[action.type];
|
|
};
|