467dc1d55b
## Description We are solving 2 problems with this PR: 1. For `Installation Setup Complete` event email domain hash was incorrect and earlier we were hashing the instanceId which means if user with same email tries to run 2 different instances hash was different. 2. `IP` is a reserved keyword for tracking events in Mixpanel though this is allowed in Segment. Instead of showing the ip as is, Mixpanel provides derived property. As we want derived props alongwith the ip address we are sharing the IP address in separate keys. Ref: https://help.mixpanel.com/hc/en-us/articles/360001355266-Event-Properties #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/cloud-services/issues/675 #### Type of change - Bug fix (non-breaking change which fixes an issue) #### How Has This Been Tested? - [x] Manual ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|---|---|---|
| .. | ||
| ansible | ||
| aws | ||
| aws_ami | ||
| digital_ocean | ||
| docker | ||
| helm | ||
| heroku | ||
| packer | ||