2c4ebd8661
## Description This PR introduces the following 1. Removes custom rendering of SQL hints (using ReactDom). Uses default element + custom CSS. 2. SQL Autocompletion hints disappear on mouse down 3. Fixes inconsistency in the style for SQL hint #### PR fixes following issue(s) Fixes #24072 Fixes #24204 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Cypress > > #### Test Plan 1. Verify that the SQL autocomplete closes on mouse down event on editor body(All browser) 2. Verify that the SQL autocomplete closes on click - touchpad event - on body of editor (All browser) 3. Verify above on both MAC and windows laptop 4. Verify Autocomplete style/colour as per JS autocmplete > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed |
||
|---|---|---|
| .. | ||
| autoHeight | ||
| autoHeightOverlay | ||
| BottomBar | ||
| designSystems | ||
| editorComponents | ||
| formControls | ||
| propertyControls | ||
| utils | ||
| wds | ||
| constants.ts | ||
| TabItemBackgroundFill.tsx | ||