Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
43bd03214f
PromucFlow_constructor/app/server
History
Rishabh Rathod 43bd03214f
fix: encode queryParam value and fix parsing logic for queryParams (#33720) 
## Description

- Add encoding for Api key secret value before storing it as query param
to avoid incorrect parsing.
- Remove hardcoded "api_key" check to mask headers.
- Used standard URL parsing APIs instead of custom
- Added unit test to cover the case 

Fixes https://github.com/appsmithorg/appsmith/issues/33742
flaws in the implementation
[here](https://github.com/appsmithorg/appsmith/pull/33528)

## Automation

/test datasource

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9256269257>
> Commit: 602b0f599ff17ac7530b25336eae6a0523c90977
> Workflow: `PR Automation test suite`
> Tags: `@tag.Datasource`

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-27 14:43:59 +00:00
..
.run feat: Databricks plugin (#29746) 2023-12-26 10:04:09 +05:30
appsmith-git chore: Switched key factory for RSA to BC as well (#33605) 2024-05-22 15:12:34 +05:30
appsmith-interfaces fix: encode queryParam value and fix parsing logic for queryParams (#33720) 2024-05-27 14:43:59 +00:00
appsmith-plugins fix: encode queryParam value and fix parsing logic for queryParams (#33720) 2024-05-27 14:43:59 +00:00
appsmith-server chore: additional test cases and method refactor to follow old standards (#33734) 2024-05-27 18:40:38 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Introduce changes to minimize git footprint (#32595) 2024-04-16 21:34:24 +05:30
scripts chore: Splitting JS Object body dump vs parsed JS Object update to remove race condition originated bad state (#33124) 2024-05-13 09:38:30 +05:30
.gitignore chore: Removed failed tests file from git (#29602) 2023-12-14 13:02:36 +05:30
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: Introduce changes to minimize git footprint (#32595) 2024-04-16 21:34:24 +05:30
Procfile
README.md
system.properties

README.md

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.