## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
134 lines
4.4 KiB
TypeScript
134 lines
4.4 KiB
TypeScript
import { matchDatasourcePath } from "constants/routes";
|
|
import type { Log } from "entities/AppsmithConsole";
|
|
import type {
|
|
DataTree,
|
|
DataTreeWidget,
|
|
} from "entities/DataTree/dataTreeFactory";
|
|
import { isEmpty } from "lodash";
|
|
import type { AppState } from "@appsmith/reducers";
|
|
import type { CanvasWidgetsReduxState } from "reducers/entityReducers/canvasWidgetsReducer";
|
|
import { createSelector } from "reselect";
|
|
import { getWidgets } from "sagas/selectors";
|
|
import {
|
|
shouldSuppressDebuggerError,
|
|
isWidget,
|
|
} from "@appsmith/workers/Evaluation/evaluationUtils";
|
|
import { getDataTree } from "./dataTreeSelectors";
|
|
|
|
type ErrorObejct = {
|
|
[k: string]: Log;
|
|
};
|
|
|
|
export const getDebuggerErrors = (state: AppState) => state.ui.debugger.errors;
|
|
export const hideErrors = (state: AppState) => state.ui.debugger.hideErrors;
|
|
const emptyErrorObejct: ErrorObejct = {};
|
|
|
|
export const getFilteredErrors = createSelector(
|
|
getDebuggerErrors,
|
|
hideErrors,
|
|
getWidgets,
|
|
getDataTree,
|
|
(errors, hideErrors, canvasWidgets, dataTree: DataTree) => {
|
|
if (hideErrors) return emptyErrorObejct;
|
|
if (isEmpty(errors)) return emptyErrorObejct;
|
|
|
|
const alwaysShowEntities: Record<string, boolean> = {};
|
|
Object.entries(errors).forEach(([, error]) => {
|
|
const entity = error?.source?.name && dataTree[error.source.name];
|
|
if (
|
|
entity &&
|
|
isWidget(entity) &&
|
|
error.source?.propertyPath === "isVisible"
|
|
) {
|
|
alwaysShowEntities[error.source.id] = true;
|
|
}
|
|
});
|
|
const filteredErrors = Object.fromEntries(
|
|
Object.entries(errors).filter(([, error]) => {
|
|
const entity = error?.source?.name && dataTree[error.source.name];
|
|
// filter error - when widget or parent widget is hidden
|
|
// parent widgets e.g. modal, tab, container
|
|
if (entity && isWidget(entity)) {
|
|
if (shouldSuppressDebuggerError(entity)) {
|
|
return false;
|
|
}
|
|
if (!hasParentWidget(entity)) {
|
|
return entity.isVisible
|
|
? true
|
|
: alwaysShowEntities[entity.widgetId];
|
|
} else {
|
|
const isParentWidgetVisible = isParentVisible(
|
|
entity,
|
|
canvasWidgets,
|
|
dataTree,
|
|
);
|
|
return entity.isVisible
|
|
? isParentWidgetVisible
|
|
: isParentWidgetVisible && alwaysShowEntities[entity.widgetId];
|
|
}
|
|
}
|
|
return true;
|
|
}),
|
|
);
|
|
return filteredErrors;
|
|
},
|
|
);
|
|
|
|
export const isParentVisible = (
|
|
currentWidgetData: DataTreeWidget,
|
|
canvasWidgets: CanvasWidgetsReduxState,
|
|
dataTree: DataTree,
|
|
): boolean => {
|
|
const isWidgetVisible = !!currentWidgetData.isVisible;
|
|
if (!hasParentWidget(currentWidgetData)) {
|
|
return isWidgetVisible;
|
|
}
|
|
const parentWidget = canvasWidgets[currentWidgetData.parentId as string];
|
|
if (!parentWidget) return isWidgetVisible;
|
|
|
|
const parentWidgetData = dataTree[parentWidget.widgetName] as DataTreeWidget;
|
|
if (!parentWidgetData) return isWidgetVisible;
|
|
|
|
switch (parentWidgetData.type) {
|
|
// check for widget types instead of harcoded string
|
|
case "TABS_WIDGET":
|
|
// need type for selectedTab and tabName
|
|
const isTabContentVisible =
|
|
!!parentWidgetData.isVisible &&
|
|
parentWidgetData.selectedTab === currentWidgetData.tabName;
|
|
return isTabContentVisible
|
|
? isParentVisible(parentWidgetData, canvasWidgets, dataTree)
|
|
: false;
|
|
case "MODAL_WIDGET":
|
|
return !!parentWidgetData.isVisible;
|
|
default:
|
|
return parentWidgetData.isVisible
|
|
? isParentVisible(parentWidgetData, canvasWidgets, dataTree)
|
|
: false;
|
|
}
|
|
};
|
|
|
|
export const hasParentWidget = (widget: DataTreeWidget) =>
|
|
widget.parentId && widget.parentId !== "0";
|
|
|
|
export const getMessageCount = createSelector(getFilteredErrors, (errors) => {
|
|
let errorsCount = 0;
|
|
|
|
// count number of messages in each error.
|
|
// This logic is required because each messages in error is rendered separately.
|
|
Object.values(errors).forEach((error) => {
|
|
if (error.messages) {
|
|
errorsCount += error.messages.length;
|
|
}
|
|
});
|
|
// count number of warnings.
|
|
const warningsCount = Object.keys(errors).filter((key: string) =>
|
|
key.includes("warning"),
|
|
).length;
|
|
errorsCount = errorsCount - warningsCount;
|
|
return { errors: errorsCount, warnings: warningsCount };
|
|
});
|
|
|
|
export const hideDebuggerIconSelector = () =>
|
|
matchDatasourcePath(window.location.pathname);
|