PromucFlow_constructor/app/client/cypress/support/Pages/ApiPage.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

414 lines
13 KiB
TypeScript

import { ObjectsRegistry } from "../Objects/Registry";
type RightPaneTabs = "datasources" | "connections";
export class ApiPage {
public agHelper = ObjectsRegistry.AggregateHelper;
public locator = ObjectsRegistry.CommonLocators;
private _createapi = ".t--createBlankApiCard";
_resourceUrl = ".t--dataSourceField";
private _headerKey = (index: number) =>
".t--actionConfiguration\\.headers\\[" +
index +
"\\]\\.key\\." +
index +
"";
private _headerValue = (index: number) =>
".t--actionConfiguration\\.headers\\[" +
index +
"\\]\\.value\\." +
index +
"";
private _paramKey = (index: number) =>
".t--actionConfiguration\\.queryParameters\\[" +
index +
"\\]\\.key\\." +
index +
"";
private _paramValue = (index: number) =>
".t--actionConfiguration\\.queryParameters\\[" +
index +
"\\]\\.value\\." +
index +
"";
private _importedKey = (index: number, keyValueName: string) =>
`.t--${keyValueName}-key-${index}`;
private _importedValue = (index: number, keyValueName: string) =>
`.t--${keyValueName}-value-${index}`;
_bodyKey = (index: number) =>
".t--actionConfiguration\\.bodyFormData\\[0\\]\\.key\\." + index + "";
_bodyValue = (index: number) =>
".t--actionConfiguration\\.bodyFormData\\[0\\]\\.value\\." + index + "";
_bodyTypeDropdown =
"//span[text()='Type'][@class='bp3-button-text']/parent::button";
_apiRunBtn = ".t--apiFormRunBtn";
private _queryTimeout =
"//input[@name='actionConfiguration.timeoutInMillisecond']";
_responseBody = ".CodeMirror-code span.cm-string.cm-property";
private _blankAPI = "span:contains('New Blank API')";
private _apiVerbDropdown = ".t--apiFormHttpMethod";
private _verbToSelect = (verb: string) =>
"//div[contains(@class, 't--dropdown-option')]//span[contains(text(),'" +
verb +
"')]";
private _bodySubTab = (subTab: string) => `[data-cy='tab--${subTab}']`;
private _suggestedWidget = (widget: string) =>
`.t--suggested-widget-${widget}`;
private _rightPaneTab = (tab: string) => `[data-cy='t--tab-${tab}']`;
_visibleTextSpan = (spanText: string) => "//span[text()='" + spanText + "']";
_visibleTextDiv = (divText: string) => "//div[text()='" + divText + "']";
_noBodyMessageDiv = "#NoBodyMessageDiv";
_noBodyMessage = "This request does not have a body";
_imageSrc = "//img/parent::div";
private _trashDelete = "span[name='delete']";
private _onPageLoad = "input[name='executeOnLoad'][type='checkbox']";
private _confirmBeforeRunningAPI =
"input[name='confirmBeforeExecute'][type='checkbox']";
private _paginationTypeLabels = ".t--apiFormPaginationType label";
_saveAsDS = ".t--store-as-datasource";
_responseStatus = ".t--response-status-code";
private _blankGraphqlAPI = "span:contains('New Blank GraphQL API')";
private _importedDataButton = ".t--show-imported-datas";
public _responseTabHeader = "[data-cy=t--tab-headers]";
public _autoGeneratedHeaderInfoIcon = (key: string) =>
`.t--auto-generated-${key}-info`;
private _createQuery = ".t--create-query";
CreateApi(
apiName = "",
apiVerb: "GET" | "POST" | "PUT" | "DELETE" | "PATCH" = "GET",
aftDSSaved = false,
) {
if (aftDSSaved) this.agHelper.GetNClick(this._createQuery);
else {
cy.get(this.locator._createNew).click({ force: true });
cy.get(this._blankAPI).click({ force: true });
}
this.agHelper.ValidateNetworkStatus("@createNewApi", 201);
// cy.get("@createNewApi").then((response: any) => {
// expect(response.response.body.responseMeta.success).to.eq(true);
// cy.get(this.agHelper._actionName)
// .click()
// .invoke("text")
// .then((text) => {
// const someText = text;
// expect(someText).to.equal(response.response.body.data.name);
// });
// }); // to check if Api1 = Api1 when Create Api invoked
if (apiName) this.agHelper.RenameWithInPane(apiName);
cy.get(this._resourceUrl).should("be.visible");
if (apiVerb != "GET") this.SelectAPIVerb(apiVerb);
}
CreateAndFillApi(
url: string,
apiName = "",
queryTimeout = 10000,
apiVerb: "GET" | "POST" | "PUT" | "DELETE" | "PATCH" = "GET",
aftDSSaved = false,
) {
this.CreateApi(apiName, apiVerb, aftDSSaved);
this.EnterURL(url);
//this.agHelper.Sleep(2000);// Added because api name edit takes some time to reflect in api sidebar after the call passes.
cy.get(this._apiRunBtn).should("not.be.disabled");
if (queryTimeout != 10000) this.SetAPITimeout(queryTimeout);
}
EnterURL(url: string) {
this.agHelper.EnterValue(url, {
propFieldName: this._resourceUrl,
directInput: true,
inputFieldName: "",
});
this.agHelper.AssertAutoSave();
}
EnterHeader(hKey: string, hValue: string, index = 0) {
this.SelectPaneTab("Headers");
this.agHelper.EnterValue(hKey, {
propFieldName: this._headerKey(index),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
this.agHelper.EnterValue(hValue, {
propFieldName: this._headerValue(index),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
this.agHelper.AssertAutoSave();
}
EnterParams(pKey: string, pValue: string, index = 0) {
this.SelectPaneTab("Params");
this.agHelper.EnterValue(pKey, {
propFieldName: this._paramKey(index),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
this.agHelper.EnterValue(pValue, {
propFieldName: this._paramValue(index),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
this.agHelper.AssertAutoSave();
}
EnterBodyFormData(
subTab: "FORM_URLENCODED" | "MULTIPART_FORM_DATA",
bKey: string,
bValue: string,
type = "",
toTrash = false,
) {
this.SelectPaneTab("Body");
this.SelectSubTab(subTab);
if (toTrash) {
cy.get(this._trashDelete).first().click();
cy.xpath(this._visibleTextSpan("Add more")).click();
}
this.agHelper.EnterValue(bKey, {
propFieldName: this._bodyKey(0),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
if (type) {
cy.xpath(this._bodyTypeDropdown).eq(0).click();
cy.xpath(this._visibleTextDiv(type)).click();
}
this.agHelper.EnterValue(bValue, {
propFieldName: this._bodyValue(0),
directInput: true,
inputFieldName: "",
});
this.agHelper.PressEscape();
this.agHelper.AssertAutoSave();
}
RunAPI(
toValidateResponse = true,
waitTimeInterval = 20,
validateNetworkAssertOptions?: { expectedPath: string; expectedRes: any },
) {
this.agHelper.GetNClick(this._apiRunBtn, 0, true, waitTimeInterval);
toValidateResponse &&
this.agHelper.ValidateNetworkExecutionSuccess("@postExecute");
// Asserting Network result
validateNetworkAssertOptions?.expectedPath &&
validateNetworkAssertOptions?.expectedRes &&
this.agHelper.ValidateNetworkDataAssert(
"@postExecute",
validateNetworkAssertOptions.expectedPath,
validateNetworkAssertOptions.expectedRes,
);
}
SetAPITimeout(timeout: number) {
this.SelectPaneTab("Settings");
cy.xpath(this._queryTimeout).clear().type(timeout.toString(), { delay: 0 }); //Delay 0 to work like paste!
this.agHelper.AssertAutoSave();
this.SelectPaneTab("Headers");
}
ToggleOnPageLoadRun(enable = true || false) {
this.SelectPaneTab("Settings");
if (enable) this.agHelper.CheckUncheck(this._onPageLoad, true);
else this.agHelper.CheckUncheck(this._onPageLoad, false);
}
ToggleConfirmBeforeRunningApi(enable = true || false) {
this.SelectPaneTab("Settings");
if (enable) this.agHelper.CheckUncheck(this._confirmBeforeRunningAPI, true);
else this.agHelper.CheckUncheck(this._confirmBeforeRunningAPI, false);
}
SelectPaneTab(
tabName:
| "Headers"
| "Params"
| "Body"
| "Pagination"
| "Authentication"
| "Settings"
| "Response"
| "Errors"
| "Logs"
| "Inspect entity",
) {
this.agHelper.PressEscape();
this.agHelper.GetNClick(this._visibleTextSpan(tabName), 0, true);
}
SelectSubTab(
subTabName:
| "NONE"
| "JSON"
| "FORM_URLENCODED"
| "MULTIPART_FORM_DATA"
| "RAW",
) {
this.agHelper.GetNClick(this._bodySubTab(subTabName));
}
AssertRightPaneSelectedTab(tabName: RightPaneTabs) {
cy.get(this._rightPaneTab(tabName)).should(
"have.class",
"react-tabs__tab--selected",
);
}
SelectRightPaneTab(tabName: RightPaneTabs) {
this.agHelper.GetNClick(this._rightPaneTab(tabName));
}
ValidateQueryParams(param: { key: string; value: string }) {
this.SelectPaneTab("Params");
this.agHelper.ValidateCodeEditorContent(this._paramKey(0), param.key);
this.agHelper.ValidateCodeEditorContent(this._paramValue(0), param.value);
}
ValidateHeaderParams(header: { key: string; value: string }) {
this.SelectPaneTab("Headers");
this.agHelper.ValidateCodeEditorContent(this._headerKey(0), header.key);
this.agHelper.ValidateCodeEditorContent(this._headerValue(0), header.value);
}
ValidateImportedHeaderParams(
isAutoGeneratedHeader = false,
header: { key: string; value: string },
index = 0,
) {
let keyValueName = "Header";
if (isAutoGeneratedHeader) {
keyValueName = "autoGeneratedHeader";
}
this.SelectPaneTab("Headers");
this.ValidateImportedKeyValueContent(
this._importedKey(index, keyValueName),
header.key,
);
this.ValidateImportedKeyValueContent(
this._importedValue(index, keyValueName),
header.value,
);
}
public ValidateImportedKeyValueContent(
selector: string,
contentToValidate: any,
) {
this.agHelper.GetNAssertElementText(
selector,
contentToValidate,
"have.text",
);
}
public ValidateImportedKeyValueOverride(index: number, isOverriden = true) {
let assertion = "";
if (isOverriden) {
assertion = "have.css";
} else {
assertion = "not.have.css";
}
cy.get(this._importedKey(index, "autoGeneratedHeader")).should(
assertion,
"text-decoration",
"line-through solid rgb(75, 72, 72)",
);
cy.get(this._importedValue(index, "autoGeneratedHeader")).should(
assertion,
"text-decoration",
"line-through solid rgb(75, 72, 72)",
);
}
ValidateImportedHeaderParamsAbsence(
isAutoGeneratedHeader = false,
index = 0,
) {
let keyValueName = "Header";
if (isAutoGeneratedHeader) {
keyValueName = "autoGeneratedHeader";
}
this.SelectPaneTab("Headers");
this.ValidateImportedKeyValueAbsence(
this._importedKey(index, keyValueName),
);
this.ValidateImportedKeyValueAbsence(
this._importedValue(index, keyValueName),
);
}
public ValidateImportedKeyValueAbsence(selector: string) {
this.agHelper.AssertElementAbsence(selector);
}
ReadApiResponsebyKey(key: string) {
let apiResp = "";
cy.get(this._responseBody)
.contains(key)
.siblings("span")
.invoke("text")
.then((text) => {
apiResp = `${text
.match(/"(.*)"/)![0]
.split('"')
.join("")} `;
cy.log("Key value in api response is :" + apiResp);
cy.wrap(apiResp).as("apiResp");
});
}
SwitchToResponseTab(tabIdentifier: string) {
cy.get(tabIdentifier).click();
}
public SelectAPIVerb(verb: "GET" | "POST" | "PUT" | "DELETE" | "PATCH") {
cy.get(this._apiVerbDropdown).click();
cy.xpath(this._verbToSelect(verb)).should("be.visible").click();
}
ResponseStatusCheck(statusCode: string) {
this.agHelper.AssertElementVisible(this._responseStatus);
this.agHelper.GetNAssertContains(this._responseStatus, statusCode);
}
public SelectPaginationTypeViaIndex(index: number) {
cy.get(this._paginationTypeLabels).eq(index).click({ force: true });
}
CreateAndFillGraphqlApi(url: string, apiName = "", queryTimeout = 10000) {
this.CreateGraphqlApi(apiName);
this.EnterURL(url);
this.agHelper.AssertAutoSave();
//this.agHelper.Sleep(2000);// Added because api name edit takes some time to reflect in api sidebar after the call passes.
cy.get(this._apiRunBtn).should("not.be.disabled");
if (queryTimeout != 10000) this.SetAPITimeout(queryTimeout);
}
CreateGraphqlApi(apiName = "") {
cy.get(this.locator._createNew).click({ force: true });
cy.get(this._blankGraphqlAPI).click({ force: true });
this.agHelper.ValidateNetworkStatus("@createNewApi", 201);
if (apiName) this.agHelper.RenameWithInPane(apiName);
cy.get(this._resourceUrl).should("be.visible");
}
AddSuggestedWidget(widgetName: string) {
this.agHelper.GetNClick(this._suggestedWidget(widgetName));
}
}