PromucFlow_constructor/app/client/cypress/support/ApiCommands.js
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

423 lines
13 KiB
JavaScript

/* eslint-disable cypress/no-unnecessary-waiting */
/* eslint-disable cypress/no-assigning-return-values */
require("cy-verify-downloads").addCustomCommand();
require("cypress-file-upload");
import ApiEditor from "../locators/ApiEditor";
const pages = require("../locators/Pages.json");
const commonlocators = require("../locators/commonlocators.json");
const apiwidget = require("../locators/apiWidgetslocator.json");
const explorer = require("../locators/explorerlocators.json");
export const initLocalstorage = () => {
cy.window().then((window) => {
window.localStorage.setItem("ShowCommentsButtonToolTip", "");
window.localStorage.setItem("updateDismissed", "true");
});
};
Cypress.Commands.add("enterDatasourceAndPath", (datasource, path) => {
cy.enterDatasource(datasource + path);
});
Cypress.Commands.add("enterDatasource", (datasource) => {
cy.get(apiwidget.resourceUrl)
.first()
.click({ force: true })
.type(datasource, { parseSpecialCharSequences: false });
//.type("{esc}}");
cy.wait(2000);
cy.assertPageSave();
});
Cypress.Commands.add("ResponseStatusCheck", (statusCode) => {
cy.xpath(apiwidget.responseStatus).should("be.visible");
cy.xpath(apiwidget.responseStatus).contains(statusCode);
});
Cypress.Commands.add("ResponseCheck", () => {
//Explicit assert
cy.get(apiwidget.responseText).should("be.visible");
});
Cypress.Commands.add("ResponseTextCheck", (textTocheck) => {
cy.ResponseCheck();
cy.get(apiwidget.responseText).contains(textTocheck);
});
Cypress.Commands.add("NavigateToAPI_Panel", () => {
cy.get(pages.addEntityAPI).last().should("be.visible").click({ force: true });
cy.get(pages.integrationCreateNew)
.should("be.visible")
.click({ force: true });
cy.get("#loading").should("not.exist");
});
Cypress.Commands.add("CreateAPI", (apiname) => {
cy.get(explorer.createNew).click({ force: true });
cy.get(explorer.blankAPI).click({ force: true });
cy.wait("@createNewApi");
cy.get(apiwidget.resourceUrl).should("be.visible");
if (apiname) {
cy.renameWithInPane(apiname);
cy.WaitAutoSave();
}
// Added because api name edit takes some time to
// reflect in api sidebar after the call passes.
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(2000);
});
Cypress.Commands.add("CreateSubsequentAPI", (apiname) => {
cy.get(apiwidget.createApiOnSideBar).first().click({ force: true });
cy.get(apiwidget.resourceUrl).should("be.visible");
// cy.get(ApiEditor.nameOfApi)
cy.get(apiwidget.apiTxt).clear().type(apiname).should("have.value", apiname);
cy.WaitAutoSave();
});
Cypress.Commands.add("EditApiName", (apiname) => {
cy.get(apiwidget.ApiName).click({ force: true });
cy.get(apiwidget.apiTxt)
.clear()
.type(apiname, { force: true })
.should("have.value", apiname);
});
Cypress.Commands.add("EditApiNameFromExplorer", (apiname) => {
/*
cy.xpath(apiwidget.popover)
.last()
.click({ force: true });
cy.get(apiwidget.editName).click({ force: true });
*/
cy.get(explorer.editNameField)
.clear()
.type(apiname, { force: true })
.should("have.value", apiname)
.blur();
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(3000);
});
Cypress.Commands.add("RunAPI", () => {
cy.get(ApiEditor.ApiRunBtn).click({ force: true });
cy.wait("@postExecute");
});
Cypress.Commands.add("RunAPIWithoutWaitingForResolution", () => {
cy.get(ApiEditor.ApiRunBtn).click({ force: true });
});
Cypress.Commands.add("SaveAndRunAPI", () => {
cy.WaitAutoSave();
cy.RunAPI();
});
Cypress.Commands.add(
"validateRequest",
(apiName, baseurl, path, verb, error = false) => {
cy.get(".react-tabs__tab").contains("Logs").click();
cy.get("[data-cy=t--debugger-search]").clear().type(apiName);
if (!error) {
cy.get(".object-key").last().contains("request").click();
}
cy.get(".string-value").contains(baseurl.concat(path));
cy.get(".string-value").contains(verb);
cy.get("[data-cy=t--tab-response]").first().click({ force: true });
},
);
Cypress.Commands.add(
"EnterSourceDetailsWithHeader",
(baseUrl, v1method, hKey, hValue) => {
cy.enterDatasourceAndPath(baseUrl, v1method);
cy.get(apiwidget.headerKey)
.first()
.click({ force: true })
.type(hKey, { parseSpecialCharSequences: true });
cy.get(apiwidget.headerValue)
.first()
.click({ force: true })
.type(hValue, { parseSpecialCharSequences: true });
cy.WaitAutoSave();
},
);
Cypress.Commands.add("EditSourceDetail", (baseUrl, v1method) => {
cy.get(apiwidget.editResourceUrl)
.first()
.click({ force: true })
.clear()
.type(`{backspace}${baseUrl}`);
cy.xpath(apiwidget.autoSuggest).first().click({ force: true });
cy.get(ApiEditor.ApiRunBtn).scrollIntoView();
cy.get(apiwidget.editResourceUrl)
.first()
.focus()
.type(v1method)
.should("have.value", v1method);
cy.WaitAutoSave();
});
Cypress.Commands.add("switchToAPIInputTab", () => {
cy.get(apiwidget.apiInputTab).first().click({ force: true });
});
Cypress.Commands.add("enterUrl", (baseUrl, url, value) => {
cy.get(url).first().type(baseUrl.concat(value), {
force: true,
parseSpecialCharSequences: false,
});
});
Cypress.Commands.add(
"EnterSourceDetailsWithQueryParam",
(baseUrl, v1method, hKey, hValue, qKey, qValue) => {
cy.enterDatasourceAndPath(baseUrl, v1method);
cy.get(apiwidget.headerKey)
.first()
.click({ force: true })
.type(hKey, { parseSpecialCharSequences: true });
cy.get(apiwidget.headerValue)
.first()
.click({ force: true })
.type(hValue, { parseSpecialCharSequences: true });
cy.get(apiwidget.queryKey)
.first()
.click({ force: true })
.type(qKey, { force: true })
.should("have.value", qKey);
cy.get(apiwidget.queryValue)
.first()
.click({ force: true })
.type(qValue, { force: true })
.should("have.value", qValue);
cy.WaitAutoSave();
},
);
Cypress.Commands.add("EnterSourceDetailsWithbody", (baseUrl, v1method) => {
cy.enterDatasourceAndPath(baseUrl, v1method);
cy.get(apiwidget.addHeader).first().click({ first: true });
});
Cypress.Commands.add("CreationOfUniqueAPIcheck", (apiname) => {
cy.get(pages.addEntityAPI).click();
cy.get(pages.integrationCreateNew)
.should("be.visible")
.click({ force: true });
cy.get(apiwidget.createapi).click({ force: true });
cy.wait("@createNewApi");
// cy.wait("@getUser");
cy.get(apiwidget.resourceUrl).should("be.visible");
cy.get(apiwidget.ApiName).click({ force: true });
cy.get(apiwidget.apiTxt)
.clear()
.focus()
.type(apiname, { force: true, delay: 500 })
.should("have.value", apiname);
cy.get(".t--action-name-edit-error").should(($x) => {
expect($x).contain(
apiname.concat(" is already being used or is a restricted keyword."),
);
});
cy.get(apiwidget.apiTxt).blur();
});
Cypress.Commands.add("MoveAPIToHome", () => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.copyTo).click({ force: true });
cy.get(apiwidget.home).click({ force: true });
cy.wait("@createNewApi").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
});
Cypress.Commands.add("MoveAPIToPage", (pageName) => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.moveTo).click({ force: true });
cy.get(apiwidget.page).contains(pageName).click({ force: true });
cy.wait("@moveAction").should(
"have.nested.property",
"response.body.responseMeta.status",
200,
);
});
Cypress.Commands.add("copyEntityToPage", (pageName) => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.copyTo).click({ force: true });
cy.get(apiwidget.page).contains(pageName).click({ force: true });
cy.wait("@createNewApi").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
});
Cypress.Commands.add("CopyAPIToHome", () => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.copyTo).click({ force: true });
cy.get(apiwidget.home).click({ force: true });
cy.wait("@createNewApi").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
});
Cypress.Commands.add("RenameEntity", (value, selectFirst) => {
if (selectFirst) {
cy.xpath(apiwidget.popover).first().click({ force: true });
} else {
cy.xpath(apiwidget.popover).last().click({ force: true });
}
cy.get(apiwidget.renameEntity).click({ force: true });
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(2000);
cy.get(explorer.editEntity).last().type(value, { force: true });
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(3000);
});
Cypress.Commands.add("CreateApiAndValidateUniqueEntityName", (apiname) => {
cy.get(apiwidget.createapi).click({ force: true });
cy.wait("@createNewApi");
cy.get(apiwidget.resourceUrl).should("be.visible");
cy.get(apiwidget.ApiName).click({ force: true });
cy.get(apiwidget.apiTxt)
.clear()
.type(apiname, { force: true })
.should("have.value", apiname);
cy.get(".t--action-name-edit-error").should(($x) => {
expect($x).contain(
apiname.concat(" is already being used or is a restricted keyword."),
);
});
});
Cypress.Commands.add("validateMessage", (value) => {
cy.get(".bp3-popover-content").should(($x) => {
expect($x).contain(value.concat(" is already being used."));
});
});
Cypress.Commands.add(
"VerifyPopOverMessage",
(msgAbsenceToVerify, presence = false) => {
// Give this element 3 seconds to appear
let shouldCondition = "not.exist";
if (presence) shouldCondition = "exist";
cy.xpath(
"//div[@class='bp3-popover-content'][contains(text(),'" +
msgAbsenceToVerify +
"')]",
{ timeout: 3000 },
).should(shouldCondition);
},
);
Cypress.Commands.add("DeleteAPIFromSideBar", () => {
cy.deleteEntity();
cy.wait("@deleteAction").should(
"have.nested.property",
"response.body.responseMeta.status",
200,
);
});
Cypress.Commands.add("DeleteWidgetFromSideBar", () => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.delete).click({ force: true });
cy.wait("@updateLayout").should(
"have.nested.property",
"response.body.responseMeta.status",
200,
);
});
Cypress.Commands.add("deleteEntity", () => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.delete).click({ force: true });
cy.get(apiwidget.deleteConfirm).click({ force: true });
});
Cypress.Commands.add("deleteEntityWithoutConfirmation", () => {
cy.xpath(apiwidget.popover).last().click({ force: true });
cy.get(apiwidget.delete).click({ force: true });
});
Cypress.Commands.add("DeleteAPI", () => {
cy.get(ApiEditor.ApiActionMenu).click({ multiple: true });
cy.get(apiwidget.deleteAPI).first().click({ force: true });
cy.get(apiwidget.deleteAPI).first().click({ force: true });
cy.wait("@deleteAction").should(
"have.nested.property",
"response.body.responseMeta.status",
200,
);
});
Cypress.Commands.add("NavigateToApiEditor", () => {
cy.get(explorer.addEntityAPI).click({ force: true });
});
Cypress.Commands.add("testCreateApiButton", () => {
cy.get(ApiEditor.createBlankApiCard).click({ force: true });
cy.wait("@createNewApi").should(
"have.nested.property",
"response.body.responseMeta.status",
201,
);
});
Cypress.Commands.add("createAndFillApi", (url, parameters) => {
cy.NavigateToApiEditor();
cy.get(pages.integrationCreateNew)
.should("be.visible")
.click({ force: true });
cy.testCreateApiButton();
cy.get("@createNewApi").then((response) => {
cy.get(ApiEditor.ApiNameField).should("be.visible");
expect(response.response.body.responseMeta.success).to.eq(true);
cy.get(ApiEditor.ApiNameField)
.click()
.invoke("text")
.then((text) => {
const someText = text;
expect(someText).to.equal(response.response.body.data.name);
});
});
cy.get(apiwidget.editResourceUrl)
.first()
.click({ force: true })
.type(
url + parameters,
{ parseSpecialCharSequences: false },
{ force: true },
);
cy.WaitAutoSave();
cy.get(ApiEditor.formActionButtons).should("be.visible");
cy.get(ApiEditor.ApiRunBtn).should("not.be.disabled");
});
Cypress.Commands.add("callApi", (apiname) => {
cy.get(commonlocators.callApi).first().click({ force: true });
cy.get(commonlocators.singleSelectMenuItem)
.contains("Execute a query")
.click({ force: true });
cy.get(commonlocators.selectMenuItem)
.contains(apiname)
.click({ force: true });
});
Cypress.Commands.add("checkIfApiPaneIsVisible", () => {
cy.get(ApiEditor.datasourcesRightPane).should("exist");
cy.get(ApiEditor.datasourcesRightPane).should("be.visible");
});