4217acbcc4
## Description Currently, our repository is prone to any dev pushing secrets to the repository by mistake. This can become a major problem very quickly and in the case of services like AWS, an alarm is raised and the key is deactivated causing apps using the key to break. After this PR is merged, people will need to have [git secrets](https://github.com/awslabs/git-secrets) installed in their systems and have to register the AWS secrets to the repo. The setup instructions have been mentioned [here](https://www.notion.so/appsmith/Getting-Started-e81ccc35463343b28e09c200cdbe5f42#c3183e8e6e404701920dd288b8506360) Notes: 1. right now, since we are using the pre-commit hooks using husky, the hooks work when we have done yarn install. 2. Also, the scan only checks the directory we are in while making the change or raising the PR. This is because it uses `git ls-files` to get the list of files to scan. 3. If someone doesn't run `git-secrets --register-aws`, the tests will pass automatically since there is no regex registered with the system to scan against. Fixes #15042 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes |
||
|---|---|---|
| .. | ||
| assets | ||
| docs | ||
| images | ||
| ServerCodeContributionsGuidelines | ||
| AppsmithWidgetDevelopmentGuide.md | ||
| ClientSetup.md | ||
| CodeContributionsGuidelines.md | ||
| CustomJsLibrary.md | ||
| ServerSetup.md | ||