d6e572f2b5
## Description > Leverage function arguments type generated in #28214 to better rank autocomplete results for function arguments. Current entity and field information is passed to the `CodemirrorTernService` at the time of hint generation. We check to see if the cursor position is next to a function argument and sort the results based on its type. > > #### PR fixes following issue(s) Fixes #28107 > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > #### Type of change - Bug fix (non-breaking change which fixes an issue) > > ## Testing > #### How Has This Been Tested? - [x] Manual - [x] Jest > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| AutocompleteDataType.ts | ||
| AutocompleteSortRules.ts | ||
| CodemirrorTernService.ts | ||
| customDefUtils.ts | ||
| customTreeTypeDefCreator.ts | ||
| dataTreeTypeDefCreator.ts | ||
| dataTypeSortRules.ts | ||
| defCreatorUtils.ts | ||
| keywordCompletion.ts | ||
| ternDocTooltip.tsx | ||
| TernWorkerService.ts | ||
| types.ts | ||