PromucFlow_constructor/app/client/src/workers/Evaluation/evaluationSubstitution.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

149 lines
4.4 KiB
TypeScript

import { getType, Types } from "utils/TypeHelpers";
import _ from "lodash";
import { EvaluationSubstitutionType } from "entities/DataTree/dataTreeFactory";
import { isDynamicValue } from "utils/DynamicBindingUtils";
import { QUOTED_BINDING_REGEX } from "constants/BindingsConstants";
const filterBindingSegmentsAndRemoveQuotes = (
binding: string,
subSegments: string[],
subSegmentValues: unknown[],
) => {
const bindingStrippedQuotes = binding.replace(
QUOTED_BINDING_REGEX,
(original, firstGroup) => {
return firstGroup;
},
);
const subBindings: string[] = [];
const subValues: unknown[] = [];
subSegments.forEach((segment, i) => {
if (isDynamicValue(segment)) {
subBindings.push(segment);
subValues.push(subSegmentValues[i]);
}
});
return { binding: bindingStrippedQuotes, subBindings, subValues };
};
export const smartSubstituteDynamicValues = (
originalBinding: string,
subSegments: string[],
subSegmentValues: unknown[],
): string => {
const { binding, subBindings, subValues } =
filterBindingSegmentsAndRemoveQuotes(
originalBinding,
subSegments,
subSegmentValues,
);
let finalBinding = binding;
subBindings.forEach((b, i) => {
const value = subValues[i];
switch (getType(value)) {
case Types.NUMBER:
case Types.BOOLEAN:
case Types.NULL:
case Types.UNDEFINED:
// Direct substitution
finalBinding = finalBinding.replace(b, `${value}`);
break;
case Types.STRING:
// Add quotes to a string
// JSON.stringify string to escape any unsupported characters
finalBinding = finalBinding.replace(b, `${JSON.stringify(value)}`);
break;
case Types.ARRAY:
case Types.OBJECT:
// Stringify and substitute
finalBinding = finalBinding.replace(b, JSON.stringify(value, null, 2));
break;
}
});
return finalBinding;
};
export const parameterSubstituteDynamicValues = (
originalBinding: string,
subSegments: string[],
subSegmentValues: unknown[],
) => {
const { binding, subBindings, subValues } =
filterBindingSegmentsAndRemoveQuotes(
originalBinding,
subSegments,
subSegmentValues,
);
// if only one binding is provided in the whole string, we need to throw an error
if (subSegments.length === 1 && subBindings.length === 1) {
throw Error(
"Dynamic bindings in prepared statements are only used to provide parameters inside SQL query. No SQL query found.",
);
}
let finalBinding = binding;
const parameters: Record<string, unknown> = {};
subBindings.forEach((b, i) => {
// Replace binding with $1, $2;
const key = `$${i + 1}`;
finalBinding = finalBinding.replace(b, key);
parameters[key] =
typeof subValues[i] === "object"
? JSON.stringify(subValues[i], null, 2)
: subValues[i];
});
return { value: finalBinding, parameters };
};
// For creating a final value where bindings could be in a template format
export const templateSubstituteDynamicValues = (
binding: string,
subBindings: string[],
subValues: unknown[],
): string => {
// Replace the string with the data tree values
let finalValue = binding;
subBindings.forEach((b, i) => {
let value = subValues[i];
if (Array.isArray(value) || _.isObject(value)) {
value = JSON.stringify(value);
}
try {
if (typeof value === "string" && JSON.parse(value)) {
value = value.replace(/\\([\s\S])|(")/g, "\\$1$2");
}
} catch (e) {
// do nothing
}
finalValue = finalValue.replace(b, `${value}`);
});
return finalValue;
};
export const substituteDynamicBindingWithValues = (
binding: string,
subSegments: string[],
subSegmentValues: unknown[],
evaluationSubstitutionType: EvaluationSubstitutionType,
): string | { value: string; parameters: Record<string, unknown> } => {
switch (evaluationSubstitutionType) {
case EvaluationSubstitutionType.TEMPLATE:
return templateSubstituteDynamicValues(
binding,
subSegments,
subSegmentValues,
);
case EvaluationSubstitutionType.SMART_SUBSTITUTE:
return smartSubstituteDynamicValues(
binding,
subSegments,
subSegmentValues,
);
case EvaluationSubstitutionType.PARAMETER:
return parameterSubstituteDynamicValues(
binding,
subSegments,
subSegmentValues,
);
}
};